From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id sMm6Ea44W2ZRsQAAA41jLg (envelope-from ) for ; Sat, 01 Jun 2024 17:05:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id oGqODK44W2ae6AAA62LTzQ (envelope-from ) for ; Sat, 01 Jun 2024 17:05:18 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=U7UOoRXF; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717254318; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=BCw8gEREcDWX/BAFi8wHItPGSrCCpMVLSNe5av+T5sY=; b=R3x63JpS3upP+SRln93WpafzGL8mYCQj2oLAM09BBgHBmjcKVxrAu1Lpo8j6GitSzut+Xk uurYlb74+8gb0nJZD1XOjQJz+zXAwOKSS29+Z4murKJMak2mn/TuQ+Ojn6xKXywkar3nj3 ZXwaPtHV7ZgvDm3ROvoUfTVinXbCbipCGSu7kXHS1pIzWYeoYoJhKqIwF9q5L2wWNIX13x 28t4HLEn5ABS6szVlB/ShySSo9+g+1QnJK2rqMBspObWD7AZ1DGn9wzjYS/6ON+T9gp99u b1H2KCyKjxs1VvRgIdcD1L60xxudATfHD62M909qsUkW8DEvue0tsPCc9PKDPQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=U7UOoRXF; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717254318; a=rsa-sha256; cv=none; b=dwXOzf8FC7lDC+jonE603DJOWOiBsnVmmm62XpT3DJ46WR3hE/uFGkUNTwAm8MITPE+uqN fPtWWa1OWY2QbViA19WRnfQIPzgxq9UDHgoiofVaOD4LgqlrAC8un56XQJtOX4t8HrAhTq cKvs7KfQF2qMzMlDMeLYIjbWmcj8igP0/93qSU3ic6w6SGlAOVT4/1xGksLmVWQV9MRH8S +Tw41qTmSkKDRlv6M7HO1CGTFdaVzzsqi4KCS+YWmGbnGYfPV7bR2n//EYxR/NjxUA5+EH pu5/lc7sGqpccSMwc7TvFp+zc7OlR1sYZpsfDD5WwFKV1B7STODtdwWpzuTQRg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0AA1A73300 for ; Sat, 1 Jun 2024 17:05:17 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sDQHr-0000UM-SZ; Sat, 01 Jun 2024 11:04:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDQHq-0000Tu-HG for bug-guix@gnu.org; Sat, 01 Jun 2024 11:04:50 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sDQHq-00026c-9S for bug-guix@gnu.org; Sat, 01 Jun 2024 11:04:50 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sDQI1-0002fH-NK for bug-guix@gnu.org; Sat, 01 Jun 2024 11:05:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#47144: [PATCH 3/3] gnu: patch: Graft to latest commit [security fixes]. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 01 Jun 2024 15:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47144 X-GNU-PR-Package: guix X-GNU-PR-Keywords: security To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Mark H Weaver , Leo Famulari , Vivien Kraus , 47144@debbugs.gnu.org Received: via spool by 47144-submit@debbugs.gnu.org id=B47144.171725425110181 (code B ref 47144); Sat, 01 Jun 2024 15:05:01 +0000 Received: (at 47144) by debbugs.gnu.org; 1 Jun 2024 15:04:11 +0000 Received: from localhost ([127.0.0.1]:57085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDQHD-0002e9-8D for submit@debbugs.gnu.org; Sat, 01 Jun 2024 11:04:11 -0400 Received: from mail-qk1-f173.google.com ([209.85.222.173]:46453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDQHB-0002dv-9L for 47144@debbugs.gnu.org; Sat, 01 Jun 2024 11:04:10 -0400 Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-794c3946468so218300485a.1 for <47144@debbugs.gnu.org>; Sat, 01 Jun 2024 08:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717254172; x=1717858972; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BCw8gEREcDWX/BAFi8wHItPGSrCCpMVLSNe5av+T5sY=; b=U7UOoRXFhfRxjgLbS8ZzcAh2vg+QvkuxEMsKDrYDEc53YA5QRuIm3mPcZd1O5DxCNv VDzHBgSfvrjAXK5b413EoX2zDfheH46+gt8ggSQ7iEw2h6FJRL4az4n6JLiEY1d6wfhf XwPV5m9hwrjmPgjZ52193dC5OgZ4yOSoLB5qJbyHDc2TTiveVlttoP4xw4fIPs6eZXF7 0c/Zi/R8rPYW1viMrH4M/vUldBBLzJG8/xc+XCWd6W0KAPkUOh3ik2Wp8ZbKuhkdOZmo VwQR/vUUNgkZzNQs3/Sk7MEIAYIddUiQIbGdE2hf3apUCk6IShoVdUUpeTY+uI09vPA4 tHrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717254172; x=1717858972; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BCw8gEREcDWX/BAFi8wHItPGSrCCpMVLSNe5av+T5sY=; b=NwMxb5FqGisRj2AP6EiOxk7MH58zNqP/O+s308QNvfAuXqvrIyTODMO9IYmAEp9MWb Gmu2mVrDbPZ9nJElP091zKZGJP2M5EaA1QDWUECTbDua8fErUeGBd2BTeAo/Av1Pvdvc Nq9Mike2epR9PpuJ3qrEMxCSaTxi2IWeFfGQKfuw+mvZwwh4+zdi/5/IQdME5WFfhTkU 9J1xzQXKSMLUIC8/FfTDj0GtPrJAr/TBzmedHU5rC3K1l1KjzZE8ybtSJylsfVh4FDKM a5blMzyJ0xJRvd4+0booDOrBKzlO+i4H6Kv3/tGQHan2AoNLmaAUQwmr/XK2F7Um0WqA 3Q+Q== X-Gm-Message-State: AOJu0YzU3HQf/oF0hAWE6ZF67Vqwe+2Ypa2NcLeumhK3lg4hAJ8KHi3o 654mUTgN3ZIOva8k65swmuyJ3P25hM16i1toy26A4fMZ83giUQkS X-Google-Smtp-Source: AGHT+IGZShCRmURx1QcdyFE1Irn23PJogCXNZjBJ2clHNs6S8UOnIyUiwyiQx4iOj291pj4LItDykQ== X-Received: by 2002:a37:e10b:0:b0:794:f011:7a3a with SMTP id af79cd13be357-794f5ba9aedmr503473085a.0.1717254171605; Sat, 01 Jun 2024 08:02:51 -0700 (PDT) Received: from hurd (dsl-10-130-93.b2b2c.ca. [72.10.130.93]) by smtp.gmail.com with ESMTPSA id af79cd13be357-794f2f136fbsm138695285a.53.2024.06.01.08.02.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jun 2024 08:02:51 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87r0dgn36w.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 01 Jun 2024 16:32:55 +0200") References: <28b457771ab0e7ad87cb65600a5898f68be5074a.1717124361.git.maxim.cournoyer@gmail.com> <5eda21a09360653b198f1b0d7f52cf531dc97485.1717124361.git.maxim.cournoyer@gmail.com> <87r0dgn36w.fsf@gnu.org> Date: Sat, 01 Jun 2024 11:02:49 -0400 Message-ID: <875xusln8m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 2.66 X-Migadu-Queue-Id: 0AA1A73300 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: 2.66 X-TUID: i62BtUCjZKwe Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> (define-public patch >> (package >> + (replacement patch/fixed) > > Unless I=E2=80=99m mistaken, this will have practically no effect because= Patch > is a build-time-only dependency. > > My recommendation would be to not add a =E2=80=98replacement=E2=80=99 fie= ld at all. > Instead, you could add a new =E2=80=98patch/latest=E2=80=99 public variab= le pointing to > that commit that you picked. That way, users running =E2=80=98guix insta= ll > patch=E2=80=99 or similar will get the latest version of Patch. I see what you mean, but for all practical purposes, using a graft seems a more thorough (because it affects the original 'patch' *variable* as well) means that have the same effect for users, so I'd seems like a slightly better option to me. So e.g. someone using the Guix API referencing exactly to the 'patch' package variable would get a secure version, but would otherwise need to know to adjust their code to use 'patch/latest'. Does that make sense? --=20 Thanks, Maxim