bug#71870: Some broken Go packages (including Podman)

bug#71870: Some broken Go packages (including Podman)

[Nils Landt]

[-- Attachment #1: Type: text/plain, Size: 2263 bytes --]

Building the new Podman package fails because building a depdency (gvisor-tap-vsock) fails:
 
The following derivation will be built:
/gnu/store/4lzcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv
building /gnu/store/4lzcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv...
WARNING: (guile-user): imported module (guix build utils) overrides core binding `delete'
Backtrace:
16 (primitive-load "/gnu/store/2a9k7v2qhydivh63xv921gr6kp9?")
In ice-9/eval.scm:
214:21 15 (_ #f)
217:50 14 (lp (#<procedure 7ffff77ff680 at ice-9/eval.scm:282:?> ?))
217:50 13 (lp (#<procedure 7ffff77ff660 at ice-9/eval.scm:282:?> ?))
217:50 12 (lp (#<procedure 7ffff77ff640 at ice-9/eval.scm:282:?> ?))
217:50 11 (lp (#<procedure 7ffff77ff620 at ice-9/eval.scm:282:?> ?))
217:50 10 (lp (#<procedure 7ffff77ff5c0 at ice-9/eval.scm:649:?> ?))
217:50 9 (lp (#<procedure 7ffff77ff580 at ice-9/eval.scm:282:?> ?))
217:50 8 (lp (#<procedure 7ffff77ff520 at ice-9/eval.scm:649:?> ?))
217:50 7 (lp (#<procedure 7ffff77ff500 at ice-9/eval.scm:282:?> ?))
217:50 6 (lp (#<procedure 7ffff77ff4c0 at ice-9/eval.scm:282:?> ?))
217:50 5 (lp (#<procedure 7ffff77ff4a0 at ice-9/eval.scm:282:?> ?))
217:33 4 (lp (#<procedure 7ffff77ff0a0 at ice-9/eval.scm:649:?> ?))
293:34 3 (_ #(#(#(#(#(#<directory (guile-user) 7f?> ?) ?) ?) ?) ?))
173:55 2 (_ #(#(#(#(#(#<directory (guile-user) 7f?> ?) ?) ?) ?) ?))
223:20 1 (proc #(#(#(#(#(#<directory (guile-user)?> ?) ?) ?) ?) ?))
In unknown file:
0 (%resolve-variable (5 (guix build go-build-system) . #) #)
ERROR: In procedure %resolve-variable:
In procedure module-lookup: Unbound variable: remove-go-references
builder for `/gnu/store/4lzcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv' failed with exit code 1
build of /gnu/store/4lzcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv failed
View build log at '/var/log/guix/drvs/4l/zcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv.gz'.
guix build: error: build of `/gnu/store/4lzcddslib984s8mlf854ig2lpgmnv3k-gvisor-tap-vsock-0.7.3.drv' failed
error: Recipe `guix` failed on line 13 with exit code 1
 
It looks to me like 0df957eecc536e1d0a5722b47dda1563439bbe04 removed remove-go-references, but it is still used by podman, gvisor-tap-vsock, and buildah.
 
--
Nils Landt

[-- Attachment #2: Type: text/html, Size: 3174 bytes --]

bug#71870: Some broken Go packages (including Podman)

[jgart via Bug reports for GNU Guix]

> Building the new Podman package fails because building a depdency
> (gvisor-tap-vsock) fails:

Hi Nils,

Would you be interested in sending patches to fix these failures?
-- 
all the best,
jgart

bug#71870: Some broken Go packages (including Podman)

[Nils Landt]

> jgart <jgart@dismail.de> hat am 01.07.2024 16:35 CEST geschrieben:
> 
>  
> > Building the new Podman package fails because building a depdency
> > (gvisor-tap-vsock) fails:
> 
> Hi Nils,
> 
> Would you be interested in sending patches to fix these failures?

No, the patch submission process is too annoying for me.

bug#71870: Some broken Go packages (including Podman)

[jgart via Bug reports for GNU Guix]

> No, the patch submission process is too annoying for me.
>

Hi Nils,

Sorry to hear that. I can relate to that as I've also been annoyed by aspects of the process.

Can you share some of the pain points that you've experienced with the patch submission process?

This will help us potentially address that and open discussion around it.

How do you think that the patch submission process can be improved?

I'm going to give a talk in August at the Guix London meetup on patch review, the mumi CLI tool, and my current personal workflow.

TBA,

jgart

bug#71870: Some broken Go packages (including Podman)

[Nils Landt]

> jgart <jgart@dismail.de> hat am 01.07.2024 19:04 CEST geschrieben:
> 
>  
> > No, the patch submission process is too annoying for me.
> >
> 
> Hi Nils,
> 
> Sorry to hear that. I can relate to that as I've also been annoyed by aspects of the process.
> 
> Can you share some of the pain points that you've experienced with the patch submission process?
> 
> This will help us potentially address that and open discussion around it.
>
> How do you think that the patch submission process can be improved?
 
Nothing that hasn't been talked about for years, really.

- Patch submission workflow without email
- Code review tool with threaded at-code conversations
- Code formatter that I can make work for vim (i.e. guix style for non-packages)
- Useful commit messages instead of GNU ChangeLog

My previous attempt at contribution (https://issues.guix.gnu.org/66557) was quite unpleasant.
I don't know how to phrase my critique of the reviewers in a constructive manner, given that I respect we're all human beings volunteering time for this hobby.
 
> I'm going to give a talk in August at the Guix London meetup on patch review, the mumi CLI tool, and my current personal workflow.

I will be watching the recording, but I don't see how it would address my wishlist :)

bug#71870: Some broken Go packages (including Podman)

[woshilapin]

Hi Nils, hi jgart,

> Building the new Podman package fails because building a depdency
> (gvisor-tap-vsock) fails:
> <...>
> It looks to me like 0df957eecc536e1d0a5722b47dda1563439bbe04 removed
> remove-go-references, but it is still used by podman,
> gvisor-tap-vsock, and buildah.

You might be interested in this other issue that links to some
interesting content related to the removal of `remove-go-references`,
especially the following comment.

https://issues.guix.gnu.org/71852#1

Sincerely,
--
Jean SIMARD aka woshilapin

bug#71870: Some broken Go packages (including Podman)

[jgart via Bug reports for GNU Guix]

Thanks for the link. I'll take a look

all best,

jgart

bug#71870: Some broken Go packages (including Podman)

[Jean-Pierre De Jesus Diaz]

Hello,

I've sent a few patches in <https://issues.guix.gnu.org/71923> to fix
the build of these
packages and also updates podman to latest version.

Cheers,

bug#71870: Some broken Go packages (including Podman)

[Nils Landt]

> Jean-Pierre De Jesus Diaz <jean@foundation.xyz> hat am 03.07.2024 18:40 CEST geschrieben:
> 
>  
> Hello,
> 
> I've sent a few patches in <https://issues.guix.gnu.org/71923> to fix
> the build of these
> packages and also updates podman to latest version.
> 
> Cheers,

Thank you very much Jean-Pierre.

bug#71870: Some broken Go packages (including Podman)

[Sharlatan Hellseher]

[-- Attachment #1: Type: text/plain, Size: 67 bytes --]


Hi,

Closing as resovled in other mentioned issues.

Thanks,
Oleg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]