From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add (guix gnu-maintenance).
Date: Tue, 04 Dec 2012 19:42:02 +0100
Message-ID: <874nk1vev9.fsf@inria.fr>
References: <CAD15K4t6P6+vuDAa=MZmCGJ9wSp+UZOXJvAqP98UYo5_nkzQXg@mail.gmail.com>
	<CAD15K4vBw7UixSbkAvK3vtoeqTte3hb0mvyP9SOxwesjc5-WOw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:48332)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludovic.courtes@inria.fr>) id 1TfxRe-0006Rs-JC
	for bug-guix@gnu.org; Tue, 04 Dec 2012 13:42:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludovic.courtes@inria.fr>) id 1TfxRX-0001Tb-5Z
	for bug-guix@gnu.org; Tue, 04 Dec 2012 13:42:14 -0500
Received: from mail4-relais-sop.national.inria.fr ([192.134.164.105]:34511)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludovic.courtes@inria.fr>) id 1TfxRW-0001Sn-Vu
	for bug-guix@gnu.org; Tue, 04 Dec 2012 13:42:07 -0500
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Nikita Karetnikov <nikita.karetnikov@gmail.com>
Cc: bug-guix@gnu.org

Hi,

Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:

> +(define (http-fetch str)
> +  "Fetch a file from STR, which should be a URI."

Rather:

  (define (http-fetch uri)
    "Return a string containing the textual data at URI, a string."
    ...)

> +       (error "download failed:" str code
> +              (string-downcase (response-reason-phrase resp)))))))

Please remove =E2=80=98string-downcase=E2=80=99.

> +(define %womb

Rather =E2=80=98%package-list-url=E2=80=99.

> +  (string-append "http://cvs.savannah.gnu.org/"
> +                 "viewvc/*checkout*/gnumaint/"
> +                 "gnupackages.txt?root=3Dwomb"))
> +
> +(define-public (gnu-packages-womb)

What about =E2=80=98official-gnu-packages=E2=80=99 instead?  Seems more des=
criptive to me.

Also, please use #:export instead of =E2=80=98define-public=E2=80=99 (I try=
 to avoid the
latter, and use it only in (distro packages ...) where it matters to
increase locality.)

> +  "Return a list of GNU packages."

  "Return the list of system identifiers of official GNU packages."

> +  (let ((lst (string-split (http-fetch %womb) #\nl)))
> +    (map (cut string-drop <> 9)
> +         (rx-filter lst (make-regexp "^package: (.+)$")))))

Rather:

  (define %package-line-rx
    (make-regexp "^package: (.+)$"))

  (let ((lst (string-split (http-fetch %package-list-url) #\nl)))
    (filter-map (lambda (line)
                  (and=3D> (regexp-exec %package-line-rx line)
                         (cut match:substring <> 1)))
                lst)

Can you post an updated patch?

Thanks,
Ludo=E2=80=99.