From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#17935: make check failed Date: Sat, 05 Jul 2014 19:20:04 +0200 Message-ID: <874myvsoxn.fsf@gnu.org> References: <878uo9t9mq.fsf@gmail.com> <87a98pvyj5.fsf@gnu.org> <8738eht23m.fsf@gmail.com> <87tx6wvmkx.fsf@gnu.org> <87y4w8ry22.fsf@gmail.com> <87oax4uoog.fsf@gnu.org> <87lhs8rkud.fsf@gmail.com> <87simfsy8q.fsf@gnu.org> <87fvifstzr.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55812) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3TeB-0001vj-Mz for bug-guix@gnu.org; Sat, 05 Jul 2014 13:21:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3Te3-0008Kg-2e for bug-guix@gnu.org; Sat, 05 Jul 2014 13:21:11 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:53113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3Te2-0008Kc-VX for bug-guix@gnu.org; Sat, 05 Jul 2014 13:21:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X3Te2-0003oV-Gx for bug-guix@gnu.org; Sat, 05 Jul 2014 13:21:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87fvifstzr.fsf@gmail.com> (Alex Kost's message of "Sat, 05 Jul 2014 19:30:48 +0400") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: Alex Kost Cc: 17935@debbugs.gnu.org Alex Kost skribis: > Ludovic Court=C3=A8s (2014-07-05 17:59 +0400) wrote: > >> Alex Kost skribis: >> >>> FAIL: tests/guix-register >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D >> >> [...] >> >>> + guix-register -p /home/alexx/src/guix/t-register-7895 >>> error: the path `/home/alexx/src' is a symlink; this is not allowed for= the Nix store and its parent directories >> >> Can you check whether the patch below (in addition to the previous one) >> solves the problem? >> >> diff --git a/tests/guix-register.sh b/tests/guix-register.sh >> index 019a451..f18de8d 100644 >> --- a/tests/guix-register.sh >> +++ b/tests/guix-register.sh >> @@ -58,7 +58,7 @@ guile -c " >> >> mkdir -p "$new_store/$storedir" >> new_store_dir=3D"`cd "$new_store/$storedir" ; pwd`" >> -new_store=3D"`cd "$new_store" ; pwd`" >> +new_store=3D"`cd "$new_store" ; pwd -P`" >> >> to_copy=3D"`guix build guile-bootstrap`" >> cp -r "$to_copy" "$new_store_dir" >> @@ -81,7 +81,6 @@ guix-register --prefix "$new_store" "$closure" >> >> # Now make sure this is recognized as valid. >> >> -NIX_IGNORE_SYMLINK_STORE=3D1 >> NIX_STORE_DIR=3D"$new_store_dir" >> NIX_STATE_DIR=3D"$new_store$localstatedir" >> NIX_LOG_DIR=3D"$new_store$localstatedir/log/guix" > > After this patch =E2=80=9Cguix-register=E2=80=9D test failed again, but w= hen I modified > =E2=80=9Cnew_store_dir=E2=80=9D in the same way, it passed. Here is the = modified patch: Excellent, thanks. Committed in 8ad4949. >>> Test begin: >>> test-name: "package-field-location, relative file name" >>> source-file: "/media/storage/src/guix/./tests/packages.scm" >>> source-line: 85 >>> source-form: (test-equal "package-field-location, relative file >>> name" (location-file (package-location %bootstrap-guile)) (with-fluids >>> ((%file-port-name-canonicalization (quote absolute))) (location-file >>> (package-field-location %bootstrap-guile (quote version))))) >>> Test end: >>> result-kind: fail >>> actual-value: "./gnu/packages/bootstrap.scm" >>> expected-value: "gnu/packages/bootstrap.scm" >> >> I=E2=80=99m not sure if this one relates to the symlink story, but it=E2= =80=99s harmless >> anyway. > > It's harmless but =E2=80=9Cmake check=E2=80=9D fails because of this and = now it's the > only fail left unsolved. I don't understand why those paths become so > fancy, but it happens only when I build from a symlinked directory and > doesn't happen in an absolute directory. I don't insist but perhaps it > would be better to make a less strict test. Could you run =E2=80=9C./pre-inst-env guile=E2=80=9D, type these 3 expressi= ons at the prompt, and send the result: (with-fluids ((%file-port-name-canonicalization 'relative)) (call-with-input-file (search-path %load-path "gnu/packages/bootstrap.s= cm") port-filename)) (search-path %load-path "gnu/packages/bootstrap.scm") (version) TIA, Ludo=E2=80=99.