From: ludo@gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong@gmail.com>
Cc: 18698@debbugs.gnu.org
Subject: bug#18698: Our WindowMaker wrapper pollutes PATH in the entire X session
Date: Sun, 01 Mar 2015 15:39:39 +0100 [thread overview]
Message-ID: <874mq4g4t0.fsf@gnu.org> (raw)
In-Reply-To: <87h9upm5ih.fsf@gmail.com> ("宋文武"'s message of "Sat, 14 Feb 2015 13:22:30 +0800")
宋文武 <iyzsong@gmail.com> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> 宋文武 <iyzsong@gmail.com> skribis:
>>
>>> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>>>
>>>> The fix may have resulted in unintended side-effects. On a fresh
>>>> installation of the System Distribution v0.8.1 WindowMaker is installed
>>>> by default, but it is not completely functional.
>>>>
>>>> For example, the attempt to change the style via the menu results in
>>>> this error to be displayed:
>>>>
>>>> Could not execute command:
>>>> setstyle /gnu/store/...windowmaker.../share/WindowMaker/Styles/Black.style
>>>>
>>>> Likewise, selecting "Configure Window Maker" from the right-click menu
>>>> results in this error:
>>>>
>>>> Could not execute command: exec WPrefs
>>>>
>>>> The "setstyle" executable is located in
>>>> /gnu/store/...windowmaker.../bin/, but is not in the PATH.
>>> Yes, the $out/bin of windowmaker is not in $PATH, and same for sawfish.
>>>
>>> Instead of wrapping every executable of session-type, we can:
>>>
>>> #1: Add the package to system profile ('packages').
>>> It's not clear to me how to do it now, until we have something
>>> like the NixOS's module system.
>>
>> What I have in mind is to add a ‘packages’ field in ‘service’. That
>> would allow service implementations to contribute packages to the global
>> profile. Thoughts?
> It's fine, but we may also need a 'dbus-service' field (for wicd).
Hmm right. And dbus policy, and policykit something, and...
Clearly the NixOS way where each service can change anything in the
global config makes it easy; we need to find a middle ground where we
don’t end up allowing services to do anything. Food for thought...
>>> #2: Make SLiM use '/run/current-system/profile/share/xsessions' as
>>> session_dir.
>>> So simply add a package providing xsession file to 'packages' should
>>> make it available to SLiM. And all DE and many window-managers provide
>>> xsession files already (eg: openbox, sawfish, xfce), we can patch
>>> the rest (eg: WindowMaker) to install one.
>>
>> IIUC the bug initially reported here would remain: the user’s $PATH
>> would be polluted with the window manager’s stuff, no?
> I think the 'polluted' means we have a $PATH contains:
> /gnu/store/xxx-windowmaker/bin
> install it to profile doesn't have this issue.
Right, but WindowMaker is not necessarily in the user’s profile.
Still, maybe the initial solution, which added WindowMaker to $PATH, is
the least undesirable solution.
Thoughts?
Ludo’.
next prev parent reply other threads:[~2015-03-01 14:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 0:48 bug#18698: Our WindowMaker wrapper pollutes PATH in the entire X session Mark H Weaver
2014-11-13 7:59 ` Ludovic Courtès
2015-02-10 11:01 ` Ricardo Wurmus
2015-02-11 12:32 ` 宋文武
2015-02-12 20:15 ` Ludovic Courtès
2015-02-14 5:22 ` 宋文武
2015-03-01 14:39 ` Ludovic Courtès [this message]
2020-10-13 14:43 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mq4g4t0.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=18698@debbugs.gnu.org \
--cc=iyzsong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).