unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: 20067@debbugs.gnu.org
Subject: bug#20067: fix interpretation of grub configuration
Date: Tue, 23 Feb 2016 14:45:36 +0100	[thread overview]
Message-ID: <874mczk0an.fsf@gnu.org> (raw)
In-Reply-To: <20150309203443.GA3438@venom> ("Tomáš Čech"'s message of "Mon, 9 Mar 2015 21:34:43 +0100")

Tomáš Čech <sleep_walker@suse.cz> skribis:

> Grub configuration interpretes `linux' as directory where is located
> bzImage. If I enter file name instead, result configuration will be
> wrong.

The solution will be to not automatically append “/bzImage” (and
likewise for the initrd.)

We could change places where ‘menu-entry’ is instantiated to:

  #~(string-append #$kernel "/bzImage")

However, there’s the problem that the image name appears in the
‘parameters’ file of the system (as seen in the output of ‘guix system
build foo.scm’), where it is unevaluated.  If we use ‘string-append’ as
above, a raw (string-append …) sexp will appear in there, which is not
nice.

To address this, an idea is to add “expanders” for gexps: gexps already
have “compilers”, and expanders would be similar except that they would
produce something possibly different from just the derivation’s output
file name.  For instance, we could write:

  (file-append kernel "/bzImage")

and that would expand directly to:

  "/gnu/store/…/bzImage"

Ludo’.

  reply	other threads:[~2016-02-23 13:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 20:34 bug#20067: fix interpretation of grub configuration Tomáš Čech
2016-02-23 13:45 ` Ludovic Courtès [this message]
2016-09-09 22:03   ` Ludovic Courtès
2016-09-14 16:16     ` Tomáš Čech
2016-09-25 15:56       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mczk0an.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=20067@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).