From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#25414: [PATCH] gnu: gdk-pixbuf: Make it reproducible.
Date: Mon, 16 Jan 2017 14:44:04 +0100
Message-ID: <874m0zyva3.fsf__42660.161961294$1484575237$gmane$org@gnu.org>
References: <20170114102117.71ec814d@scratchpost.org>
	<20170115012207.2604-1-dannym@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42257)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cT7at-0004xt-9k
	for bug-guix@gnu.org; Mon, 16 Jan 2017 08:45:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cT7ao-0005HG-Ie
	for bug-guix@gnu.org; Mon, 16 Jan 2017 08:45:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:39897)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cT7ao-0005H8-FH
	for bug-guix@gnu.org; Mon, 16 Jan 2017 08:45:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cT7ao-0003bl-9o
	for bug-guix@gnu.org; Mon, 16 Jan 2017 08:45:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.25414.B25414.148457425613802@debbugs.gnu.org>
In-Reply-To: <20170115012207.2604-1-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Sun, 15 Jan 2017 02:22:07 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org, 25414@debbugs.gnu.org

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/packages/gtk.scm (gdk-pixbuf): Make it reproducible.

Rather:

  Fixes <http://bugs.gnu.org/25414>.

  * gnu/packages/gtk.scm (gdk-pixbuf)[source](patches): New field.

> diff --git a/gnu/packages/patches/gdk-pixbuf-list-dir.patch b/gnu/package=
s/patches/gdk-pixbuf-list-dir.patch
> new file mode 100644
> index 000000000..d1427cc38
> --- /dev/null
> +++ b/gnu/packages/patches/gdk-pixbuf-list-dir.patch

Please add a one-line comment, like:

  Sort directory entries so that the output of
  =E2=80=98gdk-pixbuf-query-loaders=E2=80=99 is deterministic.

OK with these changes for a new =E2=80=98staging=E2=80=99 branch!

Also, it would be nice if you could report it upstream and add the
reference in the .patch file.

Thank you!

Ludo=E2=80=99.