From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#23194: Benign error in installation image: "stty: standard input:
	Input/output error"
Date: Thu, 07 Dec 2017 10:18:16 +0100
Message-ID: <874lp2dhgn.fsf@gnu.org>
References: <87lh4v7m5c.fsf@gmail.com> <87fuv1ctrz.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35282)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eMsKg-0005dr-KT
	for bug-guix@gnu.org; Thu, 07 Dec 2017 04:19:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eMsKc-0004I9-LI
	for bug-guix@gnu.org; Thu, 07 Dec 2017 04:19:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:41181)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eMsKc-0004Hz-I1
	for bug-guix@gnu.org; Thu, 07 Dec 2017 04:19:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eMsKc-0001A2-Bx
	for bug-guix@gnu.org; Thu, 07 Dec 2017 04:19:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-guix@gnu.org
Resent-Message-ID: <handler.23194.D23194.15126383014406.done@debbugs.gnu.org>
In-Reply-To: <87fuv1ctrz.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Mon, 04 Apr 2016 16:50:40 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: 23194-done@debbugs.gnu.org

Hi Chris,

ludo@gnu.org (Ludovic Court=C3=A8s) skribis:

> Chris Marusich <cmmarusich@gmail.com> skribis:
>
>> In the installation image for GuixSD v0.10.0, I get some I/O errors on
>> the terminal just before/during/after the MOTD is displayed:
>>
>> "stty: standard input: Input/output error"
>
> These appear to come from the =E2=80=98unicode_start=E2=80=99 command, ru=
n by the
> =E2=80=98console-font=E2=80=99 services.  =E2=80=98unicode_start=E2=80=99=
 is a shell script in the =E2=80=98kbd=E2=80=99
> package that does:
>
>   stty iutf8
>
> In a =E2=80=98guix system vm gnu/system/install.scm=E2=80=99 VM in curren=
t master, I
> sometimes get a different message:
>
>   unicode_start skipped on not a tty
>
> The =E2=80=9Cnot a tty=E2=80=9D string comes from the =E2=80=98tty=E2=80=
=99 command (Coreutils).  We get
> it when:
>
>   ttyname (STDIN_FILENO);
>
> returns NULL; this can happen if =E2=80=98tcgetattr=E2=80=99 returns NULL=
 (see ttyname.c
> in libc.)

I=E2=80=99m happy to say that this is fixed in the 0.14.0 installation imag=
e:

  https://git.savannah.gnu.org/cgit/guix.git/commit/?h=3Dversion-0.14.0&id=
=3D787e8a80d54d8bd5320d76276dc5f4bafe5b86c0

We now use our =E2=80=98tcsetattr=E2=80=99 bindings directly instead of inv=
oking
=E2=80=98unicode_start=E2=80=99.  Additionally, we wait until the TTY reall=
y exists
(i.e., mingetty has become its session leader) by checking the return
value of =E2=80=98ttyname=E2=80=99.

Ludo=E2=80=99.