From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: bug#34595: [PATCH] gnu: Add emacs-shroud Date: Wed, 20 Feb 2019 22:36:33 +0100 Message-ID: <874l8y5ehq.fsf@elephly.net> References: <87o976p4z3.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([209.51.188.92]:50804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwZY8-00061w-73 for bug-guix@gnu.org; Wed, 20 Feb 2019 16:37:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwZY7-0006Kb-75 for bug-guix@gnu.org; Wed, 20 Feb 2019 16:37:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57899) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwZY7-0006K8-0l for bug-guix@gnu.org; Wed, 20 Feb 2019 16:37:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gwZY6-0005PF-Si for bug-guix@gnu.org; Wed, 20 Feb 2019 16:37:02 -0500 Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Message-ID: In-reply-to: <87o976p4z3.fsf@disroot.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Amar Singh Cc: 34595-done@debbugs.gnu.org, 34364@debbugs.gnu.org Hi, > Shroud is a password manager written in Guile which uses GnuPG in the > backend. This package is an Emacs interface to Shroud using the Buffers > User Interface library. You have previously already submitted a variant of this: https://issues.guix.info/issue/34364 Please don=E2=80=99t open more tickets for this but instead send updates to= the same ticket. I=E2=80=99m closing this issue, because what you attached is = not a git formatted patch. > +(define-public nly/emacs-shroud We don=E2=80=99t use personal prefixes like =E2=80=9Cnly/=E2=80=9D in Guix. > + (package > + (name "emacs-shroud") > + (version "ad5de6d") A version string must be monotonically increasing over time. Commit hashes don=E2=80=99t do that, so we use (git-version last-release revision commit) instead. We prefer releases over arbitrary commits. Since you are the developer, could you please tell us what the difference is between this version and the previous release? Could you make a new release instead? > + (build-system emacs-build-system) > + (propagated-inputs > + `(("emacs-f" ,emacs-f) > + ("emacs-s" ,emacs-s) > + ("emacs-bui" ,emacs-bui) > + ("shroud" ,shroud))) > + (home-page "http://nly.info.tm:9001/emacs/shroud.el") > + (synopsis "Shroud (gpg) support for Emacs") Why =E2=80=9C(gpg)=E2=80=9D? It=E2=80=99s probably better to say =E2=80=9C= Shroud password manager interface for Emacs=E2=80=9D. > + (description > + "This package provides functions for working with shroud password > manager.") I=E2=80=99d not say =E2=80=9Cfunctions=E2=80=9D. How about This package provides an Emacs minor mode for working with the Shroud password manager. Could you please send an updated patch? -- Ricardo