From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: bug#33497: [PATCH] Re: bug#33497: Our CMake package has no documentation Date: Sun, 17 Mar 2019 17:36:00 +0100 Message-ID: <874l81a26n.fsf@fastmail.com> References: <8736rp649l.fsf@apteryx.i-did-not-set--mail-host-address--so-tickle-me> <87y39h4pfk.fsf@gmail.com> <878sykiwwq.fsf@fastmail.com> <87o96glvvm.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:46576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5Ynj-0002cZ-Nt for bug-guix@gnu.org; Sun, 17 Mar 2019 12:38:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5YmU-0006K2-S9 for bug-guix@gnu.org; Sun, 17 Mar 2019 12:37:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34142) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h5YmU-0006Io-3X for bug-guix@gnu.org; Sun, 17 Mar 2019 12:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h5YmT-00054B-Qv for bug-guix@gnu.org; Sun, 17 Mar 2019 12:37:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87o96glvvm.fsf@gmail.com> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Maxim Cournoyer Cc: 33497@debbugs.gnu.org --=-=-= Content-Type: text/plain Maxim Cournoyer writes: > Hello Marius! > > Sorry for the delay. > > Marius Bakke writes: > >> Hello! >> >> Now would be the time to get this in 'core-updates'. >> >> Maxim Cournoyer writes: >> >>> Maxim Cournoyer writes: >>> >>>> Hello, >>>> >>>> Our CMake package lacks any documentation (manpage or other). Patch to >>>> follow. >>>> >>>> Maxim >>> >>> Here's the patch to be merged in core-updates (or core-updates-next). >>> >>> From 07625983cd901c94e4ac25b157035c95e33a115e Mon Sep 17 00:00:00 2001 >>> From: Maxim Cournoyer >>> Date: Sun, 25 Nov 2018 01:39:54 -0500 >>> Subject: [PATCH] gnu: cmake: Generate the documentation. >>> >>> This fixes https://bugs.gnu.org/33497. >>> >>> * gnu/packages/cmake.scm (gnu): Use the (gnu package python) and >>> (gnu packages texinfo) modules. >>> (cmake)[configure]: Add arguments to configure so that manual pages, info and >>> HTML documentation is generated. >>> [move-html-doc]: New phase. >>> [native-inputs]: Add the native inputs required for building the >>> documentation. >>> [outputs]: Add a "doc" output. >> >> I'm not very comfortable with pulling python-sphinx into the dependency >> closure of CMake, because then we can't update it or its dependencies >> outside of the 'core-updates' cycle. It could also cause circular >> dependency issues down the road. >> >> Would it make sense to build the documentation as a separate package? >> In that case it can go on the master branch. > > I don't like the idea of having a separate package for the documentation > of cmake because it goes against the expectations of Guix users (package > comes with its manpage, and extra doc can be installed as extra output > of the same package). > > Maybe we could have a "cmake-minimal" package we'd keep hidden and use > by default as part of the cmake-build-system, which wouldn't include the > doc, and the regular, user facing cmake would be the one in this patch? This sounds reasonable to me. Can you send a patch? :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlyOd3AACgkQoqBt8qM6 VPpzJAf/U3fobW6njfZG6CHx0lpNJqXlVLXH3UW/dojf8tAlLLKIMo1zB2cRRm1M kNarL9CljeQ4SXgVXwbnI9wepn4EDgTem//VNXWopyo88x5Q39B0aBtfxP5zkc01 SKcukakEiOv3zjd3+xrDmQ6vPQ2yR2jT1y2ymLGdjXLnLkvw9BeZ/9aDZxfhuJC6 ucmFqs41klJVfLJsxhIvB5wDSnvPRX3vhydPVbdc3hM8sgrRgSBt06mnAOF7tynz rToeN/C6w/tfcZf5DlUK2vtBZLBdrXlEp26fn78q0oKqfZJz6YnlrtJTlbLB+KW2 qPGLVoBq72InUrkGJmnp/qDkoPcyXQ== =rh9B -----END PGP SIGNATURE----- --=-=-=--