From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Subject: bug#26302: [website] translations Date: Fri, 01 Nov 2019 15:54:42 +0100 Message-ID: <874kznbqa5.fsf@gnu.org> References: <20170329154040.ddscahwp2agknihb@abyayala> <16d07cb5a1d.ca69255821627.8144164908931126811@zoho.com> <20190908171638.cna67eearj4rbn2k@pelzflorian.localdomain> <16d18a5a9e8.12ab66c8254154.2756956535677606704@zoho.com> <20190915201819.3yxm25fayvbxwdpl@pelzflorian.localdomain> <20191007081502.wog4q4wjptvhmejf@pelzflorian.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:43844) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQYKP-00032z-1q for bug-guix@gnu.org; Fri, 01 Nov 2019 10:55:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQYKM-0002qX-34 for bug-guix@gnu.org; Fri, 01 Nov 2019 10:55:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47993) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQYKL-0002oL-Tb for bug-guix@gnu.org; Fri, 01 Nov 2019 10:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iQYKL-0007HC-Op for bug-guix@gnu.org; Fri, 01 Nov 2019 10:55:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20191007081502.wog4q4wjptvhmejf@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Mon, 7 Oct 2019 10:15:03 +0200") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: "pelzflorian (Florian Pelz)" Cc: sirgazil , 26302 <26302@debbugs.gnu.org> Hi Florian "pelzflorian (Florian Pelz)" skribis: >>From 9ec69c888b978cb870a5873af8e327541fe4ef7a Mon Sep 17 00:00:00 2001 > From: Florian Pelz > Date: Sun, 6 Oct 2019 20:45:34 +0200 > Subject: [PATCH 1/2] [wip] gnu: Add ngx_http_accept_language_module. > > * gnu/packages/web-xyz.scm: New file. > * gnu/local.mk (GNU_SYSTEM_MODULES): Add package. [...] > +++ b/gnu/packages/web-xyz.scm > @@ -0,0 +1,175 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;;; TODO should I really add copyright lines for people I copied from?? > +;;; Copyright =C2=A9 2014, 2015 Mark H Weaver > +;;; Copyright =C2=A9 2016 Tobias Geerinckx-Rice > +;;; Copyright =C2=A9 2017, 2018 Marius Bakke I don=E2=80=99t think you need to add these 3 lines here; the package defin= ition is yours. > +(define-public nginx-mod-accept-language > + (let ((commit "2f69842f83dac77f7d98b41a2b31b13b87aeaba7") > + (revision "1")) Is there no upstream version? If that=E2=80=99s the case, that=E2=80=99s f= ine, but please add a comment explaining it. > + (package > + (name "nginx-mod-accept-language") Perhaps =E2=80=9Cnginx-accept-language-module=E2=80=9D, to match the name o= f the upstream repo? > + (modules '((guix build utils) > + (ice-9 popen))) > + (snippet > + #~(begin > + ;; the nginx source code is part of the module=E2=80=99s s= ource > + (format #t "decompressing nginx source code~%") > + (call-with-output-file "nginx.tar" > + (lambda (out) > + (let ((pipe (open-pipe* OPEN_READ > + #+(file-append gzip "/bin/gzip= ") "-cd" > + #$(package-source nginx)))) > + (dump-port pipe out) > + (unless (=3D (status:exit-val (close-pipe pipe)) 0) > + (error "gzip decompress failed"))))) > + (invoke #+(file-append tar "/bin/tar") "xvf" "nginx.tar" > + "--strip-components=3D1") > + (delete-file "nginx.tar") I=E2=80=99d suggest doing it in a phase. > + (license (delete-duplicates > + (cons license:bsd-2 ;license of nginx-mod-accept-language > + (package-license nginx))))))) ;the module=E2=80=99= s code is linked To avoid circular dependencies in top-level references, I suggest copying the license of =E2=80=98nginx=E2=80=99 instead of writing (package-= license nginx). > + nginx-configuration-load-modules > nginx-configuration-extra-content > nginx-configuration-file >=20=20 > @@ -522,6 +524,7 @@ > (default #f)) > (server-names-hash-bucket-max-size nginx-configuration-server-names-ha= sh-bucket-max-size > (default #f)) > + (load-modules nginx-configuration-load-modules (default '())) What about =E2=80=9Cloaded-modules=E2=80=9D, =E2=80=9Cloadable-modules=E2= =80=9D, or simply =E2=80=9Cmodules=E2=80=9D? =E2=80=9Cload-modules=E2=80=9D sounds imperative whereas the rest of the co= nfig is declarative. Apart from that it LGTM. >>From ea5edd15586722b3557912e81171e69f7be339fa Mon Sep 17 00:00:00 2001 > From: Florian Pelz > Date: Mon, 7 Oct 2019 07:58:30 +0200 > Subject: [PATCH] berlin: Redirect to localized website depending on > Accept-Language header. > > * hydra/nginx/berlin.scm (guix.gnu.org-locations): Redirect html URLs. > (%nginx-configuration): Load required nginx dynamic module. LGTM, but I guess we=E2=80=99ll commit it when we=E2=80=99re ready to switc= h to the new web site. Thanks! Ludo=E2=80=99.