From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CPLPAVIEj2CSgQEAgWs5BA (envelope-from ) for ; Sun, 02 May 2021 21:58:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iKZxOFEEj2C2TAAAB5/wlQ (envelope-from ) for ; Sun, 02 May 2021 19:58:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 62E0F15219 for ; Sun, 2 May 2021 21:58:09 +0200 (CEST) Received: from localhost ([::1]:32880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldIEC-0001ea-J8 for larch@yhetil.org; Sun, 02 May 2021 15:58:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldIE6-0001eS-Cw for bug-guix@gnu.org; Sun, 02 May 2021 15:58:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32881) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldIE6-0003sw-5g for bug-guix@gnu.org; Sun, 02 May 2021 15:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldIE6-0000AW-4t for bug-guix@gnu.org; Sun, 02 May 2021 15:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#48114: Disarchive occasionally fails tests Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 02 May 2021 19:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48114 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Timothy Sample Received: via spool by 48114-submit@debbugs.gnu.org id=B48114.1619985477642 (code B ref 48114); Sun, 02 May 2021 19:58:02 +0000 Received: (at 48114) by debbugs.gnu.org; 2 May 2021 19:57:57 +0000 Received: from localhost ([127.0.0.1]:44427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldIE0-0000AI-Mi for submit@debbugs.gnu.org; Sun, 02 May 2021 15:57:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldIDx-0000AC-2i for 48114@debbugs.gnu.org; Sun, 02 May 2021 15:57:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39096) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldIDq-0003jy-6e; Sun, 02 May 2021 15:57:47 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47022 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ldIDo-00053f-Dj; Sun, 02 May 2021 15:57:45 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87v984gkhn.fsf@inria.fr> <87pmybeen3.fsf@ngyro.com> Date: Sun, 02 May 2021 21:57:43 +0200 In-Reply-To: <87pmybeen3.fsf@ngyro.com> (Timothy Sample's message of "Fri, 30 Apr 2021 15:49:52 -0400") Message-ID: <874kfk6h8o.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 48114@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619985489; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=MBgLaigIPPFts/EP44uehPwIiftVbny17znZcfGVKRk=; b=DKmtjmAbtMAglo6yg3dwIioRT1Vd09KcR9IjIVJUPPsgAW0La8BVEBjbjSF9LlNxmD/3/q 4LNBPsgzuDAATdP348pDpUNohirN8pmvCRgEKquBZ+Afm/e+fQlnGHYL8X+pI+hwgBSUk4 HDHugEfHwZ7EPsVC5iNdG+IzxSPWADC5R8RcwUVwTsAwPK2yHWFTrQiIQ6MScVF320ryM7 bWBeX/uxItgo1R1hmZ2PiUrxSzx/G1odcxN1St6+DO6eamouzxZgVxFDZzyhrsxtlkjk/I otDura99+oJmargfeWXvRn7bNTaURi4fQUETsRMOb/HuPczD6MayvJp3S9QHAg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619985489; a=rsa-sha256; cv=none; b=Y6mwlWuQirGYIPFKYh/F576YmsCMs6l4UhbB6jR1LvI/PkeFVR3wEy3cuRqbThgGS3EZxB Sr3jfgcSy58wlq7AjZCFzsmnYUbwyzg96Ui/yKVw/nh/yx2gxCfAl2RriU0Ojys8p0S4/U STr4y2wmaljpoZ719/WMdLiw6BvoE0QhOTYsrwW0Oq4NZirBfqLnv19fBzsNI32JM3hPFK 6cmNa1efooHH+W8XZeLPEJCbxxG9rYntuCXaYrsERiykqbnV/pkepQU4TB1q1XbIW85JzO o4jiwCyt3msgWn+ty3zjty9SvuKy1mD5x03bKKmO2ZxvpEa0t8sG4oJRAao7DA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.96 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 62E0F15219 X-Spam-Score: -2.96 X-Migadu-Scanner: scn0.migadu.com X-TUID: mcLaDDT7zS/o Hello! Timothy Sample skribis: > I can=E2=80=99t seem to reproduce this. I=E2=80=99ve run the test suite = many, many > times, but I also tried: I can reproduce it quickly with: while make check TESTS=3Dtests/kinds/octal.scm -j5 ; do : ; done =E2=80=A6 in C locale (LC_ALL & co. all unset). > However, isn=E2=80=99t it possible that these values aren=E2=80=99t the c= ulprits? With > the =E2=80=9Cpk=E2=80=9D calls you added, isn=E2=80=99t it printing the l= ast OK value without > telling us the value causing the issue? You=E2=80=99re right, the values printed are not the culprit. The problem = comes from the generator (I had to raise the (quickcheck =E2=80=A6) form out of =E2=80=98test-assert=E2=80=99 so I could get a backtrace): --8<---------------cut here---------------start------------->8--- Backtrace: 13 (primitive-load "/data/src/disarchive/./build-aux/test-driver.= scm") In ice-9/eval.scm: 619:8 12 (_ #(#(# ((() "./tests/ki= nds/octal.scm") (# . "no") (# . #) ?)) #)) 619:8 11 (_ #(#(#(#(#(#(#(#(# ("./= tests/kinds/octal?") ?)) ?) ?) ?) ?) ?) ?)) In ice-9/boot-9.scm: 142:2 10 (dynamic-wind _ _ #) In unknown file: 9 (primitive-load "./tests/kinds/octal.scm") In quickcheck.scm: 118:6 8 (check #< seed: 321557891 stop?: # ?) 98:12 7 (check-results _ #< names: (octal) gen/arbs: (#< gen: #< proc: #) In quickcheck/generator.scm: 65:2 6 (_ 7 #< start: #(1907167801 2749187034 1190323419 1= 039883844 766725436 3567744198) s1: #(29?>) 65:2 5 (_ 7 #< start: #(1907167801 2749187034 1190323419 1= 039883844 766725436 3567744198) s1: #(29?>) 78:17 4 (_ 7 #< start: #(1907167801 2749187034 1190323419 1= 039883844 766725436 3567744198) s1: #(28?>) 105:22 3 (_ _) In tests/kinds.scm: 84:22 2 (fix-unstructured-octal-value #< value: 7 = source: #< value: "\U0f99aa?>) 86:47 1 (_ _) In unknown file: 0 (substring "\U0f99aa?\U0ff7c1\U0fb97a\U0ff933?\U0fe7a1" 6 8) ERROR: In procedure substring: Value out of range 6 to 7: 8 --8<---------------cut here---------------end--------------->8--- Note that this is in C locale, which may mean that =E2=80=98regexp-exec=E2= =80=99, which passes strings to libc, gets offsets wrong somehow (see =E2=80=98fixup_multibyte_match=E2=80=99 in libguile), though I couldn=E2=80= =99t reproduce it with the string above. Anyway, =E2=80=98guix build disarchive=E2=80=99 builds in en_US.utf8 locale= , so the thing above is probably a wrong lead. If I switch to en_US.utf8, I occasionally get the following error instead: --8<---------------cut here---------------start------------->8--- test-name: [prop] Serializing is reversible location: tests/kinds/octal.scm:154 source: + (test-assert + "[prop] Serializing is reversible" + (quickcheck + (property + ((octal $octal)) + (test-when + (valid-octal? octal) + (equal? + (pk 'OCT octal) + (pk 'DECODE (serdeser -octal- octal))))))) ;;; (OCT #< value: 0 source: #< value: "" = trailer: "">>) ;;; (DECODE #< value: 0 source: #< value: = "" trailer: "">>) Gave up! Passed only 1 est. actual-value: #f result: FAIL --8<---------------cut here---------------end--------------->8--- This is more in line with what you described. Any ideas on how to address that? Thanks, Ludo=E2=80=99.