From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ELlXJcPd3WH7RAEAgWs5BA (envelope-from ) for ; Tue, 11 Jan 2022 20:42:59 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id SAnsIcPd3WFIeAEAauVa8A (envelope-from ) for ; Tue, 11 Jan 2022 20:42:59 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0BF1F2B9F6 for ; Tue, 11 Jan 2022 20:42:59 +0100 (CET) Received: from localhost ([::1]:37854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7N2m-00012P-Bh for larch@yhetil.org; Tue, 11 Jan 2022 14:42:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7N1v-0000fW-1P for bug-guix@gnu.org; Tue, 11 Jan 2022 14:42:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34493) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7N1u-0006bC-O4 for bug-guix@gnu.org; Tue, 11 Jan 2022 14:42:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7N1u-0007AL-Mu for bug-guix@gnu.org; Tue, 11 Jan 2022 14:42:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#53194: System test partition.img differs in size across hosts(?) Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 11 Jan 2022 19:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53194 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 53194@debbugs.gnu.org X-Debbugs-Original-To: Bug reports for GNU Guix Received: via spool by submit@debbugs.gnu.org id=B.164193008127434 (code B ref -1); Tue, 11 Jan 2022 19:42:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Jan 2022 19:41:21 +0000 Received: from localhost ([127.0.0.1]:55629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7N1E-00078P-PA for submit@debbugs.gnu.org; Tue, 11 Jan 2022 14:41:21 -0500 Received: from lists.gnu.org ([209.51.188.17]:37920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7N19-000783-RX for submit@debbugs.gnu.org; Tue, 11 Jan 2022 14:41:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7N14-0008Kb-A8 for bug-guix@gnu.org; Tue, 11 Jan 2022 14:41:11 -0500 Received: from [2a02:c205:2020:6054::1] (port=40942 helo=tobias.gr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7N11-0006GR-8r for bug-guix@gnu.org; Tue, 11 Jan 2022 14:41:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=dlZ8YOSGrRSgP XkX5mBYq0zqXUStsj9CqUd/gOxP2WE=; h=date:subject:to:from; d=tobias.gr; b=nfDe/aJMhaGMeMdTyb0bZJiImzldm1c5Nkmw7oXCYUFP8NJ3ChKsCMHZHaQGedL5oKQ9 clpHA/3Uqu8wLIzRS0sCqGLn3CZXbr1nIKxktDWMSsb2F6GjH91jCbhh5gkihfHUPJpDt8 TsYyuG3BF2ZrA2DT1G6+IeHQycfMEXKKLxwaOTQnXq68DWF0a1I+BGcIqop03X7VRIQVIa ya2sm2yehGa2Gh9o8Qw3vBXM4e+yAE+UfEY4tZBw8Yxk+NXom46mdt5qPeBDIPBhkhnvOa 7z28Xt2zFum18Y3NeFc9EvBVqfNy43J3V9CEh2nczTqHnZ9fkq3ykS0/aDFT1YCA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 9792ac40 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Tue, 11 Jan 2022 19:40:56 +0000 (UTC) Date: Tue, 11 Jan 2022 20:31:27 +0100 BIMI-Selector: v=BIMI1; s=default; Message-ID: <874k6akqlx.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:c205:2020:6054::1 (failed) Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RDNS_NONE=0.793, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" Reply-to: Tobias Geerinckx-Rice From: Tobias Geerinckx-Rice via Bug reports for GNU Guix X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641930179; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:list-id:list-help:list-unsubscribe:list-subscribe: list-post:dkim-signature; bh=dlZ8YOSGrRSgPXkX5mBYq0zqXUStsj9CqUd/gOxP2WE=; b=klnmg4rRppw4n8aTPWM0DjSS46ULMnawlmcKIwcBH28rQl2zhqyDzzVrdrOI4+4dw0Psvp SlTg1zinXi7UHPHPwtIADq7IQUNIH1C5HJNvXw21z4Zi0vlJdfA6NgEMadiino0mJK+1oY FHvi5HCLaMyDHFWqsex+I9PSwwdBDykxK9Y8DKgCuai1qjfeIY34aeF8ddW8hayNRPXenH /OKCwE1Fa89m2jzupPds2wKYotha3QIBpIYRb0+SFfl9SeduHvJ56pnIl/YVBfuxAOX3z9 EHk3GdIC1WInhxnwqjMk+HCgPXZtMp9SLVJ29kYa7eNElerQlYaYgacps//BFQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641930179; a=rsa-sha256; cv=none; b=e0wIALKxDNmAqFgU8E7wiJALXoEkO5jexVloXhCAGxBgzviLGngCvf9Mq/cJxzKKg/bvmq OPjSJhPKuJ1KmDvkhT7y5Px4+5u6ba7s8mIcoWOdHNJwvbSNONJRlWvpCgumHovdmzb78g 2Rc36choAm5B7Po7RG3Kr/FXlx4oJ3nl1hpy/68E7duya7k0d7+rFgZ36Y6K2kbYFVppzG mnjvWgn1N7dZtyre9nb3zamWwv9iDrFXqwBuXpm37dRYW3IKf/Cs9PPXhM0XwCs8t672Id CNDX2omN6dkSIB2YrMVY/ytOM9nns343hIyQT+sOflbaww7HEYPOXSLwWj+JZw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b="nfDe/aJM"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.22 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b="nfDe/aJM"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0BF1F2B9F6 X-Spam-Score: -6.22 X-Migadu-Scanner: scn0.migadu.com X-TUID: ZkfOAo+1te2U --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Guix, This is weird. On berlin: =2D-8<---------------cut here---------------start------------->8--- $ guix build=20 /gnu/store/91wjmydy556ibl38xydpb8yisp3gvx8w-partition.img.drv [=E2=80=A6] Creating filesystem with 351 1k blocks and 40 inodes [=E2=80=A6] /gnu/store/q18ca3ilma0h5hpn4s39xhzn0kc7jm5x-partition.img =2D-8<---------------cut here---------------end--------------->8--- On my laptop: =2D-8<---------------cut here---------------start------------->8--- $ guix build=20 /gnu/store/91wjmydy556ibl38xydpb8yisp3gvx8w-partition.img.drv [=E2=80=A6] Creating filesystem with 242 1k blocks and 32 inodes [=E2=80=A6] Copying files into the device: ext2fs_symlink: Could not allocate=20 inode in ext2 filesystem while creating symlink "system" __populate_fs: Could not allocate inode in ext2 filesystem while=20 writing symlink"system" mke2fs: Could not allocate inode in ext2 filesystem while=20 populating file system =2D-8<---------------cut here---------------end--------------->8--- This happens with both a tmpfs and a bcachefs /tmp. The same make check-system TESTS=3D"openvswitch" fails for Marius as=20 well, although I don't know the exact output. They tested btrfs=20 and tmpfs, and suggested a kernel regression. I don't understand how that would cause this, but I'm forced to=20 agree: something spooky is going on in the chroot and the kernel=20 is a big variable. The attached patch was written before I was aware of above=20 weirdness and only works around the issue. Kind regards, T G-R --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-build-image-Account-for-fixed-size-file-system-struc.patch Content-Transfer-Encoding: quoted-printable From=2018f288d4b69faa73ffb75488dbc924640441d7ee Mon Sep 17 00:00:00 2001 From: Tobias Geerinckx-Rice Date: Tue, 11 Jan 2022 19:56:53 +0100 Subject: [PATCH] build: image: Account for fixed-size file system structure= s. * gnu/build/image.scm (estimate-partition-size): Enforce a 1-MiB minimum. =2D-- gnu/build/image.scm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/gnu/build/image.scm b/gnu/build/image.scm index bdd5ec25a9..81caa424f8 100644 =2D-- a/gnu/build/image.scm +++ b/gnu/build/image.scm @@ -3,7 +3,7 @@ ;;; Copyright =C2=A9 2016 Christine Lemmer-Webber ;;; Copyright =C2=A9 2016, 2017 Leo Famulari ;;; Copyright =C2=A9 2017 Marius Bakke =2D;;; Copyright =C2=A9 2020 Tobias Geerinckx-Rice +;;; Copyright =C2=A9 2020, 2022 Tobias Geerinckx-Rice ;;; Copyright =C2=A9 2020 Mathieu Othacehe ;;; ;;; This file is part of GNU Guix. @@ -62,8 +62,10 @@ (define (size-in-kib size) =20 (define (estimate-partition-size root) "Given the ROOT directory, evaluate and return its size. As this doesn't =2Dtake the partition metadata size into account, take a 25% margin." =2D (* 1.25 (file-size root))) +take the partition metadata size into account, take a 25% margin. As this= in +turn doesn't take any constant overhead into account, force a 1-MiB minimu= m." + (max (ash 1 20) + (* 1.25 (file-size root)))) =20 (define* (make-ext-image partition target root #:key =2D-=20 2.34.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYd3dSg0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15ZlsA+wXVpEYWsFN1dr6+JG7ORtm3P8snCJRGFG9woL+w nDeQAQDTyXIUvFylXSHtRC4soI6fyh7A4ImBKKMfvzrOzTsmAw== =A7Ap -----END PGP SIGNATURE----- --==-=-=--