From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4J08J2pA32ErgAAAgWs5BA (envelope-from ) for ; Wed, 12 Jan 2022 21:56:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id wJSBJGpA32FKhgAA9RJhRA (envelope-from ) for ; Wed, 12 Jan 2022 21:56:10 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CEC192683A for ; Wed, 12 Jan 2022 21:56:09 +0100 (CET) Received: from localhost ([::1]:40358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7kf9-0007mh-OS for larch@yhetil.org; Wed, 12 Jan 2022 15:56:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7ke7-0007mV-Bg for bug-guix@gnu.org; Wed, 12 Jan 2022 15:55:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38120) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7ke5-0006ib-OJ for bug-guix@gnu.org; Wed, 12 Jan 2022 15:55:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7ke5-0006JD-MS for bug-guix@gnu.org; Wed, 12 Jan 2022 15:55:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#52919: Hidden "disk-image-rw" files aren't deleted after use, filling $tmpdir Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 12 Jan 2022 20:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52919 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mathieu Othacehe Received: via spool by 52919-submit@debbugs.gnu.org id=B52919.164202087824215 (code B ref 52919); Wed, 12 Jan 2022 20:55:01 +0000 Received: (at 52919) by debbugs.gnu.org; 12 Jan 2022 20:54:38 +0000 Received: from localhost ([127.0.0.1]:59256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7kdi-0006IU-9S for submit@debbugs.gnu.org; Wed, 12 Jan 2022 15:54:38 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:37030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7kdg-0006IE-QT for 52919@debbugs.gnu.org; Wed, 12 Jan 2022 15:54:37 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id C9C0A78B; Wed, 12 Jan 2022 21:54:30 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o8PhPHoUl9OP; Wed, 12 Jan 2022 21:54:30 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id B2BDE353; Wed, 12 Jan 2022 21:54:29 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87pmp850ll.fsf@gnu.org> <8735m3nccu.fsf@inria.fr> <87v8yqv4dh.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 23 =?UTF-8?Q?Niv=C3=B4se?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 12 Jan 2022 21:54:29 +0100 In-Reply-To: <87v8yqv4dh.fsf@gnu.org> (Mathieu Othacehe's message of "Tue, 11 Jan 2022 13:33:30 +0100") Message-ID: <874k68r7y2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: C9C0A78B X-Spamd-Result: default: False [0.90 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; SUBJECT_HAS_CURRENCY(1.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 52919@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642020970; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=xXZe8jEXVwwlZzkBqvy1vvLSKz9oBUK0xceppeT2k7I=; b=Ia8c1L/0QRwy/hkkUuZjUertShFKN9D6S0ggFpPWrOYLiv4zyAVjwZRkAVFK41HZgsaNUc EAopmH5FVohAiGXUMHyi4E60T5efdgo28OHQaNNj3zY6afHEBIGEzVJ+oKmpGlIMxuxEgI sKWWnR/YZhPzJjz1KAIzjiXMxKTrVAu4P4hSR2SRoYZFWmRt7JVZKjOD1EouIe79goJrLJ Oue1glMQLpIQc9o30X8fFrWNM3nnKVITOcRccz9SJaD63vSqkkrQ+aLEuDqumwF9i8l3E1 D6gHkUCN9l65cPvaA7pw1KZWVvVw1dGcmZ4SWNnDci3/TadJgqDviW1vapwDbA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642020970; a=rsa-sha256; cv=none; b=nMoTN8PjGE2M6beWKPV6jzx/IWnrHu7/naqt8V0H1o/4r9EyNe5BUBzDobAC4h+qlQhUIB NBwkRY0dnSNbK7e0ZO4e/aHYG9ReFeUcgNgv5mn6WLUrqEc85ec7KbZQz4vt20hXcb6yjQ NahH6N1YKD2FT+EV1eQkZet6ro87WBcWkI5y2+Iv60AtMMYqatORxLLhDqv4J7h8DgluSG BiTHj2bCc+Fte8yBJ8B2RXSqVTODcta8rl8ldYH9xl/Xf+QA0INKkEgOhfu8VqljAgAQgz jbEioH0k2kDd18sQLFJ/bwl6YiL1NQXm+cWmY3ypxuAOt/7fEtLfdQ2oJFiylw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CEC192683A X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: Vs9w/d8GVAyN Hi, Mathieu Othacehe skribis: > Here is a patch to store the rw images in the cache directory. Regarding > the volatile flag, things are a little more complex than what I thought > initially. > > The "guix system" help menu states that: > > --volatile for 'image', make the root file system volatile > > because for an image, it often makes sense to have the root file system > persistent. For the 'vm' command however, it's probably the other way > around as we would prefer not to copy the huge image files if possible. > > I feel like creating a '--volatile-image' and a '--persistent-vm' option > is going to make things too much complex. > > WDYT? Hmm. Can we keep =E2=80=9Cimage=E2=80=9D persistent by default, and make = =E2=80=98vm=E2=80=99 volatile by default? That way, =E2=80=98--volatile=E2=80=99 would only make sense f= or =E2=80=98image=E2=80=99, and =E2=80=98--persistent=E2=80=99 would only make sense for =E2=80=98vm=E2= =80=99. (So we=E2=80=99d be adding just one option: =E2=80=98--persistent=E2=80=99.) WDYT? > From e4efaf2ffc6d7c699f9d1c41744cfff89be65c12 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Tue, 11 Jan 2022 13:27:35 +0100 > Subject: [PATCH 1/1] system: vm: Do not store rw image in the /tmp direct= ory. > > * gnu/system/vm.scm (system-qemu-image/shared-store-script): Store them i= n the > cache directory instead. Leo had a point on the size of those files, and the fact that if they=E2=80= =99re in ~/.cache they=E2=80=99re not going to be removed automatically, which co= uld lead to user disks filling up. So after all, it might be best to keep those images in ${TMPDIR:-/tmp}. I would still ensure they have a name like =E2=80=9Cguix-image-$USER-XXX=E2= =80=9D, where XXX is the store file basename. Thoughts? Apologies for the hesitations! Ludo=E2=80=99.