From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 40998-done@debbugs.gnu.org
Subject: bug#40998: [PATCH 1/4] system: Add a version field to the <boot-parameters> record.
Date: Tue, 01 Mar 2022 13:32:09 -0500 [thread overview]
Message-ID: <874k4hle1i.fsf@gmail.com> (raw)
In-Reply-To: <87k0dd3fdt.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 01 Mar 2022 09:40:30 -0500")
Hi Ludovic,
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Hi Ludovic,
>
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi!
>>
>> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>>
>>> This version field exposes the (already present) version information of a boot
>>> parameters file.
>>>
>>> * gnu/system.scm (%boot-parameters-version): New variable.
>>> (<boot-parameters>)[version]: New field.
>>> (read-boot-parameters): Use it.
>>> (operating-system-boot-parameters-file): Likewise.
>>> * tests/boot-parameters.scm (test-read-boot-parameters): Use
>>> %boot-parameters-version as the default version value in the template.
>>
>> [...]
>>
>>> + ;; New versions are not backward-compatible, so only accept past and current
>>> + ;; versions, not future ones.
>>> + (define (version? n)
>>> + (member n (iota (1+ %boot-parameters-version))))
>>> +
>>> (match (read port)
>>> - (('boot-parameters ('version 0)
>>> + (('boot-parameters ('version (? version? version))
>>
>> I still have a preference for an explicit list right here, for clarity,
>> and so that we don’t unwillingly find ourselves treating any past
>> version in the same way in the future.
>
> OK. I prefer that we can bump %boot-parameters-version at one place and
> have the rest of the code base do the right thing instead of having to
> manually remember to adjust bits left and right. I've added a comment
> next to %boot-parameters-version to mention it should be incremented by
> 1 when bumping it.
>
>> I think I wasn’t clear about it (sorry!) but I wonder if we could,
>> instead of bumping the version, use something like:
>>
>> (find (cut string-prefix? "gnu.load=") kernel-arguments)
>>
>> to determine whether we’re dealing with an “old-style” “parameters”
>> file.
>>
>> If that’s not possible, then what this patch is doing SGTM.
>
> That's not possible, because the parameters file doesn't include the
> gnu.load nor gnu.system parameters because of their self-referential
> nature, so we don't have such information to look at.
>
> I'll be looking toward pushing this series today.
I've now pushed it as 6d9d616113cf051d80567b584a5b0a6489ddc065. Thanks
for the review!
Maxim
prev parent reply other threads:[~2022-03-01 18:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <handler.40998.B40998.164608474925197@debbugs.gnu.org>
2022-02-28 22:50 ` bug#40998: [PATCH 1/4] system: Add a version field to the <boot-parameters> record Maxim Cournoyer
2022-02-28 22:50 ` bug#40998: [PATCH 2/4] system: Streamline operating-system-boot-parameters-file a bit Maxim Cournoyer
2022-03-01 9:17 ` Ludovic Courtès
2022-02-28 22:50 ` bug#40998: [PATCH 3/4] initrd: Use non-hyphenated kernel command-line parameter names Maxim Cournoyer
2022-02-28 22:50 ` bug#40998: [PATCH 4/4] initrd: Honor rootfstype and rootflags command-line parameters Maxim Cournoyer
2022-03-01 9:16 ` bug#40998: [PATCH 1/4] system: Add a version field to the <boot-parameters> record Ludovic Courtès
2022-03-01 14:40 ` Maxim Cournoyer
2022-03-01 18:32 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k4hle1i.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=40998-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).