From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GB5FOXg4N2KXKgEAgWs5BA (envelope-from ) for ; Sun, 20 Mar 2022 15:21:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8AQCNng4N2ICAwAAauVa8A (envelope-from ) for ; Sun, 20 Mar 2022 15:21:44 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9B34C1B102 for ; Sun, 20 Mar 2022 15:21:44 +0100 (CET) Received: from localhost ([::1]:39634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVwRD-0003b6-Ds for larch@yhetil.org; Sun, 20 Mar 2022 10:21:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVwPa-0002PX-Ih for bug-guix@gnu.org; Sun, 20 Mar 2022 10:20:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41000) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVwPa-0003bG-9n for bug-guix@gnu.org; Sun, 20 Mar 2022 10:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVwPZ-00013A-Ma for bug-guix@gnu.org; Sun, 20 Mar 2022 10:20:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs Resent-From: Roman Scherer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 20 Mar 2022 14:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50329 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Liliana Marie Prikler Received: via spool by 50329-submit@debbugs.gnu.org id=B50329.16477859443964 (code B ref 50329); Sun, 20 Mar 2022 14:20:01 +0000 Received: (at 50329) by debbugs.gnu.org; 20 Mar 2022 14:19:04 +0000 Received: from localhost ([127.0.0.1]:34897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVwOe-00011s-2c for submit@debbugs.gnu.org; Sun, 20 Mar 2022 10:19:04 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:44792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVwOc-00011P-Ma for 50329@debbugs.gnu.org; Sun, 20 Mar 2022 10:19:03 -0400 Received: by mail-wm1-f51.google.com with SMTP id bg31-20020a05600c3c9f00b00381590dbb33so7128013wmb.3 for <50329@debbugs.gnu.org>; Sun, 20 Mar 2022 07:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burningswell-com.20210112.gappssmtp.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=FUGwMLQWESCeKl4q9xHxgVmxfjk8wZZ4SGYVNloO/Ck=; b=57cyAC8FLC06dHOlY/N/lsyWp6VrRJFyBpuuQn9ZqLFSblUkNZaLdeZ/1YfwnqixSy G9uO6jhBJg2HjmdXG1Ot5o4Gok/zzqHR3kmS6hWFopMuUgllZZO6EpC23rl7cMGCI6vH 2xHWXcMhclBC5cEoaYVPWytpiZmnuxlyjUnh7RlllLaHMVFmUcBtISO82mGPQUqJLGoL Y0/XXMBRS2wbd8BwP8TnuLbKjllc40pmR40ycTi27NNqFtS18TYjF5Gqn8KB4lmMF3aC UVSNF5FSnSXm0WOsbBu3zjLvYnTDhgmccuUjmizL5oGXA1y3dEaHZQta7KZXAk5/CLoq WpJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=FUGwMLQWESCeKl4q9xHxgVmxfjk8wZZ4SGYVNloO/Ck=; b=6TZrzMJIYCxyIJZGA4L2PGQl8SJ2vLYFlnzQ9E10pTS9pc0wgxSUOov0DK77BTn7Ph zNiLefE4tnztOlJbQq+Mlhv6PzJXg74uCKsvOA/KKLAKBZnOdADfwT9Ano0Krja/nJHv om84XRruwZSrCsdhYrSrG5VZhBG3Em10J+vPtYEDuuhzwClYejMJZFQJVtBY9C8Qfke+ oopd3OTouEbCuCiFBtRaXnYuqUsFRH+wbrF5FhitXlf9+z3cNR0yJM6oMwybZX9JVzI0 MuvxgL4qeg28E66ryafVlxCTw8VVlR4+opKi/zC385P/owUG0Byp3cSHYHEc8ry+pPrJ D3RQ== X-Gm-Message-State: AOAM530e351wTcYwyUBy4KbHiUuMNzyyAgn0LjVjlrKO0Ndj/F6dESQL 4xttFaagjIix5+dQ4rTI2QURHwSoJeq8JY2d X-Google-Smtp-Source: ABdhPJzCRQ5FtjrQ/G8cDT70MzkLxwdm2KhfW/UbJg28EyHM2rrOVd7zS+y88pdHycuGwhOaLL189g== X-Received: by 2002:a7b:cd8f:0:b0:38c:6b66:e4bd with SMTP id y15-20020a7bcd8f000000b0038c6b66e4bdmr16014802wmj.12.1647785936492; Sun, 20 Mar 2022 07:18:56 -0700 (PDT) Received: from thinkpad (tmo-116-11.customers.d1-online.com. [80.187.116.11]) by smtp.gmail.com with ESMTPSA id u11-20020a056000038b00b00203e5c9aa09sm14028396wrf.27.2022.03.20.07.18.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 07:18:55 -0700 (PDT) References: <87fsnevtxi.fsf@burningswell.com> <8c532497fcfb965b7c60e93b3bbd8082b3acddf4.camel@telenet.be> <87wngp6l7n.fsf@burningswell.com> <7333ababd7753976b6165d1ce8d538586089015c.camel@telenet.be> <87sfrc7vqw.fsf@burningswell.com> <87o8207tmx.fsf@burningswell.com> User-agent: mu4e 1.6.10; emacs 28.0.50 From: Roman Scherer Date: Sun, 20 Mar 2022 14:58:46 +0100 In-reply-to: Message-ID: <874k3sbtbl.fsf@burningswell.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Goaziou , 50329@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647786104; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=FUGwMLQWESCeKl4q9xHxgVmxfjk8wZZ4SGYVNloO/Ck=; b=L6CPbrafjTba94HsXWD4kx0zXl5ASVJ9AxJM84TxQ7Miq+BjYmojXhf5FVd1QrpkA53hdA fWzbXFDCpbu7v6W1qqI5xtXYE3yWk22uh+uWHNX5h9gT4HwNySo+EjWykvMwYNIvR7cdsI t0FmcdUtNk95fyiSMcfb03Xm5fJt/0hgZJZH24/g2zHnjwjc+dwqRFlHyM5q8pH8n0xVO9 vjdgY9PMsaV0CKmhV8VVMtsMisjuxeUIU5hMO1yKcVsSWoUgOriGavBKIiUsEQn1Olr9Ke +5HfPpS+cX4YHI6KT6jDiAdZa1R6zdbU2wBFWXYzsd21miiwOjdjgkAoe8w1rw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647786104; a=rsa-sha256; cv=none; b=nf8VPRGxmMd02iKtPgBWwC2XuNqmttYJzCmQzU/vDTca2nU5Khyr0o3yIwR2zuDQ6E1BGk tfc9L+TrljsGdym/diwLMSrvFcfNi+8mF4z1D2M59q0TBn+3A7acRC1y1cZW5qQh7PCb+x kgKV/94q9reEHMEJOCMFt8J37LERulKLKZ7V99vVdytP1CEGgGVLfaea4iAb1O/TkuYdIx 4eKLHVkRCpEBSUCFR50Sf0m0jAkABj0lCAFCRKPz8q3Pd1l0iiOrxLZUpTBuJJQxp6NGln pEeGDtz9khdx7Cm13mkYVv8meaFP0TfY2Z33GbR4GokX8HG8tBgOsD6MD+aI5A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=burningswell-com.20210112.gappssmtp.com header.s=20210112 header.b=57cyAC8F; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.13 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=burningswell-com.20210112.gappssmtp.com header.s=20210112 header.b=57cyAC8F; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9B34C1B102 X-Spam-Score: -1.13 X-Migadu-Scanner: scn0.migadu.com X-TUID: qQExIyw4dt+J --=-=-= Content-Type: text/plain Hi Liliana and Maxime, if the icons are really coming from [1], they seem to be licensed under the Creative Commons Attribution 4.0 International Public License. If it is okay to include them, I could work on a patch that only installs the VS Code icons. I think we need to give credit and link to the Creative Commons license. Is it enough to add it to the license field and mention/link the VS Code icons in the description field? Before doing that, I would wait until someone clarified that the icons are really coming from [1] in the upstream issue. In the meantime I think it's best to include my patch that removes all icons from the source. What do you think? Roman [1] https://github.com/microsoft/vscode-icons Liliana Marie Prikler writes: > Hi Roman, > > Am Sonntag, dem 20.03.2022 um 12:21 +0100 schrieb Roman Scherer: >> >> Hi Liliana, >> >> thanks for adding the comment locally. I just checked the source of >> LSP Treemacs and yes, they are all mentioned by name here: >> >> https://github.com/emacs-lsp/lsp-treemacs/blob/master/lsp-treemacs-themes.el#L38 >> >> Is this a problem? Should the build script remove them? >> >> If that's the case, we could remove all those "icon themes" and just >> leave this "Iconless" theme in the file: >> >> https://github.com/emacs-lsp/lsp-treemacs/blob/master/lsp-treemacs-themes.el#L209 >> >> Roman > Sadly, replacing these in a snippet won't be that easy, given we can't > easily sneak emacs into it. On the topic of icons to remove, vscode- > icons might actually be okay and are also required by default. > > What should we do? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFTBAEBCAA9FiEE0iajOdjfRIFd3gygPdpSUn0qwZkFAmI3N84fHHJvbWFuLnNj aGVyZXJAYnVybmluZ3N3ZWxsLmNvbQAKCRA92lJSfSrBmR+bCAC+3W6KshVRWLtz PeWxqbMsySKGN9/1edUjAcnf2l/nofgQL+eJKTf2i81akk5GHOSYSXafB/8e28Jx k/o68AolhjDZ0dxTo3CxU8+nbWI92Uh0EOVLRf3RMmX573wPQ0vUTnqlV/N1SxKt oalBnk/BR27WGcym8s2Wp1+Sj1h4Fo5Enn2vCK1eJUL85cDERy4xjNCx3uuQtA91 vHzedaIgoFVcftI50MyqeZsSJTgl8KlHyZYquoRvmhMeD5U3HhqBLhTHzNhluBdk Bm8/6Oi+d/8A6JCHfRZPglZmP3Js67hDxbR5W3wN0Hb+1nz0dZnFEQ8jXEHeumeS KMQr7a4F =funq -----END PGP SIGNATURE----- --=-=-=--