unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: Simon Streit <simon@netpanic.org>,
	Maxime Devos <maximedevos@telenet.be>,
	53668@debbugs.gnu.org
Subject: bug#53668: Updating substitutes on LAN hosts dies unexpectedly
Date: Thu, 12 May 2022 10:21:37 +0200	[thread overview]
Message-ID: <874k1vma9a.fsf@gnu.org> (raw)
In-Reply-To: <87wnerpn1h.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 11 May 2022 21:17:14 -0400")

Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> Maxime Devos <maximedevos@telenet.be> writes:
>
>> Ludovic Courtès schreef op wo 11-05-2022 om 16:58 [+0200]:
>>> However, this may well be this ‘guix publish’ bug that was recently
>>> fixed, whereby ‘guix publish’ without ‘--cache’ would send bogus HTTP
>>> replies:
>>> 
>>>   https://issues.guix.gnu.org/54723
>>> 
>>> Could you confirm?
>>> 
>>> Ludo’.
>>
>> Even then, the error message says ‘wrong type error ...’, shouldn't it
>> say something like ‘bogus HTTP’ or ‘bogus narinfo’ or such instead?
>
> I agree that a more accurate error message would have been useful.  If
> you have the bandwidth for a patch, I'd be more than happy reviewing it
> :-).

HTTP response parsing happens in (web response) though, not in Guix, so
this is where things should be patch.

Currently that code pretty much expects it’s talking to a well-behaved
HTTP server.  Changing it to gracefully deal with any kind of garbage
might turn out to be quite an effort.

Food for thought!

Ludo’.




  reply	other threads:[~2022-05-12  8:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-31 18:37 bug#53668: Updating substitutes on LAN hosts dies unexpectedly Simon Streit
2022-01-31 20:17 ` Guillaume Le Vaillant
2022-01-31 21:38   ` Simon Streit
2022-01-31 21:55     ` Simon Streit
2022-02-01  2:06 ` Maxim Cournoyer
2022-05-11 14:58   ` Ludovic Courtès
2022-05-11 15:02     ` Maxime Devos
2022-05-12  1:17       ` Maxim Cournoyer
2022-05-12  8:21         ` Ludovic Courtès [this message]
2022-05-12 13:47           ` Maxim Cournoyer
2022-05-11 15:06     ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874k1vma9a.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=53668@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=maximedevos@telenet.be \
    --cc=simon@netpanic.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).