From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MD9UMkAjsGKfBQEAbAwnHQ (envelope-from ) for ; Mon, 20 Jun 2022 09:35:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id iCVIMkAjsGIrNQEA9RJhRA (envelope-from ) for ; Mon, 20 Jun 2022 09:35:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0078D6807 for ; Mon, 20 Jun 2022 09:35:28 +0200 (CEST) Received: from localhost ([::1]:47920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3BwU-0006WT-4q for larch@yhetil.org; Mon, 20 Jun 2022 03:35:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3Bw6-0006UO-Vz for bug-guix@gnu.org; Mon, 20 Jun 2022 03:35:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60087) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3Bw6-0003CR-NQ for bug-guix@gnu.org; Mon, 20 Jun 2022 03:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o3Bw6-0003H4-Kn for bug-guix@gnu.org; Mon, 20 Jun 2022 03:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#51466: bug#53355: guix shell --check: confusing error message Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 20 Jun 2022 07:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51466 X-GNU-PR-Package: guix X-GNU-PR-Keywords: moreinfo To: Chris Marusich Cc: 53355@debbugs.gnu.org, 51466@debbugs.gnu.org Received: via spool by 51466-submit@debbugs.gnu.org id=B51466.165571048312551 (code B ref 51466); Mon, 20 Jun 2022 07:35:02 +0000 Received: (at 51466) by debbugs.gnu.org; 20 Jun 2022 07:34:43 +0000 Received: from localhost ([127.0.0.1]:53982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3Bvn-0003GM-1W for submit@debbugs.gnu.org; Mon, 20 Jun 2022 03:34:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3Bvl-0003G7-PI; Mon, 20 Jun 2022 03:34:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43482) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3Bvg-0003As-Di; Mon, 20 Jun 2022 03:34:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=E9MAD8S9F+JymPrHMEVf9Fzg+lmwzOKAJ/ejwryrBck=; b=WWBDwakikhD0LAhiv3s+ 6TsGyY//iK1//i80grAtYIWf02o0NQchcvR2eXUkxpoVNKnQxODjfpPnYwpHFreb5FeG3Fw06d0Fr ATUtZfHdz5Lawh70eppgTBD3R+4vY9CIcyaxHC63XiQ90MXLbOc/HUlZCx0W3X0fIrKgn5nsAywNU s4En8c7VySO2Gqkn5evDIts7r5lysfO4R6HOcWdPIEg4v5H+T10n0Oizh26cjcpTvOcz+xeGJNzDk d7gxx2Yagvh+8a7ZPjQNtIWqeFoHG++RP+f9HqyuRmpdj78SPtfsjQeI8A7AJ/0p2JApmmJDPzrkG S0bKFCUE8vDr2w==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=55018 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3Bvf-0002pw-8O; Mon, 20 Jun 2022 03:34:36 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87h7a08kub.fsf@gmail.com> <87lez5td4n.fsf@gnu.org> <87sftc4osu.fsf@gmail.com> <87h79slysd.fsf@gnu.org> <87sft13dyv.fsf@gmail.com> <874k59d802.fsf@gnu.org> <87wnhy2w73.fsf_-_@gmail.com> <878rudzsmv.fsf@gnu.org> <87sfozzglf.fsf_-_@gmail.com> <871qvsubgv.fsf@gnu.org> <87k09cpest.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Duodi 2 Messidor an 230 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de l'Avoine X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 20 Jun 2022 09:34:33 +0200 In-Reply-To: <87k09cpest.fsf@gmail.com> (Chris Marusich's message of "Sun, 19 Jun 2022 13:40:50 -0700") Message-ID: <874k0fbxfa.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655710528; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=E9MAD8S9F+JymPrHMEVf9Fzg+lmwzOKAJ/ejwryrBck=; b=C5+bnXWOePr55qMWfZZ0jCS0Xd2miSEvLo66HOPuSbjVsBGneG6fZ2fE0Gr9numfArsx5J R7r1sdCC+avH+dHv5Vc7RCxB7CnQXZrkt/xuKkKqY7Rqt9JciH0PHY66f99Px+p3sfva1m Le4rwbtuiX/yreDReJ+UzRhHIjrhMEliFfkbcb9kDChOC/d7eiuX3XLmF8Gq1vJbIir81X hudBy5hi2/xlHXQdtaNe2/5aJR1MijN5Ff3uo/EIWjS/UdUuZewsEppwM2thTxQpPfRmwq GaVAuxLQLWmV8iTMVyOm8Te/qtlmYuvAy38UhdVi0VqDz7/atsvNGxXrE5aH5g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655710528; a=rsa-sha256; cv=none; b=BIYqzFcrUostGdYekEfGTsrTyTdk6Ov8Hs1jdy3Bv8hYlH2aLJT4rf1ISaw53lg8ANkskW AuAj1sPKHg8JL6cy9vX3yV0rF5YBIJyyJ/8HYaWUgwyW8nXIME0q+j2k/lFX80x6l68w0c bJ/pb351KRlzhTHutUsl7Sa7PgCTq6mLIMlC1wakaCG2KJ0NQjaLthqYI1L8upF3ABncFo FMRK9maG3dXBuNs9VnGo0d+6sexqFVk3XNsuk5t7owYbX8d6+CKAd6Zl9iwKmWmVlxs8Fk szKSJTFggwOviO9vaErpLYcL7iATPbuXoqglhlfxBJG68lHUvIrJLqgKvTzzVQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=WWBDwaki; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.88 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=WWBDwaki; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0078D6807 X-Spam-Score: -3.88 X-Migadu-Scanner: scn1.migadu.com X-TUID: 1U5e8SdSqKTU Hi, Chris Marusich skribis: > Before pushing, I did some more tests to make sure it was still working. > When I did this, I noticed that read-line was no longer returning > strings that end in "\r". This prevents child-shell-environment from > behaving correctly, since it incorrectly assumes that all the lines end > in "\r", stripping it off unconditionally. In the past, I'm sure > read-line was returning strings that end in "\r". I don't know what > changed, but I've attached a second patch that fixes this issue, also. Weird, not sure what could have changed. > Unless you have more feedback, I'll go ahead and push both patches to > master in a few days. Great, thank you! Ludo=E2=80=99.