From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bug-guix-bounces+larch=yhetil.org@gnu.org>
Received: from mp12.migadu.com ([2001:41d0:403:4876::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms8.migadu.com with LMTPS
	id GPHBG97aPGVahAEAauVa8A:P1
	(envelope-from <bug-guix-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sat, 28 Oct 2023 11:56:46 +0200
Received: from aspmx1.migadu.com ([2001:41d0:403:4876::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp12.migadu.com with LMTPS
	id GPHBG97aPGVahAEAauVa8A
	(envelope-from <bug-guix-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sat, 28 Oct 2023 11:56:46 +0200
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 911D75E6CA
	for <larch@yhetil.org>; Sat, 28 Oct 2023 11:56:45 +0200 (CEST)
Authentication-Results: aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=JEs+djhD;
	dmarc=pass (policy=none) header.from=gnu.org;
	spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1698487005;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:resent-cc:
	 resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=ONPdnIjCEqVSCRk4Huch6vEv+r9HryzwIinziiDnlZo=;
	b=uDnenA9PVX2vLFtyEXbCCOKIBhfejO25OpYZgvJoASeqFLiuj6UFih7FomC5soNfuJLU1F
	nnNvJMxnLMClkGO8+hhEULy+4UT1WhIKxoYYK/XXfDB83QUWkOnTPasbgJzEHvs5XVIR2D
	UhzK9IXFQ8zLuO5D1d0QtA4j22ykM60lAQSSGEluCy3s1ShxHXtMhyhzfibzOpxQlEXat3
	sUrFbddnJJlA/Dn3O/xPCiPchloMkr7ZJWzJzSY6xBQh3ZNUtkACPdBj87XgExwU5feHqg
	/8wv6sk8ns0Icip00oO3K+OKGt7L0fSz9MC4IeOWstbwRt/gll/pqjDrLIcUpg==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=JEs+djhD;
	dmarc=pass (policy=none) header.from=gnu.org;
	spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698487005; a=rsa-sha256; cv=none;
	b=W9RVNTzaUpQlDtX5cvffPfABn77GVfL1oq1vmFNkFhK6MxElz8glj1Bcl6Zvm4TMHJ9sc3
	pZBoKjoa8n6GNbcN/uuNKibMnoGFr6bwd4BK+9JzJK7DMWnwarv/kJ5V04XU00xfeP4k1b
	m266gRR2DC0lqH1lyX0epW79XWgrxSGN8SC4C6l3A6qxPE37neqn1uYhwGhYWs+pEwnFP0
	NzwJdChYeTsxJP2kFCiAWaB+Y9erH7TP8iQRvMupkS7A+vlDezy/BwtKHw1YriaHilxreJ
	k9ewQNF3mNCUDYxzzJBvj4fPh5WollK+bTDEclwx6r1J0LLrl0hNo09Pqft21g==
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-guix-bounces@gnu.org>)
	id 1qwg3U-0008Co-VO; Sat, 28 Oct 2023 05:56:32 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1qwg3T-0008CR-1R
 for bug-guix@gnu.org; Sat, 28 Oct 2023 05:56:31 -0400
Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1qwg3S-0005gD-18
 for bug-guix@gnu.org; Sat, 28 Oct 2023 05:56:30 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1qwg3x-0003E6-L1
 for bug-guix@gnu.org; Sat, 28 Oct 2023 05:57:01 -0400
X-Loop: help-debbugs@gnu.org
Subject: bug#66692: [cuirass] Spurious failed builds following patching u-boot
 sources
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-guix@gnu.org
Resent-Date: Sat, 28 Oct 2023 09:57:01 +0000
Resent-Message-ID: <handler.66692.B66692.169848698012346@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 66692
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: 
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 66692@debbugs.gnu.org
Received: via spool by 66692-submit@debbugs.gnu.org id=B66692.169848698012346
 (code B ref 66692); Sat, 28 Oct 2023 09:57:01 +0000
Received: (at 66692) by debbugs.gnu.org; 28 Oct 2023 09:56:20 +0000
Received: from localhost ([127.0.0.1]:37785 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1qwg3H-0003D4-W0
 for submit@debbugs.gnu.org; Sat, 28 Oct 2023 05:56:20 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:45206)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@gnu.org>) id 1qwg3G-0003Cp-I9
 for 66692@debbugs.gnu.org; Sat, 28 Oct 2023 05:56:19 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1qwg2f-0005YF-AH; Sat, 28 Oct 2023 05:55:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=ONPdnIjCEqVSCRk4Huch6vEv+r9HryzwIinziiDnlZo=; b=JEs+djhDMrWsdTLZ2NBt
 okiCcTfbsW0hMMtzz5FblQuTAm+0eioW2YMbvIt5bgwBXPiUnc87JQ9Eh2MC/8wZE5Q+i2tA/Mj1s
 PL83c3aIZBDRcoVHm/DxsxTqZ29WaX72sBZKlFZSmWGtaA2eMR5tXl8WH4ncTzkKTqIjFjFjJyg10
 xRQWk5E/4VRmXV2gkyQURseExVDlj0NYAt37Q6TWe0uPyKFltnaTVikF0/6h9sxnGyDltOJV/6lG0
 29myKxbjf75YNKPWspN7kV7CrvjT962tzCHSeX4QFqWETmLuPVRP2XI/3J+FhR5ojV7DakIpabC8R
 haUEkLtf7eJBpw==;
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
In-Reply-To: <87pm15dpxn.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s
 message of "Mon, 23 Oct 2023 22:49:56 +0200")
References: <87ttqi82rh.fsf@gmail.com> <87pm15dpxn.fsf@gnu.org>
Date: Sat, 28 Oct 2023 11:55:38 +0200
Message-ID: <874jib9ilh.fsf@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-guix@gnu.org
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org
Sender: bug-guix-bounces+larch=yhetil.org@gnu.org
X-Migadu-Flow: FLOW_IN
X-Migadu-Country: US
X-Migadu-Spam-Score: -6.75
X-Spam-Score: -6.75
X-Migadu-Queue-Id: 911D75E6CA
X-Migadu-Scanner: mx10.migadu.com
X-TUID: BN/dchuHIdIz

Hi,

Ludovic Court=C3=A8s <ludo@gnu.org> skribis:

>   2. All the ongoing and about-to-be-started builds carried out by
>      worker processes at that point were marked as failed.

This part of the problem was a bit more subtle.q

When =E2=80=98cuirass remote-server=E2=80=99 goes away, =E2=80=98cuirass re=
mote-worker=E2=80=99 keeps
going if it was building something.  In that case the build log will be
lost (because the direct connection to the server was cut), but the
worker eventually notifies the server of build success/failure (ZeroMQ,
makes sure those messages are eventually sent, when the server is back).

The bug was that the worker could in some cases, when the server is
down, send a =E2=80=9Cbuild failed=E2=80=9D message even though the bug had=
 not
completed.

This is fixed by these Cuirass commits:

  2eb3e13 * remote-worker: Discard log anytime =E2=80=98send-log=E2=80=99 t=
hrows.
  4cc37f5 * remote-worker: Ignore the return value of =E2=80=98build-deriva=
tions&=E2=80=99.
  3bbb5c8 * store: =E2=80=98build-derivations&=E2=80=99 enforces synchroniz=
ation with the build.

(I have yet to update the =E2=80=98cuirass=E2=80=99 package and to deploy i=
t on ci.guix.
It=E2=80=99s been running for a few days at <https://guix.bordeaux.inria.fr=
>.)

Ludo=E2=80=99.