From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bug-guix-bounces+larch=yhetil.org@gnu.org>
Received: from mp10.migadu.com ([2001:41d0:303:e16b::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms8.migadu.com with LMTPS
	id yHSPEMLjXWWmTgEAG6o9tA:P1
	(envelope-from <bug-guix-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Wed, 22 Nov 2023 12:19:30 +0100
Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp10.migadu.com with LMTPS
	id yHSPEMLjXWWmTgEAG6o9tA
	(envelope-from <bug-guix-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Wed, 22 Nov 2023 12:19:30 +0100
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id EA4F05FFE6
	for <larch@yhetil.org>; Wed, 22 Nov 2023 12:19:29 +0100 (CET)
Authentication-Results: aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=gF9gJtmS;
	spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org";
	dmarc=pass (policy=none) header.from=gnu.org
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1700651970;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:resent-cc:
	 resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=MWXC4TYqLrnQXs1ngFX4mcOjA6MZowvoq66b2g7zDa4=;
	b=P2ICASKLzQSZCDiEEFUgSqWy8Ih95msy4wlVa8g+4YczJAWy2X2n/p4LS2YnKnrQxCGMlK
	jAZsBzHoN2J8TZc0cGtwqX3H66Mj0t1EDU5cE0fbKFJN0qOcrWYBnrppe+m0Aq00KUtrnj
	WlnObPVPkd7RVmNCPUBgB+rqMxSsueM/6HQh6OVkpVraCBGiO+9KL+gO1Dc+sRcwVYnbxb
	iyeTDRa9eZlRSG6inMhLOOTtykP8t/kfuZ5MdY45rlqy9TmJtGb1knjuBxWOvHrVROWmXh
	w40fs7ehH+/6/NQFcejFhgY4YiaKWeZUAZatsf6EBIAAAR5WD6HzAvsS17Ifyg==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=gF9gJtmS;
	spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org";
	dmarc=pass (policy=none) header.from=gnu.org
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1700651970; a=rsa-sha256; cv=none;
	b=VqJi2oLcZ1B5GIKHLNpYNlNbiUpCfwXDn1zY/WBtVjbM0REOsJA6ydmcZpF6rpoL4Sbq26
	zSun9hhRGb2Nss8kUuHlvsC+eyEh7GE3UdA6Q8nzKj+Kze1lTKeNs8zWyPQKAOFbixBjwl
	qrxf6jzCQcgkQYbMLjPU2UuIsZIXI2CP41QmPVvEH4rjUkU+zcKmZq2kqyQ7obfNApdTU2
	+3rHnZcyycknUz8QEZRW5U7ZFcJBdtVG1Ek0xkV9OALt+GfmmpAQgf5qpWcvy1agoxAWAz
	XC2FBge8eHw8CrNNHrb0RF+FQ8nmlOcDj8Z7K+OcJEAX0yE5+/rS2eEh7hD+Qg==
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-guix-bounces@gnu.org>)
	id 1r5lG1-0008LV-BJ; Wed, 22 Nov 2023 06:19:01 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1r5lFz-0008L1-QV
 for bug-guix@gnu.org; Wed, 22 Nov 2023 06:19:00 -0500
Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1r5lFz-0003DT-IN
 for bug-guix@gnu.org; Wed, 22 Nov 2023 06:18:59 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r5lG2-0001vL-33
 for bug-guix@gnu.org; Wed, 22 Nov 2023 06:19:02 -0500
X-Loop: help-debbugs@gnu.org
Subject: bug#65720: [bug#66650] bug#65720: [bug#66650] [PATCH] git: Shell out
 to =?UTF-8?Q?=E2=80=98git_?= =?UTF-8?Q?gc=E2=80=99?= when necessary.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-guix@gnu.org
Resent-Date: Wed, 22 Nov 2023 11:19:02 +0000
Resent-Message-ID: <handler.65720.B65720.17006518917331@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 65720
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: 
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: Josselin Poiret <dev@jpoiret.xyz>, Christopher Baines <mail@cbaines.net>,
 65720@debbugs.gnu.org, 66650@debbugs.gnu.org
Received: via spool by 65720-submit@debbugs.gnu.org id=B65720.17006518917331
 (code B ref 65720); Wed, 22 Nov 2023 11:19:02 +0000
Received: (at 65720) by debbugs.gnu.org; 22 Nov 2023 11:18:11 +0000
Received: from localhost ([127.0.0.1]:58126 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1r5lFC-0001u6-HM
 for submit@debbugs.gnu.org; Wed, 22 Nov 2023 06:18:10 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:34650)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@gnu.org>)
 id 1r5lFA-0001tn-1U; Wed, 22 Nov 2023 06:18:08 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1r5lF1-000317-3G; Wed, 22 Nov 2023 06:17:59 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=MWXC4TYqLrnQXs1ngFX4mcOjA6MZowvoq66b2g7zDa4=; b=gF9gJtmSMNyKdkRRimV/
 dTSlbTvLr6f0VYtMS92CkyrCM7diHPtITK475CkSmNnAmirZ9LGIeYYdDyXEQAcbGNLu+BS4JV6m6
 WcBDswGI0iJ4BOjKd+UE22FPLLR0pe/H5UQW46kdiyyZE5n69FEUDn8RL7mNTlNUXh634I4icFBVM
 QCOJYklIXJt283yHPrjdkABtUzjE5JYXgPpd7bbYm//3ihyVxaRqVekexHIQ9X3hy7SNU9ANuhehh
 sSicMTKJigaLvwV3++y7oCsHPEoGpRfOaNDncctftsdVigWlbSzknQkL4332zOieKctvlX9ZRa0Ha
 QQU+NzvHAmMzUQ==;
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
In-Reply-To: <CAJ3okZ2-W_Me-Gao44+LeKGCm7dhb8VkLfC2doL4NE9VO88HYg@mail.gmail.com>
 (Simon Tournier's message of "Thu, 16 Nov 2023 14:24:51 +0100")
References: <87jzswsrlt.fsf@gnu.org>
 <f588bb38b4b9fdaff29dd8af8c62aa3c55902f7c.1697818202.git.ludo@gnu.org>
 <87sf5swc3j.fsf@cbaines.net> <87o7fwae0q.fsf@gnu.org>
 <87v8a4el3a.fsf@gmail.com> <87h6ll28yh.fsf@gnu.org>
 <CAJ3okZ2-W_Me-Gao44+LeKGCm7dhb8VkLfC2doL4NE9VO88HYg@mail.gmail.com>
Date: Wed, 22 Nov 2023 12:17:55 +0100
Message-ID: <874jhem3z0.fsf@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-guix@gnu.org
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org
Sender: bug-guix-bounces+larch=yhetil.org@gnu.org
X-Migadu-Flow: FLOW_IN
X-Migadu-Country: US
X-Migadu-Spam-Score: -3.90
X-Spam-Score: -3.90
X-Migadu-Queue-Id: EA4F05FFE6
X-Migadu-Scanner: mx13.migadu.com
X-TUID: 5+/U9DXvdqqJ

Hi,

Simon Tournier <zimon.toutoune@gmail.com> skribis:

> On Thu, 16 Nov 2023 at 13:12, Ludovic Court=C3=A8s <ludo@gnu.org> wrote:
>
>> > Well, I expect =E2=80=9Cguix gc=E2=80=9D to take some time and I choos=
e when.  However,
>> > I want =E2=80=9Cguix pull=E2=80=9D or =E2=80=9Cguix time-machine=E2=80=
=9D to be as fast as possible and
>> > here some extra time is added, and I cannot control exactly when.
>>
>> Yes, I see.  The thing is =E2=80=98maybe-run-git-gc=E2=80=99 is only cal=
led on the slow
>> path; so for example, it=E2=80=99s not called on a =E2=80=98time-machine=
=E2=80=99 cache hit, but
>> only on a cache miss, which is already expensive anyway.
>
> What you mean as "only called on the slow path" is each time
> 'update-cached-checkout' is called, right?

Yes, which usually indicates we=E2=80=99re on a cache miss (for example a c=
ache
miss of =E2=80=98guix time-machine=E2=80=99) and thus are going to do poten=
tially more
work (updating a Git repo, building things, etc.).  That=E2=80=99s why I th=
ink
it=E2=80=99s on the =E2=80=9Cslow path=E2=80=9D and shouldn=E2=80=99t make =
much of a difference.  More
importantly, unless I=E2=80=99m mistaken, it=E2=80=99s rarely going to fire.

> So, somehow when 'maybe-run-git-gc' is called appears to me
> "unpredictable".  But anyway. :-)

Sure, but the way I see it, that=E2=80=99s the nature of caches.

> Let move it elsewhere if I am really annoyed.

:-/

Ludo=E2=80=99.