From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#20081: patch-source-shebangs crashes on broken symlink
Date: Mon, 06 Apr 2015 23:22:41 +0200
Message-ID: <87384d6jfi.fsf@gnu.org>
References: <20150311150211.GK16813@crashnator.suse.cz>
	<20150311173230.GA12508@debian.math.u-bordeaux1.fr>
	<20150311191235.GA29520@venom> <87oanyv9yo.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45034)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1YfEU3-0006gX-VQ
	for bug-guix@gnu.org; Mon, 06 Apr 2015 17:23:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1YfEU2-0001FV-T5
	for bug-guix@gnu.org; Mon, 06 Apr 2015 17:23:03 -0400
Received: from debbugs.gnu.org ([140.186.70.43]:56829)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1YfEU2-0001FM-QN
	for bug-guix@gnu.org; Mon, 06 Apr 2015 17:23:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1YfEU2-0001FY-Lr
	for bug-guix@gnu.org; Mon, 06 Apr 2015 17:23:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-guix@gnu.org
Resent-Message-ID: <handler.20081.D20081.14283553674772.done@debbugs.gnu.org>
In-Reply-To: <87oanyv9yo.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Thu, 12 Mar 2015 10:30:55 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= <sleep_walker@suse.cz>
Cc: 20081-done@debbugs.gnu.org

ludo@gnu.org (Ludovic Court=C3=A8s) skribis:

> Tom=C3=A1=C5=A1 =C4=8Cech <sleep_walker@suse.cz> skribis:
>
>> On Wed, Mar 11, 2015 at 06:32:30PM +0100, Andreas Enge wrote:
>>>On Wed, Mar 11, 2015 at 04:02:11PM +0100, Tom=C3=A1=C5=A1 =C4=8Cech wrot=
e:
>>>> I'm trying to create package for taskwarrior.
>>>> Source tarball contain symlinks to nonexisting file `task':
>>>
>>>I would argue that this is not a bug in guix, but in the tarball.
>>>You can remove the link with an additional phase before 'configure, see,=
 for
>>>instance, the dvdisaster package in cdrom.scm.
>>
>> I agree with you that the fishy part is in tarball, but we could make
>> build more robust. Getting backtrace is not nice way to end a build.
>
> I agree.  I think we should patch =E2=80=98find-files=E2=80=99 in core-up=
dates to not
> follow symlinks:

Done in 347f54e.

Thanks,
Ludo=E2=80=99.