From: ludo@gnu.org (Ludovic Courtès)
To: "Tomáš Čech" <sleep_walker@suse.cz>
Cc: 20081-done@debbugs.gnu.org
Subject: bug#20081: patch-source-shebangs crashes on broken symlink
Date: Mon, 06 Apr 2015 23:22:41 +0200 [thread overview]
Message-ID: <87384d6jfi.fsf@gnu.org> (raw)
In-Reply-To: <87oanyv9yo.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 12 Mar 2015 10:30:55 +0100")
ludo@gnu.org (Ludovic Courtès) skribis:
> Tomáš Čech <sleep_walker@suse.cz> skribis:
>
>> On Wed, Mar 11, 2015 at 06:32:30PM +0100, Andreas Enge wrote:
>>>On Wed, Mar 11, 2015 at 04:02:11PM +0100, Tomáš Čech wrote:
>>>> I'm trying to create package for taskwarrior.
>>>> Source tarball contain symlinks to nonexisting file `task':
>>>
>>>I would argue that this is not a bug in guix, but in the tarball.
>>>You can remove the link with an additional phase before 'configure, see, for
>>>instance, the dvdisaster package in cdrom.scm.
>>
>> I agree with you that the fishy part is in tarball, but we could make
>> build more robust. Getting backtrace is not nice way to end a build.
>
> I agree. I think we should patch ‘find-files’ in core-updates to not
> follow symlinks:
Done in 347f54e.
Thanks,
Ludo’.
next prev parent reply other threads:[~2015-04-06 21:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 15:02 bug#20081: patch-source-shebangs crashes on broken symlink Tomáš Čech
2015-03-11 17:32 ` Andreas Enge
2015-03-11 19:13 ` Tomáš Čech
2015-03-12 9:30 ` Ludovic Courtès
2015-03-12 9:36 ` Tomáš Čech
2015-04-06 21:22 ` Ludovic Courtès [this message]
2015-03-11 20:18 ` Mark H Weaver
2015-04-22 19:06 ` bug#20081: issue is still not fixed Tomáš Čech
2015-04-23 18:58 ` bug#20081: Dangling symlinks gracelessly handled by ‘patch-shebangs’ & co Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87384d6jfi.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=20081-done@debbugs.gnu.org \
--cc=sleep_walker@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).