From: Marius Bakke <mbakke@fastmail.com>
To: Mathieu Othacehe <m.othacehe@gmail.com>, 26441@debbugs.gnu.org
Subject: bug#26441: [PATCH] gnu: findutils: Fix make check issues on multi-core machines.
Date: Thu, 13 Apr 2017 21:38:46 +0200 [thread overview]
Message-ID: <8737dc9jy1.fsf@fastmail.com> (raw)
In-Reply-To: <20170413163408.17571-1-m.othacehe@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2341 bytes --]
Hi, thanks for working on these!
[...]
> (define-public findutils
> (package
> - (name "findutils")
> - (version "4.6.0")
> - (source (origin
> - (method url-fetch)
> - (uri (string-append "mirror://gnu/findutils/findutils-"
> - version ".tar.gz"))
> - (sha256
> - (base32
> - "178nn4dl7wbcw499czikirnkniwnx36argdnqgz4ik9i6zvwkm6y"))
> - (patches (search-patches "findutils-localstatedir.patch"
> - "findutils-test-xargs.patch"))))
> - (build-system gnu-build-system)
> - (arguments
> - `(#:configure-flags (list
> - ;; Tell 'updatedb' to write to /var.
> - "--localstatedir=/var"
> -
> - ;; Work around cross-compilation failure. See
> - ;; <http://savannah.gnu.org/bugs/?27299#comment1>.
> - ,@(if (%current-target-system)
> - '("gl_cv_func_wcwidth_works=yes")
> - '()))))
> - (synopsis "Operating on files matching given criteria")
> - (description
> - "Findutils supplies the basic file directory searching utilities of the
> + (name "findutils")
> + (version "4.6.0")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "mirror://gnu/findutils/findutils-"
> + version ".tar.gz"))
> + (sha256
> + (base32
> + "178nn4dl7wbcw499czikirnkniwnx36argdnqgz4ik9i6zvwkm6y"))
> + (patches (search-patches
> + "findutils-localstatedir.patch"
> + "findutils-test-xargs.patch"
> + ;; test-lock has performance issues on multi-core
> + ;; machines, it hangs or takes a long time to complete.
> + ;; This is a commit from gnulib to fix this issue.
> + "findutils-gnulib-multi-core.patch"))))
Please don't mix large indentation changes with functional changes. It
is really difficult to tell what this commit does. Can you split the
indentation change out in a separate commit?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-04-13 19:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 8:16 bug#26441: Gnulib’s ‘test-lock’ fails to complete on machines with >= 32 cores Ludovic Courtès
2017-04-12 9:01 ` Mathieu Othacehe
2017-04-12 12:00 ` Ludovic Courtès
[not found] ` <87wpapdedp.fsf@gnu.org>
2017-04-12 14:37 ` Bruno Haible
[not found] ` <2008088.TpEHzIiNi8@omega>
2017-04-12 16:11 ` Ludovic Courtès
[not found] ` <87h91td2s5.fsf@gnu.org>
2017-04-13 6:39 ` Mathieu Othacehe
2017-04-13 12:23 ` Ludovic Courtès
2017-04-13 16:31 ` Mathieu Othacehe
2017-04-22 23:29 ` Ludovic Courtès
2017-04-12 11:53 ` Ludovic Courtès
2017-04-13 16:34 ` bug#26441: [PATCH] gnu: findutils: Fix make check issues on multi-core machines Mathieu Othacehe
2017-04-13 19:38 ` Marius Bakke [this message]
2017-04-13 20:04 ` Mathieu Othacehe
2017-04-13 20:06 ` bug#26441: [PATCH 1/2] " Mathieu Othacehe
2017-04-13 20:06 ` bug#26441: [PATCH 2/2] gnu: findutils: Reindent package definition Mathieu Othacehe
2017-04-15 18:11 ` bug#26441: [PATCH 1/2] gnu: findutils: Fix make check issues on multi-core machines Marius Bakke
2017-04-17 10:18 ` Mathieu Othacehe
2017-04-17 19:47 ` Marius Bakke
2017-04-17 10:18 ` bug#26441: [PATCH 1/3] build: Add two missing patches to local.mk Mathieu Othacehe
2017-04-17 10:18 ` bug#26441: [PATCH 2/3] gnu: findutils: Fix make check issues on multi-core machines Mathieu Othacehe
2017-04-17 10:18 ` bug#26441: [PATCH 3/3] gnu: libunistring: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737dc9jy1.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=26441@debbugs.gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).