unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Taylan Kammer <taylanbayirli@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 31889-done@debbugs.gnu.org
Subject: bug#31889: Filesystems must not depend on device mappings?
Date: Fri, 22 Jun 2018 20:21:07 +0200	[thread overview]
Message-ID: <8736xevg18.fsf@gmail.com> (raw)
In-Reply-To: <87h8lv6bzk.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 21 Jun 2018 23:55:27 +0200")

ludo@gnu.org (Ludovic Courtès) writes:

> Hi,
>
> Taylan Kammer <taylanbayirli@gmail.com> skribis:
>
>>      (mapped-devices
>>       (list (mapped-device
>>              (source (uuid "b3d059f8-1c4f-4569-88dd-5485825b4373"))
>>              (target "guixsd")
>>              (type luks-device-mapping))
>>             (mapped-device
>>              (source (uuid "550d9258-bbbb-488c-af27-6b1fefa190ee"))
>>              (target "home")
>>              (type luks-device-mapping))))
>>      
>>      (file-systems
>>       (append
>>        (list (file-system
>>               (device "/dev/mapper/guixsd")
>>               (mount-point "/")
>>               (type "ext4")
>>               (dependencies mapped-devices))
>>              (file-system
>>               (device "/dev/mapper/home")
>>               (mount-point "/home")
>>               (type "ext4")
>>               (dependencies mapped-devices)))
>>        %base-file-systems))
>
> [...]
>
>> It results in the error message:
>>
>>     guix system: error: service 'file-system-/home' requires
>>     'device-mapping-home', which is not provided by any service
>
> [...]
>
>> It works when both '(dependencies mapped-devices)' clauses are simply
>> removed.
>
> Yes, it’s “expected”: using “/dev/mapper/xyz” as the device is enough to
> express the dependency.
>
> When passing (dependencies mapped-devices), the effect was to each file
> system depend on *both* mapped devices.  This leads to an inconsistency
> because /dev/mapper/guixsd is “needed-for-boot” (i.e., set up from the
> initrd), whereas /dev/mapper/home is not (i.e., set up as a Shepherd
> service.)
>
> The solution is to either use the /dev/mapper/xyz names in the ‘device’
> field, or to specify only the relevant mapped device in ‘dependencies’.
>
> Anyway, commit 68a58775e071d4b0e000b93ad121b6e64d161b79 fixes it by
> doing exactly what this config asks for: setting up all the mapped
> devices in the initrd.
>
> Thanks,
> Ludo’.

Thank you for the explanation and the fix! :-)

Taylan

      reply	other threads:[~2018-06-22 16:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 21:11 bug#31889: Filesystems must not depend on device mappings? Taylan Ulrich Bayırlı/Kammer
2018-06-20 21:17 ` Ludovic Courtès
2018-06-21 18:44   ` Taylan Kammer
2018-06-21 21:55     ` Ludovic Courtès
2018-06-22 18:21       ` Taylan Kammer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736xevg18.fsf@gmail.com \
    --to=taylanbayirli@gmail.com \
    --cc=31889-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).