From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#32524: guix system build bare-bones.scm fails with ahci shpchp Date: Wed, 29 Aug 2018 23:13:37 +0200 Message-ID: <8736uw7u66.fsf@gnu.org> References: <87a7pb3zqi.fsf@fastmail.com> <871sam6zyt.fsf@ngyro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fv7mt-0008OI-3F for bug-guix@gnu.org; Wed, 29 Aug 2018 17:14:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fv7ms-00019N-9V for bug-guix@gnu.org; Wed, 29 Aug 2018 17:14:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:60749) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fv7ms-00019H-5y for bug-guix@gnu.org; Wed, 29 Aug 2018 17:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fv7mr-0005PI-U5 for bug-guix@gnu.org; Wed, 29 Aug 2018 17:14:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <871sam6zyt.fsf@ngyro.com> (Timothy Sample's message of "Sat, 25 Aug 2018 14:52:26 -0400") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Timothy Sample Cc: Eric Brown , 32524@debbugs.gnu.org Hi, Timothy Sample skribis: > Eric Brown writes: > >> I am attempting to guix system reconfigure a GuixSD 0.15 (updated) >> Macintosh laptop where reconfigure recommends and requires: >> >> (initrd-modules (append (list "ahci" "shpchp") >> %base-initrd-modules)) >> >> However, the config file that I used at guix system init works >> originally with this additional bit of lisp, but a reconfigure gives the >> error below. >> >> In an attempt to narrow down, inserting this into bare-bones.scm gives a >> similar error. Thanks to samplet for help and confirmation on #guixsd. > > Just to make things clear, the bare-bones config below works with > Linux-Libre 4.17, but not with 4.18. We no longer build the =E2=80=9Dshp= chp=E2=80=9D > module. See commit 3004f1c69b258837b0e49a567787c97479ce6e71, which > includes the following: > > -CONFIG_HOTPLUG_PCI_SHPC=3Dm > +# CONFIG_HOTPLUG_PCI_SHPC is not set > > I don=E2=80=99t know anything about this module or this change, so I don= =E2=80=99t know > if we should change the config file or not. I will leave that to > someone more knowledgeable. I don=E2=80=99t know the rationale of this change, but I understand the pro= blem: it=E2=80=99s design issue with the module recommendation mechanism. Basica= lly it looks at modules needed on the current kernel for, say, your root file system, and then it recommends adding those. The problem occurs when you=E2=80=99re running on 4.17 and reconfiguring to= wards 4.18: on your system =E2=80=98shpchp=E2=80=99 is necessary, so =E2=80=98gui= x system=E2=80=99 recommends it, but on the target system it=E2=80=99s not. In that case =E2=80=98--ski= p-checks=E2=80=99 is needed. What we could do is determine that =E2=80=98shpchp.ko=E2=80=99 is not provi= ded by the target kernel, though that doesn=E2=80=99t tell us whether it=E2=80=99s nee= ded. Doing that also has the disadvantage that we must build/download the target kernel before we can emit the warning, as has been discussed before. Thoughts? Ludo=E2=80=99.