* bug#38755: icecat retains reference on clang
@ 2019-12-26 20:49 Ricardo Wurmus
[not found] ` <handler.38755.B.157739336123029.ack@debbugs.gnu.org>
0 siblings, 1 reply; 6+ messages in thread
From: Ricardo Wurmus @ 2019-12-26 20:49 UTC (permalink / raw)
To: 38755
Icecat retains a reference on clang. This is because the file
./chrome/toolkit/content/global/buildconfig.html (inside of
lib/icecat/omni.ja) records configuration options, which include the
location of clang.
This should be removed.
--
Ricardo
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <handler.38755.B.157739336123029.ack@debbugs.gnu.org>]
* bug#38755: icecat retains reference on clang [not found] ` <handler.38755.B.157739336123029.ack@debbugs.gnu.org> @ 2019-12-26 23:08 ` Ricardo Wurmus 2019-12-28 0:25 ` Ludovic Courtès 0 siblings, 1 reply; 6+ messages in thread From: Ricardo Wurmus @ 2019-12-26 23:08 UTC (permalink / raw) To: 38755 [-- Attachment #1: Type: text/plain, Size: 27 bytes --] This should do the trick: [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: my.patch --] [-- Type: text/x-patch, Size: 766 bytes --] diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index d5d9839e1a..e9458037a5 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -1023,7 +1023,11 @@ from forcing GEXP-PROMISE." (format #t "configure flags: ~s~%" flags) (apply invoke bash (string-append srcdir "/configure") - flags)))) + flags) + ;; Remove references to store items + (substitute* "toolkit/content/buildconfig.html" + (("/gnu/store") "")) + #t))) (replace 'build ;; The build system often spuriously fails. See ;; <https://bugs.gentoo.org/show_bug.cgi?id=680934>. To [-- Attachment #3: Type: text/plain, Size: 13 bytes --] -- Ricardo ^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#38755: icecat retains reference on clang 2019-12-26 23:08 ` Ricardo Wurmus @ 2019-12-28 0:25 ` Ludovic Courtès 2019-12-28 19:47 ` Efraim Flashner 0 siblings, 1 reply; 6+ messages in thread From: Ludovic Courtès @ 2019-12-28 0:25 UTC (permalink / raw) To: Ricardo Wurmus; +Cc: 38755 Hi, Ricardo Wurmus <rekado@elephly.net> skribis: > This should do the trick: > > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm > index d5d9839e1a..e9458037a5 100644 > --- a/gnu/packages/gnuzilla.scm > +++ b/gnu/packages/gnuzilla.scm > @@ -1023,7 +1023,11 @@ from forcing GEXP-PROMISE." > (format #t "configure flags: ~s~%" flags) > (apply invoke bash > (string-append srcdir "/configure") > - flags)))) > + flags) > + ;; Remove references to store items > + (substitute* "toolkit/content/buildconfig.html" > + (("/gnu/store") "")) This should not be a literal “/gnu/store”, though. Perhaps we should just use ‘remove-store-references’ instead of ‘substitute*’? Thanks, Ludo’. ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#38755: icecat retains reference on clang 2019-12-28 0:25 ` Ludovic Courtès @ 2019-12-28 19:47 ` Efraim Flashner 2019-12-28 23:05 ` Julien Lepiller 0 siblings, 1 reply; 6+ messages in thread From: Efraim Flashner @ 2019-12-28 19:47 UTC (permalink / raw) To: Ludovic Courtès; +Cc: 38755 [-- Attachment #1: Type: text/plain, Size: 1306 bytes --] On Sat, Dec 28, 2019 at 01:25:50AM +0100, Ludovic Courtès wrote: > Hi, > > Ricardo Wurmus <rekado@elephly.net> skribis: > > > This should do the trick: > > > > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm > > index d5d9839e1a..e9458037a5 100644 > > --- a/gnu/packages/gnuzilla.scm > > +++ b/gnu/packages/gnuzilla.scm > > @@ -1023,7 +1023,11 @@ from forcing GEXP-PROMISE." > > (format #t "configure flags: ~s~%" flags) > > (apply invoke bash > > (string-append srcdir "/configure") > > - flags)))) > > + flags) > > + ;; Remove references to store items > > + (substitute* "toolkit/content/buildconfig.html" > > + (("/gnu/store") "")) > > This should not be a literal “/gnu/store”, though. Perhaps we should > just use ‘remove-store-references’ instead of ‘substitute*’? > This way we still get a listing of exactly which store items were used without needing to refer to them exactly. -- Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#38755: icecat retains reference on clang 2019-12-28 19:47 ` Efraim Flashner @ 2019-12-28 23:05 ` Julien Lepiller 2019-12-29 7:16 ` Efraim Flashner 0 siblings, 1 reply; 6+ messages in thread From: Julien Lepiller @ 2019-12-28 23:05 UTC (permalink / raw) To: Efraim Flashner; +Cc: 38755 Le 28 décembre 2019 20:47:40 GMT+01:00, Efraim Flashner <efraim@flashner.co.il> a écrit : >On Sat, Dec 28, 2019 at 01:25:50AM +0100, Ludovic Courtès wrote: >> Hi, >> >> Ricardo Wurmus <rekado@elephly.net> skribis: >> >> > This should do the trick: >> > >> > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm >> > index d5d9839e1a..e9458037a5 100644 >> > --- a/gnu/packages/gnuzilla.scm >> > +++ b/gnu/packages/gnuzilla.scm >> > @@ -1023,7 +1023,11 @@ from forcing GEXP-PROMISE." >> > (format #t "configure flags: ~s~%" flags) >> > (apply invoke bash >> > (string-append srcdir "/configure") >> > - flags)))) >> > + flags) >> > + ;; Remove references to store items >> > + (substitute* "toolkit/content/buildconfig.html" >> > + (("/gnu/store") "")) >> >> This should not be a literal “/gnu/store”, though. Perhaps we should >> just use ‘remove-store-references’ instead of ‘substitute*’? >> > >This way we still get a listing of exactly which store items were used >without needing to refer to them exactly. It shouldn't be literaly /gnu/store, because one could use a different store path. Can we access the store path from a phase code? ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#38755: icecat retains reference on clang 2019-12-28 23:05 ` Julien Lepiller @ 2019-12-29 7:16 ` Efraim Flashner 0 siblings, 0 replies; 6+ messages in thread From: Efraim Flashner @ 2019-12-29 7:16 UTC (permalink / raw) To: Julien Lepiller; +Cc: 38755 [-- Attachment #1: Type: text/plain, Size: 1755 bytes --] On Sun, Dec 29, 2019 at 12:05:28AM +0100, Julien Lepiller wrote: > Le 28 décembre 2019 20:47:40 GMT+01:00, Efraim Flashner <efraim@flashner.co.il> a écrit : > >On Sat, Dec 28, 2019 at 01:25:50AM +0100, Ludovic Courtès wrote: > >> Hi, > >> > >> Ricardo Wurmus <rekado@elephly.net> skribis: > >> > >> > This should do the trick: > >> > > >> > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm > >> > index d5d9839e1a..e9458037a5 100644 > >> > --- a/gnu/packages/gnuzilla.scm > >> > +++ b/gnu/packages/gnuzilla.scm > >> > @@ -1023,7 +1023,11 @@ from forcing GEXP-PROMISE." > >> > (format #t "configure flags: ~s~%" flags) > >> > (apply invoke bash > >> > (string-append srcdir "/configure") > >> > - flags)))) > >> > + flags) > >> > + ;; Remove references to store items > >> > + (substitute* "toolkit/content/buildconfig.html" > >> > + (("/gnu/store") "")) > >> > >> This should not be a literal “/gnu/store”, though. Perhaps we should > >> just use ‘remove-store-references’ instead of ‘substitute*’? > >> > > > >This way we still get a listing of exactly which store items were used > >without needing to refer to them exactly. > > It shouldn't be literaly /gnu/store, because one could use a different store path. Can we access the store path from a phase code? Good point. Perhaps 'remove-store-references' would just be best. -- Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-29 7:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-26 20:49 bug#38755: icecat retains reference on clang Ricardo Wurmus
[not found] ` <handler.38755.B.157739336123029.ack@debbugs.gnu.org>
2019-12-26 23:08 ` Ricardo Wurmus
2019-12-28 0:25 ` Ludovic Courtès
2019-12-28 19:47 ` Efraim Flashner
2019-12-28 23:05 ` Julien Lepiller
2019-12-29 7:16 ` Efraim Flashner
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).