* bug#41827: lib2geom fails tests on i686-linux
@ 2020-06-12 12:30 Marius Bakke
2020-06-12 12:33 ` Marius Bakke
0 siblings, 1 reply; 5+ messages in thread
From: Marius Bakke @ 2020-06-12 12:30 UTC (permalink / raw)
To: 41827
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
lib2geom fails several tests on i686-linux:
https://ci.guix.gnu.org/log/h3d9i8jqygnc3qvcd83c678kzmr5p4b7-lib2geom-1.0-1.42e119d
This is a dependency of Inkscape 1.0.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#41827: lib2geom fails tests on i686-linux
2020-06-12 12:30 bug#41827: lib2geom fails tests on i686-linux Marius Bakke
@ 2020-06-12 12:33 ` Marius Bakke
2020-06-14 19:19 ` Maxim Cournoyer
2020-06-18 6:28 ` Maxim Cournoyer
0 siblings, 2 replies; 5+ messages in thread
From: Marius Bakke @ 2020-06-12 12:33 UTC (permalink / raw)
To: 41827
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
Marius Bakke <marius@gnu.org> writes:
> lib2geom fails several tests on i686-linux:
>
> https://ci.guix.gnu.org/log/h3d9i8jqygnc3qvcd83c678kzmr5p4b7-lib2geom-1.0-1.42e119d
>
> This is a dependency of Inkscape 1.0.
The same tests also fail on aarch64-linux:
https://ci.guix.gnu.org/log/rq7d8y0b8cv7ils7wd3fq97br8j3d4xz-lib2geom-1.0-1.42e119d
armhf-linux and x86_64-linux seems fine.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#41827: lib2geom fails tests on i686-linux
2020-06-12 12:33 ` Marius Bakke
@ 2020-06-14 19:19 ` Maxim Cournoyer
2020-06-18 6:28 ` Maxim Cournoyer
1 sibling, 0 replies; 5+ messages in thread
From: Maxim Cournoyer @ 2020-06-14 19:19 UTC (permalink / raw)
To: Marius Bakke; +Cc: 41827
Hello Marius,
Marius Bakke <marius@gnu.org> writes:
> Marius Bakke <marius@gnu.org> writes:
>
>> lib2geom fails several tests on i686-linux:
>>
>> https://ci.guix.gnu.org/log/h3d9i8jqygnc3qvcd83c678kzmr5p4b7-lib2geom-1.0-1.42e119d
>>
>> This is a dependency of Inkscape 1.0.
>
> The same tests also fail on aarch64-linux:
>
> https://ci.guix.gnu.org/log/rq7d8y0b8cv7ils7wd3fq97br8j3d4xz-lib2geom-1.0-1.42e119d
>
> armhf-linux and x86_64-linux seems fine.
I had a quick look of the output, and it seems the failures are due to
comparison of inexact numbers. A quick idea would be to make sure that
the test suite is making use of Googletest's floating point comparison
macros, which are designed to handle variations on floats [0].
If that's the flaw, we sould implement a patch and contribute it to
upstream.
Maxim
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#41827: lib2geom fails tests on i686-linux
2020-06-12 12:33 ` Marius Bakke
2020-06-14 19:19 ` Maxim Cournoyer
@ 2020-06-18 6:28 ` Maxim Cournoyer
2020-06-19 3:32 ` Maxim Cournoyer
1 sibling, 1 reply; 5+ messages in thread
From: Maxim Cournoyer @ 2020-06-18 6:28 UTC (permalink / raw)
To: Marius Bakke; +Cc: 41827
Hello,
I think I've fixed it with commit 620796e66b.
Maxim
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#41827: lib2geom fails tests on i686-linux
2020-06-18 6:28 ` Maxim Cournoyer
@ 2020-06-19 3:32 ` Maxim Cournoyer
0 siblings, 0 replies; 5+ messages in thread
From: Maxim Cournoyer @ 2020-06-19 3:32 UTC (permalink / raw)
To: Marius Bakke; +Cc: 41827-done
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Hello,
>
> I think I've fixed it with commit 620796e66b.
Closing,
Maxim
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-19 3:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-12 12:30 bug#41827: lib2geom fails tests on i686-linux Marius Bakke
2020-06-12 12:33 ` Marius Bakke
2020-06-14 19:19 ` Maxim Cournoyer
2020-06-18 6:28 ` Maxim Cournoyer
2020-06-19 3:32 ` Maxim Cournoyer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).