From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qCaOJUC+Yl8haQAA0tVLHw (envelope-from ) for ; Thu, 17 Sep 2020 01:39:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UDaKIUC+Yl/nfgAA1q6Kng (envelope-from ) for ; Thu, 17 Sep 2020 01:39:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 071179402CC for ; Thu, 17 Sep 2020 01:39:11 +0000 (UTC) Received: from localhost ([::1]:37562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIitB-0007im-Kv for larch@yhetil.org; Wed, 16 Sep 2020 21:39:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIit4-0007iZ-Jx for bug-guix@gnu.org; Wed, 16 Sep 2020 21:39:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53652) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIit4-0004yB-9O for bug-guix@gnu.org; Wed, 16 Sep 2020 21:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIit4-0001vD-5y for bug-guix@gnu.org; Wed, 16 Sep 2020 21:39:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43344: "basic" system tests fail (and all the other ones) on guix master Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 17 Sep 2020 01:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43344 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Leo Famulari , Danny Milosavljevic Received: via spool by 43344-submit@debbugs.gnu.org id=B43344.16003066987327 (code B ref 43344); Thu, 17 Sep 2020 01:39:02 +0000 Received: (at 43344) by debbugs.gnu.org; 17 Sep 2020 01:38:18 +0000 Received: from localhost ([127.0.0.1]:36965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIisM-0001u7-6R for submit@debbugs.gnu.org; Wed, 16 Sep 2020 21:38:18 -0400 Received: from world.peace.net ([64.112.178.59]:48806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIisK-0001tv-9i for 43344@debbugs.gnu.org; Wed, 16 Sep 2020 21:38:17 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIisE-0002I3-Df; Wed, 16 Sep 2020 21:38:10 -0400 From: Mark H Weaver In-Reply-To: <20200916162244.GA3262@jasmine.lan> References: <20200911195058.6dc013b4@scratchpost.org> <877dsw7alf.fsf@gnu.org> <20200914183037.624cc347@scratchpost.org> <87y2laactz.fsf@netris.org> <20200915230628.GA20807@jasmine.lan> <20200916141231.GA28015@jasmine.lan> <20200916165245.421e3c4c@scratchpost.org> <20200916162244.GA3262@jasmine.lan> Date: Wed, 16 Sep 2020 21:36:49 -0400 Message-ID: <87363h9oab.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Othacehe , 43344@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 35NDGfesewml Leo Famulari writes: > On Wed, Sep 16, 2020 at 04:52:45PM +0200, Danny Milosavljevic wrote: >> commit 692d0626557451c4b557397f20b7394b612d0289 >> Author: Christoph Hellwig >> Date: Tue Sep 1 11:59:41 2020 +0200 >> >> block: fix locking in bdev_del_partition >> >> [ Upstream commit 08fc1ab6d748ab1a690fd483f41e2938984ce353 ] >> >> We need to hold the whole device bd_mutex to protect against >> other thread concurrently deleting out partition before we get >> to it, and thus causing a use after free. >> >> Fixes: cddae808aeb7 ("block: pass a hd_struct to delete_partition") >> Reported-by: syzbot+6448f3c229bc52b82f69@syzkaller.appspotmail.com >> Signed-off-by: Christoph Hellwig >> Signed-off-by: Jens Axboe >> Signed-off-by: Sasha Levin >> >> ? > > Do you think that's the faulty commit? I won't have time to test it > today. Looks like a good bet to me. Many thanks to Leo for testing 5.8.9, and to Danny for identifying the likely culprit. Next, it probably makes sense to test 5.8.9 with the above commit reverted. Would someone like to try it? If that works, we can avoid the bisection, resume kernel updates, and revert this change across all of our kernels until a better solution is found. Mark