From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2p3kDuv0rF9oPwAA0tVLHw (envelope-from ) for ; Thu, 12 Nov 2020 08:40:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id EEwmCuv0rF9jBgAAbx9fmQ (envelope-from ) for ; Thu, 12 Nov 2020 08:40:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CE09794053D for ; Thu, 12 Nov 2020 08:40:10 +0000 (UTC) Received: from localhost ([::1]:35490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kd89J-0004u0-RM for larch@yhetil.org; Thu, 12 Nov 2020 03:40:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kd89D-0004tr-0H for bug-guix@gnu.org; Thu, 12 Nov 2020 03:40:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60222) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kd89C-0000Sy-NL for bug-guix@gnu.org; Thu, 12 Nov 2020 03:40:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kd89C-0006I0-KB for bug-guix@gnu.org; Thu, 12 Nov 2020 03:40:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44353: [PATCH version-1.2.0 v2 1/3] image: Remove conflicting user-provided EFI file system. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 12 Nov 2020 08:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44353 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Maxim Cournoyer Received: via spool by 44353-submit@debbugs.gnu.org id=B44353.160517039924163 (code B ref 44353); Thu, 12 Nov 2020 08:40:02 +0000 Received: (at 44353) by debbugs.gnu.org; 12 Nov 2020 08:39:59 +0000 Received: from localhost ([127.0.0.1]:43535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd898-0006He-Sz for submit@debbugs.gnu.org; Thu, 12 Nov 2020 03:39:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd897-0006HQ-3E for 44353@debbugs.gnu.org; Thu, 12 Nov 2020 03:39:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48647) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kd890-0000OB-Bb; Thu, 12 Nov 2020 03:39:51 -0500 Received: from [2a01:e0a:19b:d9a0:a5e0:155b:c52:63c1] (port=37834 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kd88y-00066i-SP; Thu, 12 Nov 2020 03:39:50 -0500 From: Mathieu Othacehe References: <87h7q0cdns.fsf@gnu.org> <20201112035713.3789-1-maxim.cournoyer@gmail.com> Date: Thu, 12 Nov 2020 09:39:47 +0100 In-Reply-To: <20201112035713.3789-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Wed, 11 Nov 2020 22:57:11 -0500") Message-ID: <87361fvui4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44353@debbugs.gnu.org, Jesse Gibbons Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: HQ0j9ev2DjLS Hey Maxim, > When the bootloader used is grub-efi-bootloader, an ESP partition and file > system is already added by the image generator. If a conflicting > user-provided EFI file system is provided, it will (likely) cause the boot to > fail, as happens for the lightweight-desktop.tmpl and desktop.tmpl templates > under gnu/system/examples. Nice one. I would just clarify in the commit message that the ESP partition is added only when the selected image type is "raw". Otherwise, it looks fine! Thanks, Mathieu