From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sPjYIxDoYmCoIQEAgWs5BA (envelope-from ) for ; Tue, 30 Mar 2021 10:57:52 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id pNGgHRDoYmDccwAAbx9fmQ (envelope-from ) for ; Tue, 30 Mar 2021 08:57:52 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A449322C38 for ; Tue, 30 Mar 2021 10:57:51 +0200 (CEST) Received: from localhost ([::1]:55640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRAC6-0006KI-B9 for larch@yhetil.org; Tue, 30 Mar 2021 04:57:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRABK-0005sf-Eh for bug-guix@gnu.org; Tue, 30 Mar 2021 04:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38843) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRABK-0006zz-7Z for bug-guix@gnu.org; Tue, 30 Mar 2021 04:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lRABK-00053k-6e for bug-guix@gnu.org; Tue, 30 Mar 2021 04:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#47479: inkscape retains a reference to imagemagick, even though it is in native-inputs Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 30 Mar 2021 08:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47479 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Efraim Flashner Received: via spool by 47479-submit@debbugs.gnu.org id=B47479.161709462119444 (code B ref 47479); Tue, 30 Mar 2021 08:57:02 +0000 Received: (at 47479) by debbugs.gnu.org; 30 Mar 2021 08:57:01 +0000 Received: from localhost ([127.0.0.1]:50389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRABJ-00053U-9I for submit@debbugs.gnu.org; Tue, 30 Mar 2021 04:57:01 -0400 Received: from world.peace.net ([64.112.178.59]:55156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRABH-00053H-RT for 47479@debbugs.gnu.org; Tue, 30 Mar 2021 04:57:00 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRABB-00079A-BS; Tue, 30 Mar 2021 04:56:53 -0400 From: Mark H Weaver In-Reply-To: References: <9beb8d6af78a517d53aaaa43179272b8953da78f.camel@telenet.be> <87lfa53bkj.fsf@netris.org> Date: Tue, 30 Mar 2021 04:55:13 -0400 Message-ID: <8735wd2f77.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 47479@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617094671; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=+5jHHtD3Zmbl05tc5CFgn3Q4okgWsxqezA/F4F9a+10=; b=mOXShauqvN1hWSS02bUvdqSRm10qtmABnMh/X8qDer5iwtA5h3dpLiV1VGoEU8JaoHGOwP KVGLwX6//+709NhxehniL5Hn1WxLaXxlSaLv2oIb2/i4ixtKcOeI5En3lhkH8rartQIi4O G1bSGc2oOsOAk7wkKzSIu3+bHBgjYXxK7YeNia3JgSBxA+fNSRpXvhtkea41tYoOD9jUa5 Sqi1g4aOcYlCm4iFK9yKo/8CDnHO6GjdF5jBOGozsIOLEmyTkjlJmuTs/sGOFDxu6+sFh+ IXeMUMB1cexpLrYoHVbR48tKwejZjkaEMuC44H6I8o4f5RthvF7ID9MXZKdPVA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617094671; a=rsa-sha256; cv=none; b=alZsjFGrLnPDHnV7oqU3NA/5tQyO1Q2YFJpwRYtMi3aavVcDHOaXgUUnYB0CVFIWZcqICr DO0i9ewnK5Vc8qWG3HHgoD2azfoyRSS2peU63wQmqxq6z9oG2waBuvDEbKWrAC2+WgerYT MRMiFSMMr1jkkkg6U686Ey0cKI91sViA+druyZdNRqq64PhuQZJ0fhatmhEfJOrqNdsi/D XIWTIrL6UdjOdFgE+r2OWW8jlG8VO5g3pFZKfz4grE3DZqAtEdYJO0gcIv3KMzS0UTiO9H S8bOLE9upCthP0vVbprzGROszRVZKybIpw2J/XnZjDZzZ8BLkV933GnKNisEnA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.42 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: A449322C38 X-Spam-Score: -2.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: p5ZN0NsnHbEf Hi Efraim, Efraim Flashner writes: > It is the case for inkscape@1.0.2 I see now that I'm using an older version, although I would have preferred the newer one. I refer to the variable name 'inkscape' from my manifest file, and I expected that to point to the latest stable version. However, it seems that one must use the 'inkscape-1.0' variable to get the latest stable version. That's seems suboptimal. I wonder if the 'inkscape' variable should be renamed 'inkscape/stable' (for use in packages such as 'dblatex/stable'), and then 'inkscape' could be repurposed to point to the latest stable version. Thoughts? > (ins)efraim@3900XT ~$ guix package -A inkscape > inkscape 1.0.2 out gnu/packages/inkscape.scm:121:2 > inkscape 0.92.4 out gnu/packages/inkscape.scm:56:2 > (ins)efraim@3900XT ~$ guix gc --references $(guix build inkscape@1) | grep -i imagemagick > /gnu/store/y4rym48vihmh3jk9qnll0zqfnxzi9n6v-imagemagick-6.9.12-4 > > I believe it comes from the glib-or-gtk-wrap phase where it wraps the > XDG_DATA_DIRS and likely grabs more than it needs. Good catch! So, for now, we shouldn't use 'imagemagick/stable' in 'inkscape', even though it's in 'native-inputs'. This shows that we'll have to be very careful about this, at least until we have better tooling to catch these problems automatically. I think the fundamental problem here is that the build-side code cannot distinguish between 'inputs' and 'native-inputs' unless you are cross-compiling. When compiling natively, the 'inputs' keyword argument passed to the build phases includes the packages listed in the 'native-inputs' package field, and the 'native-inputs' keyword argument is not passed at all. This is why we must write (or native-inputs inputs) in so many places: because to find the location of a package listed in the 'native-inputs' package field from within build-side code, you must look in one of two places depending on whether you're cross-compiling. If you're cross-compiling you must look in 'native-inputs'. When compiling natively, that argument doesn't even exist, and you must look in the 'inputs' keyword argument instead. I don't know why it was done this way. It seems to me an error-prone design, but at this point it would be hard to change it. Now we see another disadvantage. The 'glib-or-gtk-wrap' phase should be iterating over the 'inputs' but not the 'native-inputs'. It's not obvious how to fix this given the current design. What do you think? Regards, Mark