unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Cees de Groot <cg@evrl.com>
Cc: "47239@debbugs.gnu.org" <47239-done@debbugs.gnu.org>
Subject: bug#47239: Test failure in tests/publish.scm with commit 1955ef93b76e51cab5bed4c90f7eb9df7035355a
Date: Wed, 31 Mar 2021 16:02:15 +0200	[thread overview]
Message-ID: <8735wba0bc.fsf@gnu.org> (raw)
In-Reply-To: <47SHfOqtf5hQVCuz4_qa5-l6KHlNdy4vCqvta2XchFJuC6e8U1QngEpPQLsMD2HeZVVSCqEpCnvu3YE8jItMMWHuRdzN7mKEUiW4307toxk=@evrl.com> (Cees de Groot's message of "Wed, 24 Mar 2021 02:32:35 +0000")

Hi,

Cees de Groot <cg@evrl.com> skribis:

> I think this is a simple umask issue. Making the test check for just the bits worked for me:
>
> diff --git a/tests/publish.scm b/tests/publish.scm
> index 52101876b5..3e67c435ac 100644
> --- a/tests/publish.scm
> +++ b/tests/publish.scm
> @@ -452,8 +452,8 @@ References: ~%"
> (wait-for-file cached)
>
> ;; Both the narinfo and nar should be world-readable.
> - (= #o644 (stat:perms (lstat cached)))
> - (= #o644 (stat:perms (lstat nar)))
> + (= #o444 (logand #o444 (stat:perms (lstat cached))))
> + (= #o444 (logand #o444 (stat:perms (lstat nar))))

Indeed.  Pushed as c536f0b217714917988d2f412999d978c2f2f495 on your
behalf.

Thanks!

Ludo’.




      reply	other threads:[~2021-03-31 14:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18 15:05 bug#47239: Test failure in tests/publish.scm with commit 1955ef93b76e51cab5bed4c90f7eb9df7035355a Konrad Hinsen
2021-03-20 20:41 ` Ludovic Courtès
2021-03-21 10:26   ` Konrad Hinsen
2021-03-21 14:25     ` zimoun
2021-03-22  7:54       ` Konrad Hinsen
2021-03-22 16:04 ` Cees de Groot
2021-03-24  2:32 ` Cees de Groot
2021-03-31 14:02   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735wba0bc.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=47239-done@debbugs.gnu.org \
    --cc=cg@evrl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).