unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 47889@debbugs.gnu.org
Subject: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk
Date: Mon, 26 Apr 2021 17:53:54 +0200	[thread overview]
Message-ID: <8735vdca99.fsf@gnu.org> (raw)
In-Reply-To: <878s56uw3c.fsf@gnu.org> (Mathieu Othacehe's message of "Sun, 25 Apr 2021 19:12:39 +0200")

Hi Mathieu,

Mathieu Othacehe <othacehe@gnu.org> skribis:

>> Can you force GPT also in 2.?  All disk partitions get removed anyway.
>> Arch wiki says MSDOS layout does not work on all EFI systems
>> <https://wiki.archlinux.org/index.php/EFI_system_partition#Create_the_partition>.
>
> Well I'm not sure, if someone has an MSDOS partition table with an ESP
> partition it wouldn't be a good idea to wipe it.
>
> The attached patch forces GPT if there's no partition table, and will
> preserve/create an ESP partition on an MSDOS/EFI setup. I'm testing it
> on various machines, seems to work fine.

The patch looks reasonable to me, thanks a lot!

(It’s also reasonable to ignore ESP-on-MSDOS IMO.)

Ludo’.




  parent reply	other threads:[~2021-04-26 15:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19  9:29 bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk pelzflorian (Florian Pelz)
2021-04-19 11:01 ` pelzflorian (Florian Pelz)
2021-04-19 17:27 ` Leo Famulari
2021-04-19 20:19   ` pelzflorian (Florian Pelz)
2021-04-22 13:28 ` Ludovic Courtès
2021-04-22 14:38   ` pelzflorian (Florian Pelz)
2021-04-23 10:39     ` Ludovic Courtès
2021-04-23 11:12       ` pelzflorian (Florian Pelz)
2021-04-24  3:24       ` Bengt Richter
2021-04-24  9:31         ` pelzflorian (Florian Pelz)
2021-04-25 14:15       ` Mathieu Othacehe
2021-04-25 16:34         ` pelzflorian (Florian Pelz)
2021-04-25 17:12           ` Mathieu Othacehe
2021-04-26 11:17             ` pelzflorian (Florian Pelz)
2021-04-26 15:53             ` Ludovic Courtès [this message]
2021-04-26 16:37               ` Mathieu Othacehe
2021-04-27 16:48                 ` Mathieu Othacehe
2021-04-28 13:54                   ` Mathieu Othacehe
2021-04-29  7:45                     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735vdca99.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=47889@debbugs.gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).