unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Ben Sturmfels via Bug reports for GNU Guix <bug-guix@gnu.org>
To: 27447-done@debbugs.gnu.org
Cc: Mark H Weaver <mhw@netris.org>, ng0 <ng0@infotropique.org>,
	zimoun <zimon.toutoune@gmail.com>
Subject: bug#27447: pelican-quickstart produces files with store path shebangs
Date: Tue, 05 Oct 2021 10:06:28 +1100	[thread overview]
Message-ID: <8735pg2xvv.fsf@sturm.com.au> (raw)
In-Reply-To: <878rz82yrz.fsf@sturm.com.au> (Ben Sturmfels's message of "Tue, 05 Oct 2021 09:06:07 +1100")

On Tue, 05 Oct 2021, Ben Sturmfels wrote:

>> ng0 wrote on 22 Jun 2017 14:35:
>>
>> In a pelican directory after running pelican-quickstart:
>> egrep -nr "store"
>> …
>> pelicanconf.py:1:#!/gnu/store/bf54hnwd8mb63zmssc23fwslf5zvxpxs-python-wrapper-3.5.3/bin/python
>> develop_server.sh:1:#!/gnu/store/k7029k5va68lkapbzcycdzj7m5bjb4b8-bash-4.4.12/bin/bash
>> publishconf.py:1:#!/gnu/store/bf54hnwd8mb63zmssc23fwslf5zvxpxs-python-wrapper-3.5.3/bin/python
>
> This is a technically a bug, but it's in upstream and has no effect in
> practise, so I'll close this bug report. Details below.
>
> As of Pelican 4.7.0 which I've just submitted an update patch for,
> develop_server.sh is no longer created:
>
> $ egrep -nr "store"
> pelicanconf.py:1:#!/gnu/store/nckjv3ccwdi6096j478gvns43ssbls2p-python-wrapper-3.8.2/bin/python
> publishconf.py:1:#!/gnu/store/nckjv3ccwdi6096j478gvns43ssbls2p-python-wrapper-3.8.2/bin/python
>
> This is *technically* a bug because these configuration files are
> created once when the user is setting up their blog and will be used
> forever after. In practise though, there's no issue since these files
> are not executable - they are configuration only.
>
> This also isn't a packaging bug in Guix, it's upstream as zimoun
> suggests. Here's the first line of those files as generated by upstream
> pelican-quickstart:
>
> $ head -n1 pelicanconf.py publishconf.py 
> ==> pelicanconf.py <==
> #!/usr/bin/env python
>
> ==> publishconf.py <==
> #!/usr/bin/env python
>
> These upstream files should not contain shebangs since they are not
> executable or ever intended to be executed directly - they're config
> only and have no functionality.

I've now submitted a patch upstream:

https://github.com/getpelican/pelican/pull/2932

Closing.




      reply	other threads:[~2021-10-04 23:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22 12:35 bug#27447: pelican-quickstart produces files with store path shebangs ng0
2020-12-18 20:10 ` zimoun
2021-01-11 12:59   ` zimoun
2021-01-13 23:37     ` Mark H Weaver
2021-01-14  9:37       ` zimoun
2021-01-14 23:00         ` Mark H Weaver
2021-09-14 15:17           ` zimoun
2021-10-04 22:06 ` Ben Sturmfels via Bug reports for GNU Guix
2021-10-04 23:06   ` Ben Sturmfels via Bug reports for GNU Guix [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735pg2xvv.fsf@sturm.com.au \
    --to=bug-guix@gnu.org \
    --cc=27447-done@debbugs.gnu.org \
    --cc=ben@sturm.com.au \
    --cc=mhw@netris.org \
    --cc=ng0@infotropique.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).