From: "Ludovic Courtès" <ludo@gnu.org>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: 53355@debbugs.gnu.org, 51466@debbugs.gnu.org
Subject: bug#51466: bug#53355: guix shell --check: confusing error message
Date: Fri, 20 May 2022 23:37:01 +0200 [thread overview]
Message-ID: <8735h3x4w2.fsf@gnu.org> (raw)
In-Reply-To: <87ilso461i.fsf_-_@gnu.org> ("Ludovic Courtès"'s message of "Tue, 08 Mar 2022 20:07:21 +0100")
Hi Chris,
A friendly ping. :-)
Ludo’.
Ludovic Courtès <ludo@gnu.org> skribis:
> Hi Chris,
>
> Did you have a chance to look into it?
>
> https://issues.guix.gnu.org/53355
>
> TIA. :-)
>
> Ludo’.
>
> Ludovic Courtès <ludo@gnu.org> skribis:
>
>> Hi Chris,
>>
>> Thanks for debugging this!
>>
>> Chris Marusich <cmmarusich@gmail.com> skribis:
>>
>>> From c3eea81846ae71a246e6b592be74062f4bf26474 Mon Sep 17 00:00:00 2001
>>> From: Chris Marusich <cmmarusich@gmail.com>
>>> Date: Sun, 13 Feb 2022 14:15:14 -0800
>>> Subject: [PATCH] environment: Prevent PS1 from clobbering output in 'check'.
>>>
>>> Fixes: <https://issues.guix.gnu.org/51466>.
>>>
>>> * guix/scripts/environment.scm (child-shell-environment): In the script
>>> executed the child shell, set PS1 to an empty value and then echo three
>>> sentinel lines to try to "flush" the original PS1 value before printing the
>>> environment variables. In the parent process, read and discard all lines up
>>> to and including the last sentinel line. After that, read the remaining lines
>>> as usual.
>>
>> [...]
>>
>>> + ;; Why print "GUIX_FLUSH" a few times? We are trying to "flush" the
>>> + ;; original PS1 value to the port so we can read it (and discard it)
>>> + ;; before we start reading the environment variables from the port. If we
>>> + ;; don't do this, the original PS1 value can sometimes get interleaved
>>> + ;; into the output, which interferes with our parsing logic. It's a hack,
>>> + ;; but in practice it seems to do the job. If you know of a more graceful
>>> + ;; solution, please implement it! See: https://issues.guix.gnu.org/51466
>>> + "PS1=; for i in 1 2 3; do echo GUIX_FLUSH_$i; done; \
>>> +env || /usr/bin/env || set; echo GUIX-CHECK-DONE; read x; exit\n")
>>
>> So you confirm that a single “echo” is not enough, right?
>>
>> Perhaps we should unroll the ‘for’ loop for portability, to be on the
>> safe side. Initially I tested with Bash, Zsh, and Fish:
>>
>> https://issues.guix.gnu.org/51285#0-lineno49
>>
>> I think Fish has a very non-POSIX syntax, hence the suggestion to avoid
>> ‘for’.
>>
>> I realized that setting PS1 could interfere with the logic below that
>> checks for PS1. And since it doesn’t seem to help, perhaps we can
>> remove “PS1=;”?
>>
>> Thoughts?
>>
>> Sorry to answer with yet more questions!
>>
>> Thanks,
>> Ludo’.
next prev parent reply other threads:[~2022-05-20 21:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 3:29 bug#53355: guix shell --check: confusing error message Chris Marusich
2022-01-24 14:35 ` Ludovic Courtès
2022-01-25 0:55 ` Chris Marusich
2022-01-25 13:39 ` Ludovic Courtès
2022-02-02 7:49 ` bug#51466: " Chris Marusich
2022-02-08 9:26 ` Ludovic Courtès
2022-02-13 23:17 ` Chris Marusich
2022-02-14 9:47 ` Ludovic Courtès
2022-03-08 19:07 ` Ludovic Courtès
2022-05-20 21:37 ` Ludovic Courtès [this message]
2022-05-24 4:42 ` Chris Marusich
2022-06-13 10:03 ` Ludovic Courtès
2022-06-19 20:40 ` Chris Marusich
2022-06-20 7:34 ` bug#51466: " Ludovic Courtès
2022-06-20 10:12 ` bug#53355: " bokr
2022-06-20 17:56 ` Bengt Richter
2022-06-20 23:27 ` bug#51466: " Bengt Richter
2022-06-21 4:00 ` Thiago Jung Bauermann via Bug reports for GNU Guix
2022-06-25 9:07 ` Chris Marusich
2022-06-25 9:37 ` bug#53355: bug#51466: " Maxime Devos
2022-06-25 16:52 ` Chris Marusich
2022-06-25 17:40 ` Maxime Devos
2022-06-25 20:06 ` bug#51466: " bokr
2022-06-25 21:04 ` Maxime Devos
2022-06-26 10:33 ` Josselin Poiret via Bug reports for GNU Guix
2022-06-26 13:07 ` Maxime Devos
2022-06-26 19:45 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2022-06-27 10:17 ` bug#51466: " Ludovic Courtès
2022-06-27 10:34 ` bug#53355: " Maxime Devos
2022-06-28 7:45 ` Ludovic Courtès
2022-06-28 10:38 ` Maxime Devos
2022-06-28 16:57 ` bug#53355: " paren--- via Bug reports for GNU Guix
2022-06-28 17:31 ` bug#51466: " Maxime Devos
2022-07-04 8:11 ` Ludovic Courtès
2022-06-27 11:23 ` bokr
2022-06-27 14:22 ` bug#51466: bug#53355: " Bengt Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735h3x4w2.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=51466@debbugs.gnu.org \
--cc=53355@debbugs.gnu.org \
--cc=cmmarusich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).