From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: "Pierre-Henry Fröhring" <contact@phfrohring.com>, 57039@debbugs.gnu.org
Subject: bug#57039: `make check' yields two failed tests.
Date: Tue, 09 Aug 2022 18:01:52 +0200 [thread overview]
Message-ID: <8735e55rtb.fsf@gnu.org> (raw)
In-Reply-To: <fb49feda-0f8d-f50c-e30b-8d36e89f722d@telenet.be> (Maxime Devos's message of "Tue, 9 Aug 2022 16:44:26 +0200")
Maxime Devos <maximedevos@telenet.be> skribis:
> On 09-08-2022 15:50, Ludovic Courtès wrote:
>>> + (entry (tag "tag-for-first-news-entry")
>>> + (title (en "Old news.") (eo "Malnova?oj."))
>> The question mark here suggests you’re not running the tests with a
>> UTF-8 locale.
>>
>> Could you add, say, ‘glibc-locales’ to your environment, ensure
>> GUIX_LOCPATH points to it, and set LC_ALL=en_US.UTF-8 (or similar)?
>>
> Two comments:
>
> If tests require an UTF-8 locale, I think the tests (maybe in
> build-aux/test-driver.scm?) should check that an UTF-8 that an UTF-8
> locale is actually in use and otherwise bail out properly.
>
> It's not a file-name but rather the contents of the news file, so I
> would think we are just forgetting to pass some arguments like
> #:encoding "UTF-8" -- making the interpretation of the news file
> depend on the current locale doesn't seem good to me (it's encoding on
> stdout with "guix pull --news" is another matter).
Agreed, I came to the same conclusion:
60e0aae89c channels: Consider news files as UTF-8-encoded by default.
e1b8bace8c tests: git: Write files as UTF-8.
Should have done that long ago!
Ludo’.
next prev parent reply other threads:[~2022-08-09 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-07 14:13 bug#57039: `make check' yields two failed tests Pierre-Henry Fröhring
2022-08-09 13:50 ` Ludovic Courtès
2022-08-09 14:44 ` Maxime Devos
2022-08-09 16:01 ` Ludovic Courtès [this message]
2022-08-09 14:50 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735e55rtb.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=57039@debbugs.gnu.org \
--cc=contact@phfrohring.com \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).