From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KI4eOlA98WOJbQEAbAwnHQ (envelope-from ) for ; Sat, 18 Feb 2023 22:04:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id iL8uOVA98WNKDgAAG6o9tA (envelope-from ) for ; Sat, 18 Feb 2023 22:04:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EB5653144E for ; Sat, 18 Feb 2023 22:04:15 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676754256; a=rsa-sha256; cv=none; b=mtW1k+zLUCx2k6W0c4Rt4sihx36f1LlqBqIVgiu1umHsEgsFypoqeP5TLJ6+zBG1Dbe0Ll firxvYUjTDRPASGxvFzZq7Mr0MPtU/NDPD2XAbXeKfzIuZg/ivYrYmT0kTePeZpujtXB/B 2htNRAzbFpTXOwnREszdH1upJ3EKJxxcw6Fbi/VLox0WmkaFiGNrDS03Y0kVNnq/ppG/Qu +5yS1ANC/Co6gor+SuBlARhxqgyCIJ+uKej37q+47p01Uod/iFL5XyJWUrSisM4cTBxNpU GUmVYWEw2rfqSBug0NQQvbB1LsXE5mXczHcetgy1Z52lzxudvMV+u7EAgCxJGg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676754256; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=wR4cEsRLPlt6CA5rv9fP4i2fTM4bI9FkdJalnE4Mf2A=; b=W+ALU91qrI7WRyuBT2hHYv/fjSzNxdwWpalD7wEOxxwO1wtLP+TeRtjScLsR6JyDdHLfk9 uOdyusKyYxWsQJr3P1qUoYGG4i4cLZyWKTK/4YySyAksl2VXVim/stZPUa1AFl+1mkF1Ex p4fBWaEWKU7O3hUH+00zjobYlaYUq1qB/URFaKwttqNoAm/bjteeXm5hpheHy989fuhw1N M5KsqvzehmamAT6KLs91phU027KWSqtlF3VbKsrQeTegvNvku4dFfkjx4oDlHRL3U76Rb2 6e1bRpQxrGHO1KnYRG94pONlCYNzggk1imOHO/A1DMI3sUWViSkmBhPLdphkcQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTUNH-00076I-VG; Sat, 18 Feb 2023 16:04:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTUNG-000766-CQ for bug-guix@gnu.org; Sat, 18 Feb 2023 16:04:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTUNG-0003cg-4M for bug-guix@gnu.org; Sat, 18 Feb 2023 16:04:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTUNF-0002Ex-SH for bug-guix@gnu.org; Sat, 18 Feb 2023 16:04:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#32026: [PATCH v3 04/11] gnu: icecat: Make language packs reproducible. Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 18 Feb 2023 21:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32026 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer , 32026@debbugs.gnu.org Cc: ludo@gnu.org, Jonathan Brielmaier , Maxim Cournoyer Received: via spool by 32026-submit@debbugs.gnu.org id=B32026.16767541988562 (code B ref 32026); Sat, 18 Feb 2023 21:04:01 +0000 Received: (at 32026) by debbugs.gnu.org; 18 Feb 2023 21:03:18 +0000 Received: from localhost ([127.0.0.1]:45074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTUMY-0002E2-E0 for submit@debbugs.gnu.org; Sat, 18 Feb 2023 16:03:18 -0500 Received: from world.peace.net ([64.112.178.59]:58876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTUMX-0002Dm-HZ for 32026@debbugs.gnu.org; Sat, 18 Feb 2023 16:03:17 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTUMO-0003qz-NY; Sat, 18 Feb 2023 16:03:08 -0500 From: Mark H Weaver In-Reply-To: <20230217125539.24467-4-maxim.cournoyer@gmail.com> References: <20230217125539.24467-1-maxim.cournoyer@gmail.com> <20230217125539.24467-4-maxim.cournoyer@gmail.com> Date: Sat, 18 Feb 2023 16:02:17 -0500 Message-ID: <8735721ybv.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: EB5653144E X-Spam-Score: -2.43 X-Migadu-Spam-Score: -2.43 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: ueOfG/J0M4WX Hi Maxim, Maxim Cournoyer writes: > * gnu/packages/patches/icecat-reproducible-langpacks.patch: New file. > * gnu/local.mk (dist_patch_DATA): Register. it. > * gnu/packages/gnuzilla.scm (icecat-source): Apply it. Instead of adding this patch in Guix, let's make the change in upstream IceCat. Among other things, adding a 'patches' field to 'icecat-source' has the unfortunate consequence of forcing an additional 'patch-and-repack' phase during the build, which unpacks the entire multigigabyte source code, applies the patch, and repacks it all again. Would you like to submit a commit to the gnuzilla repo that simply adds the 'icecat-reproducible-langpacks.patch' file to the data/patches/ directory? I guess the file names in the patch also need a component added to the front (e.g. "a/" and "b/"). If you don't want to do it, I'll do it. In any case, it should be removed from this series of commits for Guix. Does that make sense? Regards, Mark