From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id AP2bL/pTJGVs8QAA9RJhRA:P1 (envelope-from ) for ; Mon, 09 Oct 2023 21:26:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id AP2bL/pTJGVs8QAA9RJhRA (envelope-from ) for ; Mon, 09 Oct 2023 21:26:50 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 72DE96DDFF for ; Mon, 9 Oct 2023 21:26:50 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=HVPpjcPT; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696879610; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xXFFXlIKOkulHhZpxp1TpGmq2HRPELf7nbmUgX7Ll/U=; b=eCFl3vSOWZxzBYmWuVOqZwwzBWopVlIMYrU4ibnu+O5l5NL3RTe+T77VxCEH9NuT2Tnwh/ zfTSmes2IbLI+ZWIc/R/Y7U1JQBmj50BwVCTK2UgWqt0G4geTj5LzVbuc/X1HCEpO25mTn EMrr/fIwqOXXkEbd5fzYdJl22SINgk+VgxCflI15XwtbZb6lXU9pWsG7KzJ3ZOs32CdBky E/0WQQxyVCjS4/7QMUZOTdVgsEG74/a0G+C/yUeiZYR1+L2cANUzHgLizyaVxBrMUQt/XV twJTS/GVpfbA/mrsywqz5kuNGcLPNEwHKzgmR0+H9j1LgRs662FzYdW3JKGmAA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696879610; a=rsa-sha256; cv=none; b=P3yAQsi54wCHYrz8uAzqj/IeJYwYciY0S+tZw1Jowm/foJIhdPpvI3o1vtPcNYoQ+S/g3E D4uECmJGqufNbgp3uVenHvzHiYfG5Ul5t5JpjmOAvvlDLkk/Xv3XbJuphs1WNrsbidT4bJ CfdymqTiIKNRPz2AD1CyBBelFW0WC5/Vfp74NCmUMRMS7iVY9Id0V9zma2VYKHai+8sB8w CD+UAyOAjztPSCnFkn/SERY6+VdbzEJApSbn2U/loGvoPapiVnSGgIS4/75NoDNrFAbBgB +gqAHcwqoj+aMIVNNelwXqPAsGcphHckXmpb2hzLPrpEckdrnwuWQ4wJKpO+qQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=HVPpjcPT; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qpvtr-0004tc-U1; Mon, 09 Oct 2023 15:26:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpvtp-0004tP-V5 for bug-guix@gnu.org; Mon, 09 Oct 2023 15:26:41 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qpvtp-0008LY-NG for bug-guix@gnu.org; Mon, 09 Oct 2023 15:26:41 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qpvuA-0000oa-3M for bug-guix@gnu.org; Mon, 09 Oct 2023 15:27:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#65924: git searches coreutils and util-linux commands in PATH Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 09 Oct 2023 19:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65924 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Liliana Marie Prikler Cc: 65924@debbugs.gnu.org Received: via spool by 65924-submit@debbugs.gnu.org id=B65924.16968795883077 (code B ref 65924); Mon, 09 Oct 2023 19:27:02 +0000 Received: (at 65924) by debbugs.gnu.org; 9 Oct 2023 19:26:28 +0000 Received: from localhost ([127.0.0.1]:33204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpvtc-0000nX-0w for submit@debbugs.gnu.org; Mon, 09 Oct 2023 15:26:28 -0400 Received: from mail-vs1-xe29.google.com ([2607:f8b0:4864:20::e29]:48385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpvtV-0000n9-0S for 65924@debbugs.gnu.org; Mon, 09 Oct 2023 15:26:26 -0400 Received: by mail-vs1-xe29.google.com with SMTP id ada2fe7eead31-45290cda80aso1655113137.1 for <65924@debbugs.gnu.org>; Mon, 09 Oct 2023 12:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696879554; x=1697484354; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xXFFXlIKOkulHhZpxp1TpGmq2HRPELf7nbmUgX7Ll/U=; b=HVPpjcPT1+F6quGupkrCgDdZhg+PjD4L0BMViRPK/cB4+uaw3TO/V8Bp6+AI9WxE17 Z+baHGEjWuOBc4wXltIHf8xElNMwB1wWZkspMcDykjNibRsHvIl3SjHYRs4JSnOzigMP CQNpTHHIxUIrbAvLTLmkN7dniEA+KhVJDmfib3zauK1LmzjN2sEhqrIoFB1ws1JpFuyd 8EtSBFk1RcGcGxR52rkiLqEOVvz94MDeicIDMxX4l9eg4ZGDJNJHtyTsyL62LzPPnaFj PF/o4gHkkxeNOn36ME+/8NkEYCLf8AQ8Exh8PW8lkXxOEpBVqjGaoQ4Use7tzjvyGmEv cbIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696879554; x=1697484354; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xXFFXlIKOkulHhZpxp1TpGmq2HRPELf7nbmUgX7Ll/U=; b=ryMjZuejpswWsvpA7/lTAuK+RTeFWKp6D3RcvYgT5ePMkyt9/xknrCBIgmeyLzpUYt 2e+pVrRoA8WsPv2YKDVA6TrZ46TV2sOoIHVOS+rtNUxWreZD6D1mnaOa+fjrs/gHEN9P Cq1w30LbUPFjzFN9XVAdFyhcgts9bXaAftBk8bO16KdvSw9SpJvG1d8x92Wl1d1+wYfL FHWrHtLNBeUmuusKijS4tmEq3aI/61HMqpDaBogDGq2Mp48zxd4Rp6rgjSAHnJey+jAQ YR81EmcIqSzVDKrgkEIV1oW0bF8KeTIzwulis4fnwQs4safhGyvahTcUSuF33MsHqdmm 303A== X-Gm-Message-State: AOJu0YyD8yIhxxITe9VszIkBrwMHq9K9ainr4YvncZtR+TFc6d/3ZQdi OGJnFXoV8Jpkf8Dxndj2YlsUYTECRbw= X-Google-Smtp-Source: AGHT+IEuyBFdmE4zA+6ZDLPVDWYpI4rlM/VvJIZvjBDGkxaYMbcKXFQzzwRvmE1ey+DG5Qo01o/2vA== X-Received: by 2002:a67:ad0f:0:b0:452:6fc1:a3e5 with SMTP id t15-20020a67ad0f000000b004526fc1a3e5mr11293307vsl.1.1696879554336; Mon, 09 Oct 2023 12:25:54 -0700 (PDT) Received: from hurd (dsl-10-149-16.b2b2c.ca. [72.10.149.16]) by smtp.gmail.com with ESMTPSA id c28-20020a05620a135c00b0076f21383b6csm3744460qkl.112.2023.10.09.12.25.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 12:25:53 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: (Liliana Marie Prikler's message of "Mon, 09 Oct 2023 20:33:38 +0200") References: <9f9ecf37a04d6a3d788d247d8fb46f7bd6fabad5.1696734901.git.maxim.cournoyer@gmail.com> <442bb34f6ba81b7134c6cbf06d0045debc42bf68.camel@gmail.com> <87il7fdggi.fsf_-_@gmail.com> <1a219a891192b526d3e28fea8ce350c0fd5e3b53.camel@gmail.com> <87pm1nac8d.fsf@gmail.com> Date: Mon, 09 Oct 2023 15:25:53 -0400 Message-ID: <8734yja98e.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -4.54 X-Spam-Score: -4.54 X-Migadu-Queue-Id: 72DE96DDFF X-TUID: U2PsU+cR5sj1 Hi Liliana, Liliana Marie Prikler writes: > Am Montag, dem 09.10.2023 um 14:21 -0400 schrieb Maxim Cournoyer: >> Hello, >>=20 >> Liliana Marie Prikler writes: >>=20 >> > [...] >> > If you need me to reduce it to four letters, yes, LGTM. >>=20 >> Explicit is better than implicit.=C2=A0 I've been thinking to document >> this in our contributing section; e.g. a reviewed commit must have >> the 'LGTM' from the reviewer.=C2=A0 If a series is LGTM, it needs to be >> implicitly mentioned with 'this series LGTM'.=C2=A0 That may sound silly, >> but I think it'd simplify reviewer/submitters interactions. > s/implicitly/explicitly/? Explicit, indeed. > I don't necessarily agree, but it's not a hard disagree either. I'll > try to keep that in mind at least when reviewing your patches to not > cause confusion. OK. One place where this becomes more important is when the send-email cc hook includes people partially to a series. A LGTM on a single message in this case could be misinterpreted for the whole series. It's best to document the expectations and codify these often used signals, in my opinion. --=20 Thanks, Maxim