From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id EMPeKt84WGds4QAAqHPOHw:P1 (envelope-from ) for ; Tue, 10 Dec 2024 12:49:35 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id EMPeKt84WGds4QAAqHPOHw (envelope-from ) for ; Tue, 10 Dec 2024 13:49:35 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="k9K0324/"; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=QjqqP4b2; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1733834975; a=rsa-sha256; cv=none; b=l/8XS0c3xtVtPjINLI9asZKnXBnGXt9cXwoRePfARreRPl44jlQYW6DXDCSxiCXqb/Csxr XKHSzGsKnyd83TaSj2N/pS53OTcxTnldDq4rQ0K2fbSKGzga1NqP/lDvHKa8VSNYdPCMCX OcC/yQfb8FMG3ZaEOsKZBLiEyZ11PYQMD0AfENZp1ESr0aE88LYXWqN9AZKsbAggJFJyV9 HEu5B4LMC3n7aWeuJ+y/BeLrxRCh6k4U1FcxtTd2IwZhIPOgasBmFUQlB1I9dev3/s2jH3 3lW2jVJYGQIZqqzIUOuIq+vMSyNfaBYDvHsJqTthmF11UkZ5KCKsQx1Ut24ulA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="k9K0324/"; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=QjqqP4b2; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1733834975; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=IbzALTKrQvHJQPrWdn3OCFCmbiMNgxVyXJ8rPfYKYzg=; b=Sro/x07oBrA7mhLOl83hdfYq+MRAcI1eZNuqsSgPYXXgDaFj0muNyad0evqj3I8kPpKe6R +IqANtrgCJx7TVt/j2e2U7zsT0b5fcFK0sV2JcPV7aJ0tgpw8WlXI3AhftnAajOTWXsz8t FjiWdyDehR4qtA+DHj4B4Z6MLor1yK7OA8FyMb/xkTmfwfNZKJb8dXtkZvJ+rPv43CiL1b abqChFK1SBE8s/JkxtpWKg19Zb0hFUM1oz/LYRfo6mxd3D7vRNVwRRB0GjcPae8i+oxXT0 Hp7mrhe87tYZqIodrbLvHEP8qIM0B1QtQGPtaGmYSVfP1Eam+I3mvxNr5nDgFg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 413D67F2D2 for ; Tue, 10 Dec 2024 13:49:34 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tKzfl-0004La-Cv; Tue, 10 Dec 2024 07:49:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKzfj-0004L6-2x for bug-guix@gnu.org; Tue, 10 Dec 2024 07:49:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tKzfi-0005Hy-Hw for bug-guix@gnu.org; Tue, 10 Dec 2024 07:49:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=IbzALTKrQvHJQPrWdn3OCFCmbiMNgxVyXJ8rPfYKYzg=; b=k9K0324/TOSUPJt/THBs3lNHj/u75GmUPN1Nib13A3Y9uPoF2Fs+kDQcp9XIaOaiO8wTFROhkZmcPnrJiwvtFb75nWs2Gl6f7bRI1kWrmxfPO14YqoGypc5VmneIpY9Q/Aeq7IXM1kOzoXhl/DLpmYrALWMUqqO1/cPFxaXw2hne+DO2wDuvb5koEBc4aEBkkQqsDfKru8EdCQuVtolyvpFN9LbWXAph0eL/NK6vsE5Azqn9nCHM6Uif5Fmz5RPp8LMj6xphN6tFTGSdnoBPEJFakLWUgHZUBJ7iLkdPoXzIYqsQ9IUAHb3H7U8KXU3A+WDDRcbL3sCMO+ARL1IQ1Q==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tKzfh-0002RS-Up for bug-guix@gnu.org; Tue, 10 Dec 2024 07:49:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#73181: guix-daemon fails when invoking =?UTF-8?Q?=E2=80=98guix_?= =?UTF-8?Q?authenticate=E2=80=99?= on the Hurd Resent-From: Janneke Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 10 Dec 2024 12:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73181 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 73181@debbugs.gnu.org Received: via spool by 73181-submit@debbugs.gnu.org id=B73181.17338349089156 (code B ref 73181); Tue, 10 Dec 2024 12:49:01 +0000 Received: (at 73181) by debbugs.gnu.org; 10 Dec 2024 12:48:28 +0000 Received: from localhost ([127.0.0.1]:57271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKzf9-0002NX-0F for submit@debbugs.gnu.org; Tue, 10 Dec 2024 07:48:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKzf7-0002MR-0x for 73181@debbugs.gnu.org; Tue, 10 Dec 2024 07:48:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKzex-0005Ea-Q7; Tue, 10 Dec 2024 07:48:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=IbzALTKrQvHJQPrWdn3OCFCmbiMNgxVyXJ8rPfYKYzg=; b=QjqqP4b2yaJOpacPHQ9x 0IoAEWGfHjr4pzR7sSEqP0s1PWwoBBpj5ZIYr+8yOP9Fbljg8PFJiS+oV/FQrHlt4WZVzWd93Nx4w Wq3jwc11tDPBrZux+onpZhcFW0TM5efiBUR530tovvppasgztulVFEdorSgUf5w91Mk+Kh2htRGIe mQRInmcRZSVOZNhGXsrNcAwgh2AgdNNcPGKluqy7uoeQjq90uYkdkytWNM9Q9PbP3aQUHQVsjFX0C NylSslE5qbNvAGwodK/PP/ZqBl+kBXApJr2d8LFweLaCoW1wyPAoq0Gfp3lVQm+PXkUU6sytyR2RE sH3h1TZJHM9KYw==; From: Janneke Nieuwenhuizen In-Reply-To: <87plm0j700.fsf@inria.fr> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 10 Dec 2024 09:07:43 +0100") Organization: AvatarAcademy.nl References: <87o74u5hcy.fsf@inria.fr> <87a5ge5d94.fsf@gnu.org> <87h68snkzk.fsf@gnu.org> <874j4n5s02.fsf@inria.fr> <87ed3phqfm.fsf@gnu.org> <877c9hzsjy.fsf@inria.fr> <878qssbq9b.fsf@gnu.org> <87plm0j700.fsf@inria.fr> X-Url: http://AvatarAcademy.nl Date: Tue, 10 Dec 2024 13:47:49 +0100 Message-ID: <8734iv3dsa.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 413D67F2D2 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -8.56 X-Spam-Score: -8.56 X-TUID: oDheo/8aaf8l --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: Hey Ludo, > > Janneke Nieuwenhuizen skribis: > >> So, the problem is that our patch doesrn't disable the warnings after al= l. >> The guile-launcher has >> >> guile-launcher.c: >> >> #if defined __GNU__ >> /* XXX: On 32-bit GNU/Hurd (i586-gnu), libgc emits "Repeated allocatio= n" >> warnings that are annoying and interfere with communications between >> 'guix-daemon' and 'guix authenticate': >> . Silence them. */ >> std::cerr << "silencing libgc warnings" << std::endl; >> GC_set_warn_proc (no_warnings); >> #endif >> .. >> scm_boot_guile (argc, argv, inner_main, 0); >> >> >> and then guile's gc.c just undoes that > > D=E2=80=99oh! Good catch! Yeah :-/ > You=E2=80=99ll hate me for suggesting that :-) You know better than that :) > but what if in =E2=80=98guile-launcher.c=E2=80=99 > we moved the =E2=80=98GC_set_warn_proc=E2=80=99 call to =E2=80=98inner_ma= in=E2=80=99? I believe in that > case it would have the desired effect, right? Ah, I cannot believe I missed that -- I read "inner_main" and thought it would call guile's inner main. > That would avoid patching Guile wholesale. > > Anyhow, kudos for the tricky and probably lengthy debugging session! Yeah, so I'm proposing the attached patch -- tested and works for me -- well, apart from having to set overload-threshold. I asked on #hurd and hopefully one of Damien's patch series will take care of that; I'll try that some time soon. Greetings, Janneke --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-guile-Silence-GC-warnings-on-the-Hurd-part-II.patch >From 832ef198f7e423e0fdff7fe7c5558ff13d1f20c1 Mon Sep 17 00:00:00 2001 Message-ID: <832ef198f7e423e0fdff7fe7c5558ff13d1f20c1.1733834506.git.janneke@gnu.org> From: Janneke Nieuwenhuizen Date: Tue, 10 Dec 2024 10:16:05 +0100 Subject: [PATCH] guile: Silence GC warnings on the Hurd, part II. This is a follow-up to commit b0416b8503e38746717a2d1167f9d1410634981e guile: Silence GC warnings on the Hurd. This should work around , resurrecting offloading to the Hurd. * gnu/packages/aux-files/guile-launcher.c: (main)[__GNU__]: Move code to silence warnings to... (inner_main)[__GNU__]: ...here. Change-Id: I408201f7f4072c9a33837e6020ac63270b33702e --- gnu/packages/aux-files/guile-launcher.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/gnu/packages/aux-files/guile-launcher.c b/gnu/packages/aux-files/guile-launcher.c index bc7fa21b63..c205477f64 100644 --- a/gnu/packages/aux-files/guile-launcher.c +++ b/gnu/packages/aux-files/guile-launcher.c @@ -43,6 +43,14 @@ static const char *load_path, *load_compiled_path; static void inner_main (void *unused, int argc, char **argv) { +#if defined __GNU__ + /* XXX: On 32-bit GNU/Hurd (i586-gnu), libgc emits "Repeated allocation" + warnings that are annoying and interfere with communications between + 'guix-daemon' and 'guix authenticate': + . Silence them. */ + GC_set_warn_proc (no_warnings); +#endif + if (load_path != NULL) { setenv ("GUILE_LOAD_PATH", load_path, 1); @@ -82,14 +90,6 @@ main (int argc, char **argv) which is always preferable over the C locale. */ setlocale (LC_ALL, "en_US.utf8"); -#if defined __GNU__ - /* XXX: On 32-bit GNU/Hurd (i586-gnu), libgc emits "Repeated allocation" - warnings that are annoying and interfere with communications between - 'guix-daemon' and 'guix authenticate': - . Silence them. */ - GC_set_warn_proc (no_warnings); -#endif - const char *str; str = getenv ("GUILE_LOAD_PATH"); load_path = str != NULL ? strdup (str) : NULL; base-commit: 93e1586116f39a30ba1fcb67bd839a43533dfaf4 -- 2.46.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 Janneke Nieuwenhuizen | GNU LilyPond https://LilyPond.org Freelance IT https://www.JoyOfSource.com | Avatar=C2=AE https://AvatarAcade= my.com --=-=-=--