From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#25101: [PATCH 1/2] gnu: Add hpaio-enabled sane-backends variant.
Date: Mon, 05 Dec 2016 21:48:36 +0100
Message-ID: <871sxm14rf.fsf@gnu.org>
References: <20161203194113.6456663e@scratchpost.org>
	<20161204040037.21758-1-ajpatter@uwaterloo.ca>
	<20161204040037.21758-2-ajpatter@uwaterloo.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50469)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cE0C9-0002HY-Ek
	for bug-guix@gnu.org; Mon, 05 Dec 2016 15:49:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cE0C6-0001Xn-E7
	for bug-guix@gnu.org; Mon, 05 Dec 2016 15:49:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:41923)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cE0C6-0001XD-Bk
	for bug-guix@gnu.org; Mon, 05 Dec 2016 15:49:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cE0C6-0002a3-3S
	for bug-guix@gnu.org; Mon, 05 Dec 2016 15:49:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.25101.B25101.14809709299901@debbugs.gnu.org>
In-Reply-To: <20161204040037.21758-2-ajpatter@uwaterloo.ca> (Andy Patterson's
	message of "Sat, 3 Dec 2016 23:00:36 -0500")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Andy Patterson <ajpatter@uwaterloo.ca>
Cc: 25101@debbugs.gnu.org

Andy Patterson <ajpatter@uwaterloo.ca> skribis:

> * gnu/packages/scanner.scm (sane-backends+hpaio): New variable.

[...]

> +(define-public sane-backends+hpaio

Could you add a comment and a synopsis explaining what=E2=80=99s this is?

> +  (package
> +    (inherit sane-backends)
> +    (name "sane-backends+hpaio")
> +    (inputs
> +     `(("hplip" ,(@ (gnu packages cups) hplip))
> +       ,@(package-inputs sane-backends)))

The closure size of this is 290 MiB whereas it=E2=80=99s 87 MiB for
=E2=80=98sane-backends=E2=80=99.  I suppose that=E2=80=99s the reason to ke=
ep=E2=80=99em separated?

Otherwise LGTM, thanks!

Ludo=E2=80=99.