From: ludo@gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke@fastmail.com>
Cc: 29363@debbugs.gnu.org, Rutger Helling <rhelling@mykolab.com>
Subject: bug#29363: Single test failure building Guix
Date: Tue, 21 Nov 2017 08:47:52 +0100 [thread overview]
Message-ID: <871sksoyxj.fsf@gnu.org> (raw)
In-Reply-To: <87a7zgtquv.fsf@fastmail.com> (Marius Bakke's message of "Tue, 21 Nov 2017 01:31:04 +0100")
Hello,
Marius Bakke <mbakke@fastmail.com> skribis:
> Rutger Helling <rhelling@mykolab.com> writes:
>
>> when building Guix with 'guix build guix' I keep running into a single
>> test failure. I've attached the test-suite.log.
>
> Is this a Btrfs system by any chance, possibly on an SSD?
>
>> test-name: dead path can be explicitly collected
>> location: /tmp/guix-build-guix-0.13.0-10.0b4c385.drv-0/source/tests/store.scm:178
>> source:
>> + (test-assert
>> + "dead path can be explicitly collected"
>> + (let ((p (add-text-to-store
>> + %store
>> + "random-text"
>> + (random-text)
>> + '())))
>> + (let-values
>> + (((paths freed) (delete-paths %store (list p))))
>> + (and (equal? paths (list p))
>> + (> freed 0)
>> + (not (file-exists? p))))))
>> actual-value: #f
>> result: FAIL
>
> I can reproduce this error on two different systems that have
> Btrfs+LUKS+SSD, and the problem is that freed == 0.
If you comment out (> freed 0), does the test pass?
> I suspect it's related to Btrfs' "lazy" reporting of disk space, but
> haven't dug very far.
>
> Until we figure out what's going on, I suggest applying the patch
> below. Can you confirm that it works on your system?
>
> From bdc7b5310111e21801529ea57e290f6eb72ac6ed Mon Sep 17 00:00:00 2001
> From: Marius Bakke <mbakke@fastmail.com>
> Date: Tue, 21 Nov 2017 00:27:08 +0100
> Subject: [PATCH] gnu: guix: Disable test that fails on Btrfs.
>
> Works around <https://bugs.gnu.org/29363>.
> Reported by Rutger Helling <rhelling@mykolab.com>.
>
> * gnu/packages/package-management.scm (guix)[arguments]: Rename
> 'disable-container-tests' phase to 'disable-failing-tests' and add substitution
> to disable "dead path can be explicitly collected" test.
Alternately, we could comment out (> freed 0) if that’s enough, with a
comment explaining why, and do “make update-guix-package”. That way
we’d avoid the extra build phase.
WDYT?
Thanks for finding out the root cause!
Ludo’.
next prev parent reply other threads:[~2017-11-21 7:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 10:08 bug#29363: Single test failure building Guix Rutger Helling
2017-11-20 15:55 ` Ludovic Courtès
2017-11-20 17:49 ` Rutger Helling
2017-11-21 0:31 ` Marius Bakke
2017-11-21 7:31 ` Rutger Helling
2017-11-21 7:47 ` Ludovic Courtès [this message]
2017-11-21 9:10 ` Rutger Helling
2017-11-21 12:53 ` Ludovic Courtès
2017-11-21 14:50 ` Rutger Helling
2017-11-21 21:11 ` Marius Bakke
2017-11-21 21:39 ` Marius Bakke
2017-11-22 15:55 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sksoyxj.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=29363@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
--cc=rhelling@mykolab.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).