From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: bug#30006: bzip2 does not provide libbz2.so Date: Fri, 23 Mar 2018 13:38:24 +0100 Message-ID: <871sgbklvj.fsf@fastmail.com> References: <87incft8tf.fsf@gnu.org> <877eq3knk0.fsf@fastmail.com> <718583be2617e43743e8ee40397bb0b4@tobias.gr> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezLyL-0000Nh-P3 for bug-guix@gnu.org; Fri, 23 Mar 2018 08:39:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezLyI-00042c-JJ for bug-guix@gnu.org; Fri, 23 Mar 2018 08:39:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:40896) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezLyI-00042D-FX for bug-guix@gnu.org; Fri, 23 Mar 2018 08:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ezLyI-0002aR-3a for bug-guix@gnu.org; Fri, 23 Mar 2018 08:39:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <718583be2617e43743e8ee40397bb0b4@tobias.gr> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Tobias Geerinckx-Rice Cc: 30006@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice writes: > Marius, > > On 2018-03-23 13:02, Marius Bakke wrote: >> diff --git a/gnu/packages/compression.scm=20 >> b/gnu/packages/compression.scm >> index b158feac4..fd111e579 100644 >> --- a/gnu/packages/compression.scm >> +++ b/gnu/packages/compression.scm >> @@ -272,6 +272,9 @@ file; as a result, it is often used in conjunction=20 >> with \"tar\", resulting in >> (lambda* (#:key outputs #:allow-other-keys) >> (let* ((out (assoc-ref outputs "out")) >> (libdir (string-append out "/lib"))) >> + ;; The Make target above does not create "libbz2.so",=20 >> only >> + ;; the versioned libs, so we have to create it=20 >> ourselves. >> + (symlink "libbz2.so.1.0" "libbz2.so") > > How about symlinking to (string-append ... version) directly? > Seems more robust & worked fine when I tried it, I think.=E2=84=A2 That makes sense. I just wanted to stay close to the typical Autotools way of creating these links, where libfoo.so points to libfoo.so.1 which points to libfoo.so.1.2. I'll change to (version-major+minor ...) instead, in the off chance that bzip2 ever gets a new version. Side note: "copy-file" (and thus "install-file") actually dereferences symlinks, so in the end you get three copies of the same library. Is there an alternative to "copy-file" that preserves soft links? Not that it matters in practice due to deduplication, but still... --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlq09UAACgkQoqBt8qM6 VPoHUgf/S4NBOQSAa/58Xy3ZZDnoXwF5WiAnwEbbp4LSIOZWkhuPIwu7UwodfYua 5xJCQhM0lFVsKddJGqJOR3JHsmN1P2BQgWGlMExZK9TpAmqW1UhJ2b7o55iO21rs pYqwicg4CixA3U8/Sh0Vj2zRGVcjxPHwwb0bCVl2Zxd45Of3xGEbR4SJWgRWwNlk 53pVj/B8sqwHlAtXfSTwmf8WDB2v8ROD6YkWUtgKJoAK9kEie+9681L61UYORCO/ P9O7rwIBwADcOwfir9EyStVokRIyl3eBnX/h65Z6z/1DdzM/eTKqRkLUvb6I6/sY YIONs1+XV6jOM7dlFe6eKZEtAiliXA== =K9UA -----END PGP SIGNATURE----- --=-=-=--