From: Guillaume Le Vaillant <glv@posteo.net>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 45017@debbugs.gnu.org
Subject: bug#45017: asdf-build-system packages have priority over user ones
Date: Sat, 05 Dec 2020 10:42:59 +0100 [thread overview]
Message-ID: <871rg4lhb0.fsf@yamatai> (raw)
In-Reply-To: <877dpwsm1h.fsf@ambrevar.xyz>
[-- Attachment #1: Type: text/plain, Size: 1774 bytes --]
Pierre Neidhardt <mail@ambrevar.xyz> skribis:
> A few comments:
>
>> @@ -603,7 +603,8 @@ statistical profiler, a code coverage tool, and many other extensions.")
>> "0x4bjx6cxsjvxyagijhlvmc7jkyxifdvz5q5zvz37028va65243c")
>> (_ "15l7cfa4a7jkfwdzsfm4q3n22jnb57imxahpql3h77xin57v1gbz"))))))))
>> (native-inputs
>> - `(("m4" ,m4)))
>> + `(("cl-asdf" ,cl-asdf)
>> + ("m4" ,m4)))
>> (arguments
>> `(#:tests? #f ;no 'check' target
>> #:modules ((ice-9 match)
>> @@ -615,6 +616,17 @@ statistical profiler, a code coverage tool, and many other extensions.")
>> (add-after 'unpack 'unpack-image
>> (lambda* (#:key inputs #:allow-other-keys)
>> (invoke "tar" "xzvf" (assoc-ref inputs "ccl-bootstrap"))))
>> + (add-after 'unpack 'replace-asdf
>> + ;; Use system ASDF instead of bundled one.
>> + (lambda* (#:key inputs outputs #:allow-other-keys)
>> + (let* ((cl-asdf (assoc-ref inputs "cl-asdf"))
>> + (guix-asdf (string-append
>> + cl-asdf
>> + "/share/common-lisp/source/asdf/asdf.lisp"))
>> + (out (string-append (assoc-ref outputs "out")))
>
> "out" is unused. By the way, the same "out" is unused in SBCL.
>
Indeed, I'll fix that.
>> + (contrib-asdf "tools/asdf.lisp"))
>> + (delete-file contrib-asdf)
>
> I think you don't need to delete the file, copy-file should overwrite.
> That's what SBCL does.
>
> Same with CLISP.
Actually, for CCL and Clisp, I get a "In procedure copy-file: Permission
denied" error if I don't delete the current file before copying the new
one.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
next prev parent reply other threads:[~2020-12-05 9:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 9:42 bug#45017: asdf-build-system packages have priority over user ones Pierre Neidhardt
2020-12-03 12:04 ` Guillaume Le Vaillant
2020-12-03 12:40 ` Pierre Neidhardt
2020-12-03 14:29 ` Guillaume Le Vaillant
2020-12-04 8:51 ` Pierre Neidhardt
2020-12-04 9:12 ` Guillaume Le Vaillant
2020-12-04 12:46 ` Pierre Neidhardt
2020-12-04 13:53 ` Guillaume Le Vaillant
2020-12-04 17:30 ` Guillaume Le Vaillant
2020-12-05 8:18 ` Pierre Neidhardt
2020-12-05 9:42 ` Guillaume Le Vaillant [this message]
2020-12-05 9:17 ` Pierre Neidhardt
2020-12-05 10:03 ` Guillaume Le Vaillant
2020-12-05 10:52 ` Guillaume Le Vaillant
2020-12-05 14:42 ` Pierre Neidhardt
2020-12-05 15:17 ` Guillaume Le Vaillant
2020-12-05 15:19 ` Pierre Neidhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rg4lhb0.fsf@yamatai \
--to=glv@posteo.net \
--cc=45017@debbugs.gnu.org \
--cc=mail@ambrevar.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).