From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8Kj7Ad9DZmDUDAAAgWs5BA (envelope-from ) for ; Fri, 02 Apr 2021 00:06:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id OIJ3N95DZmCZZQAA1q6Kng (envelope-from ) for ; Thu, 01 Apr 2021 22:06:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 37D1B1A0F7 for ; Fri, 2 Apr 2021 00:06:22 +0200 (CEST) Received: from localhost ([::1]:38826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lS5SG-0006J1-HI for larch@yhetil.org; Thu, 01 Apr 2021 18:06:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lS5Ry-0006Iu-Kr for bug-guix@gnu.org; Thu, 01 Apr 2021 18:06:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47267) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lS5Ry-00087d-5F for bug-guix@gnu.org; Thu, 01 Apr 2021 18:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lS5Rx-00056l-TE for bug-guix@gnu.org; Thu, 01 Apr 2021 18:06:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#47541: libvirt does not work Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 01 Apr 2021 22:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47541 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: qblade Received: via spool by 47541-submit@debbugs.gnu.org id=B47541.161731473319596 (code B ref 47541); Thu, 01 Apr 2021 22:06:01 +0000 Received: (at 47541) by debbugs.gnu.org; 1 Apr 2021 22:05:33 +0000 Received: from localhost ([127.0.0.1]:58813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lS5RV-000560-Gs for submit@debbugs.gnu.org; Thu, 01 Apr 2021 18:05:33 -0400 Received: from mout.gmx.net ([212.227.17.22]:55995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lS5RU-00055o-0b for 47541@debbugs.gnu.org; Thu, 01 Apr 2021 18:05:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1617314724; bh=guYauL5UlYI4Bvwfx0PFc3PokP00OsGQ6orBMWQkHAY=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=MVD19mkECZtjD988EIhTuZ9naOsmZCMv5mgHHeLVCWqQ0CxuGdr3CcQR0JdkB3rXT 58SmlQwQAiRF7P3Gxc4gZkB9QNHcpsuMFMR+ucNwTxfxugc7ejLpIvZZlGrE6i5J0a LpVIMnY/aAXcYP/UuIXcigBs4u/lXJQOhVScuCLg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MRmfi-1l3JJh48h0-00TB3E; Fri, 02 Apr 2021 00:05:24 +0200 References: User-agent: mu4e 1.4.15; emacs 27.2 From: Pierre Langlois In-reply-to: Date: Thu, 01 Apr 2021 23:05:19 +0100 Message-ID: <871rbtwti8.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:k2qJVxXOIEP+5bXB/AI8vJCRINwmxwINyQ/IQLl5eHazJ91GMI4 vg5b0sdZVYcZLSO9VkaMK1YHADs33up2uGiz44Bw75Xu0D1t1D0VpeWxpKKSzhaycnlpviy RufMwz8SaQ01FElLQU3fodJYzs8CKzXNF9JKtiCVqJOADRBRopSanKa9/Gab9TjKOWy9i3F 8dlF7MPj4Rx0GJabtOysA== X-UI-Out-Filterresults: notjunk:1;V03:K0:Gk34TAkc+N8=:XA7t2PPqRzvD2ronVg/xf6 nq+UzrOqXQRhKD/536qazEUlzLjtpfP7NDuuMv9y15mCQCeQ6o0uyIdJQTxH8UepC4MesZEAi I4p7Q9vC3wfzNIsWX/8vLPHnYrC72MHWkGtj/qGIxgEk33FUrmD/oRQBtEQJvZr0oHvle1VlR CbynjVQvaDA3U732I7k8yJ2c8feadeK9jOmsW9ktFQ5xW9ltplVtNNKAHWLJNt+0Xp9A9vPc3 0uFDCk8IL3PZz4tJG5/bWTSQfFZT8gAJFJRSkpAOAej2WaUitUVGoFMUnRWZ0DQ4jcGCs4P7y v4CHROXB+xHw24lCnTe4bO4XiFfWez9hziEgU2SIVUDJYQ5I4qmDiZZ96zn4f+myYMQ/9TIvG CtZ9uPTGrjlWaRqSb9fomRpKfuiQLSyvR30s7gn/3LVjDFc8NIaTOhCJFFUBcYTZ09/NsiRDD bc62xUhU7NdTtaQuiVgCn85eUaCfcUL9E9R78rxaPIfZupmxMWkgYDG1P9S8pLXJT+Nl3kFQn Z5/ZZRiW+GNYImyanlGXXSX3Ruzp66M9El03jtV0kOhnRaRFHNQtX1KSoUtJiwFNEQaVrd+I9 B7jZgrcf/eIosB4LMlgqllRy1diOmgQG7jkT9WWF8sLcqY2Qr8mmas8QYd/DmzS6FAF0W3/cF lxHKjSHplvmkW12cDUUyni7s8KevQabPKtSV4H/5XI+PdtCRo08lzSmWWFwmC0hiqbqaRo/HH bqT7IRqEC3Dv4DJeN4F7ioMLx//nfFto6DT8VQGjGIMPej9l7AhevaF1v7eJW1EawuAZw7GLA hC0UnnVeWs0+V+jpmTmd/4IdX7y/phEMfce4WBzAQ/41q8MrJHxwUTr5nmDu0jqp13iePTAEq 6GgIMy9O1mVRVY4WTBix6zIL18bbn/ZqpGmoQ1iEl4AAoomZ2tI2dsujZ7z6/P2BDdKvwGrDL dMFYBOE8KolYowlYZLgXOZly8hCoFvK5GSH/b4O/6RH5xTBqC/7zivkBY+bwrf4WdpyfBLJLq a7OtuezNCYy5EBEtLAjvFO4zAmJYCdt5GTww18alIp6UDDQmhEq82eb61Wvcufie7o9yUsDcp AFMltR644s5D3QPCrNvgu4uro1RbCfPr0l6ggWZTaINSFoHPjtEg2jXgAHcnSL1flcJF7ElBj 47MHtc7X/UVLEHzDhqDi0p1H8lcUosbVK7tCcns/UQduoZi/twRFoOMmSaSnHLZjnzUNym1ho 12mYvr0Y4kgz0sni2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 47541@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617314782; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=AcU/3dhrV7XWxTXwwUcQxNTisiXHCVhs60JQEFANKFQ=; b=WQH5X408KL7ckzlOe8AF1B8smQcZ4+9jWtG4sDFiyproAZuvtxeLmVKlFIXJudnt9yThVu SqCcfhahEx2nUta5/r+f35BR8EbZEJJgXbxwAxqY2zOnOq1KZzYKcKsj0zn10wWzlrTP+H EitrbZgQiXxdtz6OxwTDoj/Bo3SkgNM4zUEI4/jBsNixy+oip5hxb91Golr0X2eEMMU3Jh +hJo890jqOcnuu+l7ml6iRX0RrB3fYqBfGVzuxFaQdDzF1YO/rC7w3C7oT3iRYukrC7XkF dxsjtoB367dpNrJZEYRrPHPcIzKA5fgiFDq2OxK7U7k+INgZi4id+acHMxX5YQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617314782; a=rsa-sha256; cv=none; b=VR+NhqVyli8z9lTQNaLVIQLp/ZBn86uibcGQXAuZXU4PFvK0/1mRPqJL+2O7LFJaKmyj5N vUlQb8nEjUYBbYU1kZVbv0LZX1pLvNXrjCRHfa80fWqnQzaJYNiQda4Ka49qh9f6zPL26y WSkAAptyoxlCux7fopKOckx6fgynqAwIfuASqRS0DXKs0aM3h3RuozII35ppZjkALpOC42 9un5l79JbzZHWVeDzj/bz9JBybk7UhAGwWWHX3Aaj95ok+NjRqny3uk8fmFI7BWtS4P9wT 2cS4+riwzSwG9FDFWHfwL8oLWzkdZ10KeepiBOLGhIMn1rMsEpF4tBIemneO3A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b=MVD19mkE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -3.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b=MVD19mkE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 37D1B1A0F7 X-Spam-Score: -3.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: v7c6iYNHybAI --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello! qblade via Bug reports for GNU Guix writes: > after this commit, the `virsh` does not work corrent: > > ``` > commit 383b02a370252c08eb1d43ac94d659c1d3993a35 > Author: Pierre Langlois > Date: Sat Mar 20 21:31:22 2021 +0000 > > gnu: libvirt: Update to 7.1.0. > > * gnu/packages/virtualization.scm (libvirt): Update to 7.1.0. > [source]: Remove libvirt-create-machine-cgroup.patch, add > libvirt-do-not-create-var-dirs.patch. > [build-system]: Switch to meson-build-system. > [arguments]: Use meson-0.55. Adapt #:configure-flags for meson, ther= e is no > need for --docdir anymore. Remove fix-BOURNE_SHELL-definition phase.= Add > fix-sysconfdir-and-localstatedir phase. Adapt disable-broken-tests t= o meson. > [native-inputs]: Add python-docutils and rpcsvc-proto. > * gnu/packages/patches/libvirt-create-machine-cgroup.patch: Delete. > * gnu/packages/patches/libvirt-do-not-create-var-dirs.patch: New patc= h. > * gnu/local.mk (dist_patch_DATA): Add new patch, remove the other. > > Signed-off-by: Ludovic Court=C3=A8s > > ``` Ooh no! Sorry for the breakage! > > Command to reproduce wrong: > ``` > # This is wrong: > # After commit > luhux@thinkpad-x230 ~ [date: Thu 01 Apr 2021 09:16:37 PM HKT] > $ GUIX_BUILD_OPTIONS=3D"" guix time-machine --commit=3D383b02a370252c08eb= 1d43ac94d659c1d3993a35 -c 8 -M 8 -- environment --ad-hoc libvirt -- virsh c= onnect > qemu:///system > error: failed to connect to the hypervisor > error: Failed to connect socket to 'var/run/libvirt/libvirt-sock': No suc= h file or directory > > > ``` > > It uses the wrong path to connect to libvirtd of the current system. I see, I tried to cover all cases where libvirt would not use the correct /var and /etc but clearly missed some :-/. > > Command to reproduce corrent: > ``` > # This is corrent: > # Before commit > > > luhux@thinkpad-x230 ~ [date: Thu 01 Apr 2021 09:16:32 PM HKT] > $ GUIX_BUILD_OPTIONS=3D"" guix time-machine --commit=3Dc536f0b21771491798= 8d2f412999d978c2f2f495 -c 8 -M 8 -- environment --ad-hoc libvirt -- virsh c= onnect qemu:///system > error: failed to connect to the hypervisor > error: Failed to connect socket to '/var/run/libvirt/libvirt-sock': No su= ch file or directory > ``` > > I use strace to create verbose log: > > > ``` > luhux@thinkpad-x230 ~ [date: Thu 01 Apr 2021 09:22:18 PM HKT] > $ GUIX_BUILD_OPTIONS=3D"" guix time-machine --commit=3D383b02a370252c08eb= 1d43ac94d659c1d3993a35 -c 8 -M 8 -- environment --ad-hoc libvirt strace -- = strace -o strace.log -- virsh connect qemu:///system > error: failed to connect to the hypervisor > error: Failed to connect socket to 'var/run/libvirt/libvirt-sock': No suc= h file or directory > > > ``` > > strace shows that it did use the wrong path: > > ``` > 1056 access("var/run/libvirt/virtqemud-sock", F_OK) =3D -1 ENOENT (No = such file or directory) > 1057 access("var/run/libvirt/libvirt-sock", F_OK) =3D -1 ENOENT (No su= ch file or directory) > ``` > > full strace log is in the attachment > | | | > V V V > > > My guess is that the patch in the commit caused this problem, but I have = no ability to fix it. > Please fix it I'll see if I can look into it at the weekend, although I'm not sure I'll be able to get to it, so in the meantime we should probably just revert the updates. Thanks a lot for investigating though, I think we ought to write a system test that uses virsh to connect if that's possible. All that being said, I just noticed somebody had already posted an alternative patch to do the update before I did, maybe that one is correct! https://issues.guix.gnu.org/46623 Anyways, I'll revert the patches tomorrow unless there are any objections! Sorry again, Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmBmQ58YHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UvI8H/ira0WDQK2mzL1FqrJvMaVE5 LMpQ+v/gwQv7ylTLTLHj9j8eiwO9LozyEq5jc2xi45/ttUd+0JZsRY3CalkyrYwG FJykPPGnBxgrdmTx/Slv+EMW9jh7NVJN8IfaLD7gUcSkxIxPVk8gobQ23Dr+O3OP Oi/tISwK+yHpbjjnLLLWcTzd0ZQgW/6YB5Cy7lvejPaKYxJPkX0QC5hIQN5cx0eR chsfpdP5cLzCAidR9iR7lLrOwgDNux5AMKF0JsoJ6uQftLRA7cSSO4NjGXBc7iLv 3cbPd8FCFdenSKWiRt6JLD4IhtjzzkEwrS4WqHoB8dyDBzYCu5vn/fZ2kQEv2+c= =v8dX -----END PGP SIGNATURE----- --=-=-=--