From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iAXEOv5HaWH1NQAAgWs5BA (envelope-from ) for ; Fri, 15 Oct 2021 11:21:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WP+KNv5HaWEsXQAAB5/wlQ (envelope-from ) for ; Fri, 15 Oct 2021 09:21:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 215F71388D for ; Fri, 15 Oct 2021 11:21:02 +0200 (CEST) Received: from localhost ([::1]:49452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbJOe-0001fE-Ca for larch@yhetil.org; Fri, 15 Oct 2021 05:21:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbJHu-0007FO-A5 for bug-guix@gnu.org; Fri, 15 Oct 2021 05:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54769) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mbJHu-0007v4-18 for bug-guix@gnu.org; Fri, 15 Oct 2021 05:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mbJHt-0002uk-Pc for bug-guix@gnu.org; Fri, 15 Oct 2021 05:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#44953: lsof: LTlock test consistently fails (possibly due to btrfs) Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 15 Oct 2021 09:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44953 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer , raingloom Received: via spool by 44953-submit@debbugs.gnu.org id=B44953.163428921311159 (code B ref 44953); Fri, 15 Oct 2021 09:14:01 +0000 Received: (at 44953) by debbugs.gnu.org; 15 Oct 2021 09:13:33 +0000 Received: from localhost ([127.0.0.1]:38082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbJHQ-0002tv-Iq for submit@debbugs.gnu.org; Fri, 15 Oct 2021 05:13:32 -0400 Received: from world.peace.net ([64.112.178.59]:51484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbJHM-0002te-2R for 44953@debbugs.gnu.org; Fri, 15 Oct 2021 05:13:31 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mbJHF-0003Mj-8a; Fri, 15 Oct 2021 05:13:21 -0400 From: Mark H Weaver In-Reply-To: <87zgranctj.fsf@gmail.com> References: <87zh2zdgfh.fsf@netris.org> <874kl7zw4u.fsf@nckx> <87r1obd41k.fsf@netris.org> <20201205025736.50b83726@riseup.net> <87zgranctj.fsf@gmail.com> Date: Fri, 15 Oct 2021 05:11:20 -0400 Message-ID: <871r4mbqjw.fsf@netris.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44953@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634289662; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=+CrebFo6AlBKNk/p0+9rsrOfeBbfpElyMX7zrpt5I4Q=; b=l+SnyKuvcHsO5qh50GN1Viw3QntuQKOm7Hd1H7oxlaidke0oBrnfAHC6YapyX7Unec3XOT X0ppec/fT75+L5ESH/5r7gExvUwKhIP4HT26StPz+xaBo2kUASYugy4NOdgq+jDOc3thdG k9KlpbZgRn1SwLjItihRS54TMVr35leV+9RcedaW1LDoUEfv7ivR3+Vin/tx0dYZT+52hv 4QFOHvkrA9M1gzJ1maSx74hd2UDZ60PfPjDjmK30Fj0FwFeuvWIt3QUKdKMsVC9/K6A4yi 8WwzkNKS8243n11X2jLHRS5cu/FsusUkaIZA1BW5P4waobQ7QG0L47Mkzn7OXw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634289662; a=rsa-sha256; cv=none; b=nduK4ZFYbXthXRpL/Trb7AmeKe360dEmGJUErryEcE/IJ0vExfrDdsEWQb6KmXYWa8wv0F IIYNUaZr6EDM14bfvsMNim2u8fhMvzViTBzyY4kM+w16tD1dU0WBRk4ea+cvh8QoDmRP6W U19WdJjp5EGYGkiw8o3RqY9e0AK/cZ366rhjw5edK5vxvlQXAaj3liaWjSUfqRuxhySJ6F k8RU5Ef3qyiQaHrMosav/H7PQIu0X66+fR47YsLeo0nzThVr6/qVDx5DrjAtvpHzfGHgKk luNu2wCJ2uX9mGTTed0pOFYgVWnaB14GfO/dExCs9NzxzhXfHRomefw8iQyd/A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.42 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 215F71388D X-Spam-Score: -2.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: 0TFmhm2FaCl2 --=-=-= Content-Type: text/plain Hi Maxim, Maxim Cournoyer writes: > For the record it seems Tobias had gotten around filing a bug here: > https://github.com/lsof-org/lsof/issues/152. > > It seems the issue is real and a new Linux-specific tool lsfd is being > devised. I guess we should disable the test, as the package is still > probably mostly functional on Btrfs, and wait for a proper resolution > from upstream? > > Mark, could you share your patch disabling the test if you still have it > handy? Here's what I did on my private branch, which has diverged quite a bit from master, so I don't know whether it will apply cleanly. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Revert-gnu-lsof-Make-test-failures-fatal.patch Content-Description: [PATCH] Revert "gnu: lsof: Make test failures fatal." >From 1a658341538b8ea1470ef1bd02dfb3922011df79 Mon Sep 17 00:00:00 2001 From: Mark H Weaver Date: Sun, 29 Nov 2020 16:03:57 -0500 Subject: [PATCH] Revert "gnu: lsof: Make test failures fatal." This reverts commit 2bf502138c9c8cad945866061772fe0e1f4b7175. --- gnu/local.mk | 1 - gnu/packages/lsof.scm | 3 +- .../patches/lsof-fatal-test-failures.patch | 58 ------------------- 3 files changed, 1 insertion(+), 61 deletions(-) delete mode 100644 gnu/packages/patches/lsof-fatal-test-failures.patch diff --git a/gnu/local.mk b/gnu/local.mk index eaa358266a..f53ceb35e9 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1378,7 +1378,6 @@ dist_patch_DATA = \ %D%/packages/patches/lm-sensors-hwmon-attrs.patch \ %D%/packages/patches/lrcalc-includes.patch \ %D%/packages/patches/lsh-fix-x11-forwarding.patch \ - %D%/packages/patches/lsof-fatal-test-failures.patch \ %D%/packages/patches/lua-CVE-2014-5461.patch \ %D%/packages/patches/lua-pkgconfig.patch \ %D%/packages/patches/lua51-liblua-so.patch \ diff --git a/gnu/packages/lsof.scm b/gnu/packages/lsof.scm index b317902ee7..3e527a272f 100644 --- a/gnu/packages/lsof.scm +++ b/gnu/packages/lsof.scm @@ -41,8 +41,7 @@ (commit version))) (file-name (git-file-name name version)) (sha256 - (base32 "0yxv2jg6rnzys49lyrz9yjb4knamah4xvlqj596y6ix3vm4k3chp")) - (patches (search-patches "lsof-fatal-test-failures.patch")))) + (base32 "0yxv2jg6rnzys49lyrz9yjb4knamah4xvlqj596y6ix3vm4k3chp")))) (build-system gnu-build-system) (native-inputs `(("groff" ,groff) ; for soelim diff --git a/gnu/packages/patches/lsof-fatal-test-failures.patch b/gnu/packages/patches/lsof-fatal-test-failures.patch deleted file mode 100644 index e874ba6ad4..0000000000 --- a/gnu/packages/patches/lsof-fatal-test-failures.patch +++ /dev/null @@ -1,58 +0,0 @@ -From: Tobias Geerinckx-Rice -Date: Mon, 23 Nov 2020 05:36:53 +0100 -Subject: [PATCH] gnu: lsof: Make test failures fatal. - -Submitted upstream[0]. - -[0]: https://github.com/lsof-org/lsof/pull/144 - -diff --git a/tests/Makefile b/tests/Makefile -index 08574a0..2923bb8 100644 ---- a/tests/Makefile -+++ b/tests/Makefile -@@ -27,7 +27,7 @@ all: ${CKTSTDB} ${BASTST} ${STDTST} FRC - exit 1 ;\ - fi - @rm -f config.LT* -- -@err=0; \ -+ @err=0; \ - echo ""; \ - echo "Basic test:"; \ - ./${BASTST}; \ -@@ -54,8 +54,11 @@ all: ${CKTSTDB} ${BASTST} ${STDTST} FRC - echo "Suggestion: try the optional tests: \"make opt\""; \ - echo ""; \ - fi; \ -- fi; -- @rm -f config.LT* -+ fi; \ -+ rm -f config.LT*; \ -+ if [ $$err -ne 0 ]; then \ -+ exit 1; \ -+ fi - - auto: ckDB silent FRC - -@@ -112,7 +115,7 @@ LTunix: LTunix.c ${CONFIG} ${LIBOBJ} ${HDR} config.ldflags - - opt: ${CKTSTDB} ${OPTTST} FRC - @rm -f config.LT* -- -@err=0; \ -+ @err=0; \ - echo ""; \ - echo "Optional tests:"; \ - for i in ${OPTTST}; do \ -@@ -126,8 +129,11 @@ opt: ${CKTSTDB} ${OPTTST} FRC - else \ - echo "All optional tests succeeded."; \ - fi; \ -- echo ""; -- @rm -f config.LT* -+ echo ""; \ -+ rm -f config.LT*; \ -+ if [ $$err -ne 0 ]; then \ -+ exit 1; \ -+ fi - - optional: opt - -- 2.31.1 --=-=-= Content-Type: text/plain -- Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about . --=-=-=--