From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qKSEOHv0amFqjwAAgWs5BA (envelope-from ) for ; Sat, 16 Oct 2021 17:49:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6MMfNHv0amEFaQAAbx9fmQ (envelope-from ) for ; Sat, 16 Oct 2021 15:49:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5E5702E892 for ; Sat, 16 Oct 2021 17:49:15 +0200 (CEST) Received: from localhost ([::1]:48358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mblvu-0000uY-GG for larch@yhetil.org; Sat, 16 Oct 2021 11:49:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mblvi-0000uG-Mk for bug-guix@gnu.org; Sat, 16 Oct 2021 11:49:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mblvi-0000Jk-CJ for bug-guix@gnu.org; Sat, 16 Oct 2021 11:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mblvi-0006qI-9M for bug-guix@gnu.org; Sat, 16 Oct 2021 11:49:02 -0400 Subject: bug#50677: [PATCH] Minetest basic_materials really depends on moreores Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Sat, 16 Oct 2021 15:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 50677 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Vivien Kraus Cc: 50677-done@debbugs.gnu.org Mail-Followup-To: 50677@debbugs.gnu.org, me@tobias.gr, vivien@planete-kraus.eu Received: via spool by 50677-done@debbugs.gnu.org id=D50677.163439931126257 (code D ref 50677); Sat, 16 Oct 2021 15:49:02 +0000 Received: (at 50677-done) by debbugs.gnu.org; 16 Oct 2021 15:48:31 +0000 Received: from localhost ([127.0.0.1]:42857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mblvC-0006pR-RT for submit@debbugs.gnu.org; Sat, 16 Oct 2021 11:48:31 -0400 Received: from tobias.gr ([80.241.217.52]:52980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mblvA-0006pI-AZ for 50677-done@debbugs.gnu.org; Sat, 16 Oct 2021 11:48:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=fCm465yXKx0Jy RfeO/G9cNPJurcCZkXa7Mn9VDHjiiM=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=Uz5EFoEaJqFjX1bIA/EM7qqEIabdUgzvYM5XsC Kufja5UbHCxlmwBH3dBSyvxqHgur8aqK0kwWicmhB75XlsgfIBY3dXoR/qoJHCh3xTXJOm fIjqPk3QKq3BjZAItB/blYBRQ/viWEr97Edy/Wde1HGE1DB0RrmckXQhlUPbMsZdhGMbQM ezIijBgZNkZu7blM8wPHeF8Z97xTBzw4SORcyLRN3rYydY9mgNLpy93eCFt14xSEPLLixv 1pIUFPFc0xJwZ7r+a2DoMp/ZYfBj5BZ8RrwYelj+bqXiczYS2M5a+tZQQlY/XmK7aGEyrr 2RvXBnkxQCHGZ/ygB50Ls5QQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 2ae09bf1 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 16 Oct 2021 15:48:23 +0000 (UTC) References: <47d31be5bfc24646981f2f71942fedd89c556405.camel@planete-kraus.eu> <67c326ff5fd285311dab48b03f646c28690fa376.camel@planete-kraus.eu> <9d9f86773809358187afbe5c7052d09f3d4d1052.camel@telenet.be> <9f206acf24c7fc265102712912d3d0e336b54fc7.camel@planete-kraus.eu> <391c3b2b8b058845bc07630ac2cd96c06783227b.camel@planete-kraus.eu> <9f186bbdf47037b1f2b1218b0cd73141fa29e140.camel@telenet.be> <3130a74c615509be5871c4d4f69ad3e3350557a8.camel@planete-kraus.eu> Date: Sat, 16 Oct 2021 17:32:07 +0200 In-reply-to: <3130a74c615509be5871c4d4f69ad3e3350557a8.camel@planete-kraus.eu> BIMI-Selector: v=BIMI1; s=default; Message-ID: <871r4lc6np.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" Reply-to: Tobias Geerinckx-Rice From: Tobias Geerinckx-Rice via Bug reports for GNU Guix X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634399355; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=fCm465yXKx0JyRfeO/G9cNPJurcCZkXa7Mn9VDHjiiM=; b=QSxBbRgZ5V3mFHnYT118el6QPte8Qvhsrq7zsjrcfv1NiFoilEdl1K8K4hi8L2XyoVk2d0 Kiv7nBdp7KWKA+/lnpKqwAb3JqgKYYlM4RbTqvxBKNEsb1Cl5o7RUKTmSEsTOlZLFDV51X 2jjmkUjcYFfZzJ3ZQ4GBMAVzZ7ht8MemJPEPGn2hCltWjlAhR3iDvvou/vRBOWadxQxHBh Jf6tx6GCypjTvqzHxag0a2sSeMEeseapZx0GGLHNTCGSgVIowDlVZ+Hdl4bJzu4+OYhDU0 PSSWxur9pRSTz6z08tknb5+lcyN8R4OUaSh543Rm1LeKK1SXWcI8sEe32UwBtA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634399355; a=rsa-sha256; cv=none; b=HVvzqNPwI1jbfdvjhdWgnrZ/yRH4rwJ7+X0kKx35WaTuYgn6daK0hlmxLyZoqgPmnFfRhe ZaW7C+ANM/bqXR7Wa2ZX0nieJVJWejfZ0jw3hg5p05qLM/zjSksmnQTe44Rhsplxc1XvcR 6+/vd26sJpnQHmvcVSOluYVRBo8J+j5z0BxtkGnAdRQ3/Izggy1dsZuRML60CqDjhl5Z32 ozAK/1Qx6LFtyigkZHbvxWwY75dOiyF2CbunFSI7JQ6bXdd5voF11JBvEiiWbQs2Arq/KR /BO8yfk66zhuYqq8GfpJ43c0nngSEc1Ni5OEt95bGm5kgYwGwj0Dp18kXQPu7w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=Uz5EFoEa; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -4.52 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=Uz5EFoEa; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 5E5702E892 X-Spam-Score: -4.52 X-Migadu-Scanner: scn0.migadu.com X-TUID: j0w6AR/oUtHo --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Vivien, Thanks! I've pushed this series as=20 df2404482495bc3af03e7fc902af1e6b0d10b4a4 et al. I made a only few small tweaks, mainly to the commit message: > gnu: minetest-basic-materials: Depend on minetest-moreores. =E2=80=98Depend=E2=80=99 sounds wrong to me; it either does, or it doesn't,= we=20 don't determine that. Changed to =E2=80=98Propagate =E2=80=A6=E2=80=99 > * minetest.scm (minetest-basic-materials): Add minetest-moreores=20 > as a propagated input. Keep Git commit message body lines <=3D72 characters. Most=20 (non-Guix) tooling is built around that assumption. Also use full relative file names, and use [field] notation where=20 appropriate: * gnu/packages/foo.scm (foo)[propagated-inputs]: Add bar. For the build system patches, I changed > guix: minetest-build-system: [=E2=80=A6] to build-system/minetest: [=E2=80=A6] Why? Because it's shorter. Is this a documented rule? I can't=20 say! > ;; basic_materials:silver_wire cannot be crafted without > ;; moreores:silver_ingot. Documenting this is a great idea. > (commit "0b6f669df4c9b7771c03e0e6ba8effb471cdfcae"))) I changed this to (commit (string-append "v" version)) to use the git tag. Both have advantages & disadvantages, but this is our currently=20 preferred style. > (synopsis "Adds new ore types") > (description "More ores for Minetest.") These aren't acceptable. See (guix)Synopses and Descriptions. This was my attempt at improving the importer's lazywork: (synopsis "Additional ore types, tools, swords, and rails for=20 Minetest") (description "This Minetest mod adds new ore types to the game (mithril,=20 silver) as well as swords and tools made of different materials. It also adds=20 copper rails.") Bit vague, but you know why. Closing; thanks! T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYWr0Sg0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15hP4A/RitNDMPe62Fyacx5fjHxi7t8bPHJ4Q+eOdHJB+q sIHoAQDRb8iRRg3TJq+3PpBIF2inHT1uBO/Ubo0Dtc/eY6sYCQ== =pw25 -----END PGP SIGNATURE----- --=-=-=--