From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SN3yKJA0l2I7tQAAbAwnHQ (envelope-from ) for ; Wed, 01 Jun 2022 11:42:40 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yLztKJA0l2JFLQEA9RJhRA (envelope-from ) for ; Wed, 01 Jun 2022 11:42:40 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F0A10A6C3 for ; Wed, 1 Jun 2022 11:42:39 +0200 (CEST) Received: from localhost ([::1]:36676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwKsA-0001RV-3x for larch@yhetil.org; Wed, 01 Jun 2022 05:42:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwKpe-0008BI-H2 for bug-guix@gnu.org; Wed, 01 Jun 2022 05:40:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55854) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nwKpe-0001CF-7a for bug-guix@gnu.org; Wed, 01 Jun 2022 05:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nwKpe-0006ML-2x for bug-guix@gnu.org; Wed, 01 Jun 2022 05:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#55499: [PATCH 2/3] profiles: Do not repeat entries in 'manifest' file. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 01 Jun 2022 09:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55499 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxime Devos Cc: 55499@debbugs.gnu.org Received: via spool by 55499-submit@debbugs.gnu.org id=B55499.165407634924373 (code B ref 55499); Wed, 01 Jun 2022 09:40:02 +0000 Received: (at 55499) by debbugs.gnu.org; 1 Jun 2022 09:39:09 +0000 Received: from localhost ([127.0.0.1]:49751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwKon-0006L0-K9 for submit@debbugs.gnu.org; Wed, 01 Jun 2022 05:39:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwKoi-0006KP-Iv for 55499@debbugs.gnu.org; Wed, 01 Jun 2022 05:39:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58746) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwKob-0000zm-Qp; Wed, 01 Jun 2022 05:38:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=NZuJ008OqUDMWavsG0QgkjzCxpdT8/63bRqMAdnjyWc=; b=ns5AHlUSfXcIl1VdNSy1 967vxfCJeQjfZuGKAyqbwSmOiaRO/qTR/t/oyQ+mxdWDlPrxuedwORuo8KQ5JBipvZRIsdZ/WVOGR S0CsI87slKvdsyq8IqY6h8rUKNZyFZLHzK6F68bawsLFQrbzGfMPHXJTSRiCKY81YC5kqFfqu/FcH vpFjcaD8cbTd420RbO2vQSeUf02yxklbdaV3eDlE5/+PH35B/Xt+R5CIJikbRaRA8J51cs3iqjVoI cMrWlPrOJgLyUMKhhcKj+V5LAfgBAFPRecfwpqsxVXbSuILZi3/fTnzxUJD9Rz7a9VCC6hjLrd0Lm Fh5jkPN9QPXYQA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:61113 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwKob-0005az-Dp; Wed, 01 Jun 2022 05:38:57 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87sfp7kkim.fsf@elephly.net> <20220531160916.21508-1-ludo@gnu.org> <20220531160916.21508-3-ludo@gnu.org> <10a79d0be70467d59fffd225b18f0bbd17ccdba3.camel@telenet.be> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Tridi 13 Prairial an 230 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du Pois X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 01 Jun 2022 11:38:54 +0200 In-Reply-To: <10a79d0be70467d59fffd225b18f0bbd17ccdba3.camel@telenet.be> (Maxime Devos's message of "Tue, 31 May 2022 19:35:50 +0200") Message-ID: <871qw8yb81.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654076560; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=NZuJ008OqUDMWavsG0QgkjzCxpdT8/63bRqMAdnjyWc=; b=PPmA8nZHiHRv9s/dIehtfJIqvQjjA2r5mMH278+vKusCB+JQhlmISwQvVn8ZsSAHRM0UQY MBwPe9YA41Qhx3RSn2i/97GOwxESgOzrFJ8LkgwuXPcA2UKwazQHfvTAAWSVwVGFFm+Nee v8T6D+J/LBYH+P8xIDHuFZpa422TIimgAw0hCwwVKrvkRyPjvqgJxUvUxNf6KlT5IxVwIN ungGhgvcouvDfppr46FGLm9Efu9edRermgltowGQ4QYE5oR03FG6Lo0pRnoLDMNzQ4nT/r bYeZ0CeiptbSY1dGKpjzzHxHbodlWBPP9sxnP4XD89yXtoL2NZom0d1+SyVbqA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654076560; a=rsa-sha256; cv=none; b=ES4wOkfdMJjIWZhKRoq9gfeob5rjUTHqEJtDRyjrLnWqWId0ham1heD6b4GQXH23ui1UqQ aHfTDgv8gPpZH1FtALzpDOrzb/33lG84sl3Od8obLczw/eGGevw3JboV9jZgZFK+n4HiaQ OSF+cAZRJ9GrcKl0RN6viVJA9aOqawXLb09njQzd/Wzt6caOEwA8UZTx63PGrrALT2fB6S PaUO3PQj/ahp2r8iGCTXwsF5JFj4UqIAoorw5pyhOg622oNc1aDV/mYS+p7fW+nM0sEK8q dPphNmAEESSvEk98o3KoXmv6pLZMt2gMzsu1VPQzd8lVdFUd9RSq5dh4BRE63w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ns5AHlUS; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ns5AHlUS; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F0A10A6C3 X-Spam-Score: -2.43 X-Migadu-Scanner: scn1.migadu.com X-TUID: bW9Dplc3DoYi Hi, Maxime Devos skribis: > Ludovic Court=C3=A8s schreef op di 31-05-2022 om 18:09 [+0200]: >> With this change, the manifest file created for: >>=20 >> =C2=A0 guix install r r-seurat r-cistopic r-monocle3 r-cicero-monocle3 r= -assertthat >>=20 >> goes from 5.6M to 192K.=C2=A0 Likewise, on this profile, wall-clock time= of: >>=20 >> =C2=A0 GUIX_PROFILING=3Dgc guix package -I >>=20 >> goes from 0.7s to 0.1s, with heap usage going from 55M to 9M. > > I'm not familiar enough with this part of Guix to evaluate the patches, > but the time, disk memory and heap memory decreases sound great! Yup! The difference is significant primarily for profiles with lots of propagated inputs, so typically profiles with R or Python packages. For my home profile (300+ packages but no R and no Python), it goes from 316K to 112K, heap usage for =E2=80=98guix package -I=E2=80=99 goes from 12= M to 9M and wall-clock time is almost unchanged. Ludo=E2=80=99.