From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mJ8lOYac3mL4HgEAbAwnHQ (envelope-from ) for ; Mon, 25 Jul 2022 15:37:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IJwUOYac3mKp2gAA9RJhRA (envelope-from ) for ; Mon, 25 Jul 2022 15:37:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8D042CAD4 for ; Mon, 25 Jul 2022 15:37:10 +0200 (CEST) Received: from localhost ([::1]:47038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFxc3-0005Yw-Ap for larch@yhetil.org; Mon, 25 Jul 2022 08:55:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFxGg-0006o7-6t for bug-guix@gnu.org; Mon, 25 Jul 2022 08:33:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59743) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oFxGf-0007tv-Sk for bug-guix@gnu.org; Mon, 25 Jul 2022 08:33:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oFxGf-0003Nm-Ol for bug-guix@gnu.org; Mon, 25 Jul 2022 08:33:01 -0400 Subject: bug#44893: `guix deploy` doesn't recognize option --dry-run Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Mon, 25 Jul 2022 12:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 44893 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 44893-done@debbugs.gnu.org, Jesse Gibbons , zimoun Mail-Followup-To: 44893@debbugs.gnu.org, maxim.cournoyer@gmail.com, jgibbons2357@gmail.com Received: via spool by 44893-done@debbugs.gnu.org id=D44893.165875232212917 (code D ref 44893); Mon, 25 Jul 2022 12:33:01 +0000 Received: (at 44893-done) by debbugs.gnu.org; 25 Jul 2022 12:32:02 +0000 Received: from localhost ([127.0.0.1]:49490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFxFh-0003M3-Qe for submit@debbugs.gnu.org; Mon, 25 Jul 2022 08:32:02 -0400 Received: from mail-qv1-f48.google.com ([209.85.219.48]:37436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFxFe-0003Lj-8m for 44893-done@debbugs.gnu.org; Mon, 25 Jul 2022 08:32:00 -0400 Received: by mail-qv1-f48.google.com with SMTP id m10so8269402qvu.4 for <44893-done@debbugs.gnu.org>; Mon, 25 Jul 2022 05:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=sZDhnFH7pJlv/WUKNr+6YBcqM7QxbYIvEUR4D2dA83o=; b=ZIRqTOxVtiNJM94QHMC0UgXXCva1W8o8p1brNgRkdTjGptJsuNKU/7adl6sBSA0l1J 7MLNLLFUBnh/hLLoxAgM9PBXSFanVbj3PIiH0Oq4B4TBzPy8k/ZxXzLZThwESsIKjqSA bnS3xkiKIyULPIdDLmKa0h6GFWe7QYwh/VguxVQo4+W6/rwSTsM/OgFi9pMjLbB++JU2 51Rdy7tZOa22WMBMFGhQzaQSopZEa0m0sG5XHYwBVU72OFzWeQVwGVMFC2vEQTL7EPWY StvKq9BY9DYSAE4xwKgas7jZYxdkwwW1Jxzhc1wn71aJPwKFA1fqLLcUvYVuR2BEprce ggEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=sZDhnFH7pJlv/WUKNr+6YBcqM7QxbYIvEUR4D2dA83o=; b=XERXDDCHIhFEufyW9/DtDrMaf8WwRPF0OPN/qFObiqReKI5+ePOHp2ubM1RUMGGs5j zlVahHhpADyy4mMB11Sgjadq34aOsFtew3GOoRtQxZ96MjIgdo6PtaPWzWOppiG0gnYC d+9DS0bkG8w27SNOrf2sQOMlf2ZPHrvwx4IQKG3M23ovhypNi1Q3tm70RbODkOqDhTfG oOVgY8PdiKKuqyW/lQGn0+/uGliGcUBWsakNReftO3a8hZQZk9H5g2PPE93l9vPQ18P+ 6yBaIYJR+P9Ayq+O7utMWntaKUPX2eUG1p3zrmP+F17jzHYIbTtUXoRN+XYDxEHS422N MC9Q== X-Gm-Message-State: AJIora+TQIfbZLINutan6R48lhxei7fKgUWcLesoJesdC+8KYK+dhGlZ es7J45yViVcUyVGj644Q5xuB1BhYjVs= X-Google-Smtp-Source: AGRyM1vhe6FMBU6nN3fI83/J+g3DnH3l0bcou8DpjM43tHdhabUzxzK1lM89oQRM4AVdszoHH8f1vg== X-Received: by 2002:a0c:9022:0:b0:473:5be3:321 with SMTP id o31-20020a0c9022000000b004735be30321mr10048223qvo.79.1658752312492; Mon, 25 Jul 2022 05:31:52 -0700 (PDT) Received: from hurd (dsl-205-151-56-93.b2b2c.ca. [205.151.56.93]) by smtp.gmail.com with ESMTPSA id o62-20020a374141000000b006b56a4400f6sm8908249qka.16.2022.07.25.05.31.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jul 2022 05:31:52 -0700 (PDT) From: Maxim Cournoyer References: <33204938-938e-a699-85c0-89c97bbf09b6@gmail.com> <867dq5rc37.fsf@gmail.com> <87r1o472lo.fsf@gnu.org> Date: Mon, 25 Jul 2022 08:31:50 -0400 In-Reply-To: <87r1o472lo.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 05 Dec 2020 15:24:19 +0100") Message-ID: <871qu99xvt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658756230; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=sZDhnFH7pJlv/WUKNr+6YBcqM7QxbYIvEUR4D2dA83o=; b=edL1lOzD4rQcZo4xvykUnPo7RBbdYvR8MvM7gpCBLdyx3TE7Jlfy1QfTyC7kYhGVlkimNe saGxiWgJO9arAWivGvNESarEYewCk9e1CZsvT2Kg2OSf46FayZrTMXW8as6OztSiduuCOK i5LY2RZC1Xph2fGz22PchMIzXbp58OFadihtAsgLJW97sWhhuNbhfMmlpEI2D2BT/eqSFE PZhr6LmRYO8caNLbmf4huAXiNyeAVilm6uOuRmsQp5wsCC4sNX5SNQM1WIaLe255wKp5On 4k2Yl2AA4kLcB3v+IVrXzKw/rQl0hAklBYQjqt8hejWtwylyAcx/f2oFNWtEyA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658756230; a=rsa-sha256; cv=none; b=AIGO7neNLx/1YPExO3wRbA2h4q/kdXeMjU0NwFUpt4lTQ8OrNtQfmeO2Cl5HOcomrjnX2e ifF+nGTrT24yyND1zIZ610dh3+9X02a4M9mUA9028tVU7gzBUp+XrTAbrwN7eG7IPuoEQX 9v+MuLUyJ8T9krxzN5NXX9yKrL4AUMQ470bfIU8nxiKqn0OjN4qH1QkSLt1Ds7oqXkwAYd imZaJueL0maBkmzkvm1zD9MMPA7W6aflG1MDe5dWVmgFfsCC5N0uKHUlpjQ0XcD3tc4W7I 4SyKevychvdd7ljntBrY8F7TDLfrbMWlMRA+Ko+1/O3MRyzHPJ8DMTHldm6Bdg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=ZIRqTOxV; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 9.07 X-Spam: Yes Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=ZIRqTOxV; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8D042CAD4 X-Spam-Score: 9.07 X-Migadu-Spam: Yes X-Migadu-Scanner: scn1.migadu.com X-TUID: wbxk9MAZLUID Hi, Ludovic Court=C3=A8s writes: > Hi, > > We can make this change: > > diff --git a/guix/scripts/deploy.scm b/guix/scripts/deploy.scm > index 0725fba54b..d9371b3d4a 100644 > --- a/guix/scripts/deploy.scm > +++ b/guix/scripts/deploy.scm > @@ -165,7 +165,9 @@ Perform the deployment specified by FILE.\n")) > (with-build-handler (build-notifier #:use-substitutes? > (assoc-ref opts 'substitut= es?) > #:verbosity > - (assoc-ref opts 'verbosity= )) > + (assoc-ref opts 'verbosity) > + #:dry-run? > + (assoc-ref opts 'dry-run?)) > (parameterize ((%graft? (assq-ref opts 'graft?))) > (map/accumulate-builds store > (cut deploy-machine* store <>) > > > It may not be the kind of =E2=80=9Cdry run=E2=80=9D that users have in mi= nd for =E2=80=98guix > deploy=E2=80=99, as you note zimoun, but that=E2=80=99s probably better t= han nothing. > > Thoughts? I see such a fix was pushed as ff94f9dfde; closing! Thank you, Maxim