unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 55549-done@debbugs.gnu.org
Subject: bug#55549: Parted 3.5 update breaks installer tests
Date: Fri, 05 Aug 2022 09:02:28 +0200	[thread overview]
Message-ID: <871qtv18cb.fsf@gnu.org> (raw)
In-Reply-To: <87ee0lqqnb.fsf@gnu.org> ("Ludovic Courtès"'s message of "Sun, 22 May 2022 22:05:44 +0200")


Hey Ludo,

> Mathieu, I’m guessing the cause of the problem, when using Parted 4.5,
> is that the installer partitions disks somewhat incorrectly, as reported
> by ‘grub-install’.  I wonder if it might be due to an API or ABI change
> that goes unnoticed in Guile-Parted because it uses the FFI.

This is caused by a regression in Parted 3.5 introduced by
15c49ec04f7eaff014d2e1eddd0aecf4150db63d.

The gpt_partition_set_system call can undo what's done by
gpt_partition_set_flag call. This imposes us to reverse the call order
and make sure that gpt_partition_set_system is called before
gpt_partition_set_flag.

Fixed with: 3c381af76a144a4dc3d0f9269f43ee2ec501b538. I think we can
report that one upstream.

Thanks,

Mathieu




  reply	other threads:[~2022-08-05  7:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20 21:30 bug#55549: Parted 3.5 update breaks installer tests Ludovic Courtès
2022-05-22 20:05 ` Ludovic Courtès
2022-08-05  7:02   ` Mathieu Othacehe [this message]
2022-08-05  8:33     ` Ludovic Courtès
     [not found] ` <handler.55549.D55549.16596829585938.notifdone@debbugs.gnu.org>
2022-08-05  7:19   ` Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qtv18cb.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=55549-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).