From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Vong Subject: bug#37150: Erroneous uses of regex in the invokation of FIND-FILES Date: Fri, 23 Aug 2019 11:55:00 +0800 Message-ID: <86zhk0h6y3.fsf@gmail.com> References: <864l29iki4.fsf@gmail.com> <87mug1ylg3.fsf@netris.org> <861rxcioit.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:36844) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i10gF-0008Aq-7D for bug-guix@gnu.org; Thu, 22 Aug 2019 23:56:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i10gE-0007te-3b for bug-guix@gnu.org; Thu, 22 Aug 2019 23:56:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58157) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i10gD-0007tY-Ru for bug-guix@gnu.org; Thu, 22 Aug 2019 23:56:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i10gD-0005JM-Oy for bug-guix@gnu.org; Thu, 22 Aug 2019 23:56:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <861rxcioit.fsf@gmail.com> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: 37150@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hello Mark, >> You're right. It would be good to fix these problems incrementally, as >> long as the changes don't cause too many rebuilds. >> I agree we should fix it incrementally, like how the 'invoke' transition was handled. The patch below does exactly that (it fixes the problem for delta which causes 6 rebuilds only according to "guix refresh -l"). --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-gnu-delta-Fix-regex-in-the-invokation-of-find-files.patch Content-Transfer-Encoding: quoted-printable From=20cb5f2febd564a2bcb550de537156db59588098c4 Mon Sep 17 00:00:00 2001 From: Alex Vong Date: Fri, 23 Aug 2019 11:06:49 +0800 Subject: [PATCH] gnu: delta: Fix regex in the invokation of 'find-files'. See for more information. * gnu/packages/debug.scm (delta)[arguments]: Fix regex. =2D-- gnu/packages/debug.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/debug.scm b/gnu/packages/debug.scm index 82631deef6..e1cba5d3fe 100644 =2D-- a/gnu/packages/debug.scm +++ b/gnu/packages/debug.scm @@ -75,7 +75,7 @@ (begin (for-each (lambda (h) (install-file h doc)) =2D `("License.txt" ,@(find-files "www" ".*\\.htm= l"))) + `("License.txt" ,@(find-files "www" "\\.html$")= )) (for-each (lambda (b) (install-file b bin)) `("delta" "multidelta" "topformflat")))) =2D-=20 2.23.0 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable >> Changes to core packages will need to wait for now, since 'core-updates' >> is frozen, and 'core-updates-next' should also be considered frozen, >> since it will become 'core-updates' as soon as Berlin has built it out a >> bit more. (The only change in 'core-updates-next' relative to >> 'core-updates' is that the new bootstrap tarballs have been fixed to be >> deterministic.) >> >> For some of these fixes, it might be best to apply them to 'staging'. >> >>> Right now, the erroneous use of regex in CUSTOM-GCC casues the 'bin/' >>> directory of the output of gccgo, gcc-objc and gcc-objc++ to be empty. >> >> I'm uncertain how many rebuilds it would trigger to change 'custom-gcc', >> and I don't have confidence that "guix refresh -l" is capable of giving >> us a reliable answer. In the meantime, would you like to file a bug >> report for this, so it's not forgotten? >> It would probably cause a world rebuild... I will wait for the next cycle for patch submittion. >> Thanks for looking into it. >> >> Best, >> Mark You're welcomed! =2D-=20 Stand with Hong Kong! #Eye4HK #BoycottMulan Alex https://twitter.com/freedomhkg https://twitter.com/stand_with_hk --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQQwb8uPLAHCXSnTBVZh71Au9gJS8gUCXV9jlAAKCRBh71Au9gJS 8m0xAP9eWbx+nuJ7TlmIUiinZA//diChWzWivt0ay23kR806tQD+LuqLxadqBzgo NE5rZb0DbRkdhmQoF5MVdJ8+4bdq0Qw= =8hgq -----END PGP SIGNATURE----- --==-=-=--