unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: Julien Lepiller <julien@lepiller.eu>,
	57581@debbugs.gnu.org,
	Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: bug#57581: Failing to build the website
Date: Wed, 07 Sep 2022 19:07:10 +0200	[thread overview]
Message-ID: <86y1uvxge9.fsf@gmail.com> (raw)
In-Reply-To: <87o7vr2lk7.fsf@pelzflorian.de>

Hi,

On Wed, 07 Sep 2022 at 18:31, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote:
> zimoun <zimon.toutoune@gmail.com> writes:
>> The culprit seems the package ’qtserialport’ in ’packages-builder’ from
>> (apps packages builder).  Maybe introduced by commit
>> 1ef04fb2288dade3ad2883026ae286a68ef13a1e.
>
> This was a first failing commit for me too, but the reason the website
> does not build appears to be the license field of qtshadertools in
> commit 1d65ff8fdeb20cc2db956093f0ecb1f3f72afc0e (Cc to Maxim).  I could
> make a patch but not today.  Maxim, would you fix it?

From my opinion, this

--8<---------------cut here---------------start------------->8---
+    (home-page (package-home-page qtbase))
[...]
+    (license (package-home-page qtbase))))
--8<---------------cut here---------------end--------------->8---

is a bad practise; instead ’(inherit qtbase)’ and rewrite all the others
fields is better.

> I don’t know if there is a way to catch such mistakes early.  Field
> sanitizers?

Well, the field reads,

+    (license (package-home-page qtbase))))

so why is the compiler accepting that?  Is a warning raised?



Cheers,
simon




  reply	other threads:[~2022-09-07 17:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-04 15:18 bug#57581: Failing to build the website Julien Lepiller
2022-09-05  8:35 ` zimoun
2022-09-05 10:27   ` Julien Lepiller
2022-09-05 11:57     ` zimoun
2022-09-05 10:59   ` pelzflorian (Florian Pelz)
2022-09-05 12:04     ` zimoun
2022-09-05 12:50       ` Julien Lepiller
2022-09-05 14:35 ` zimoun
2022-09-07 16:31   ` pelzflorian (Florian Pelz)
2022-09-07 17:07     ` zimoun [this message]
2022-09-07 17:14       ` Julien Lepiller
2022-09-08  8:00         ` zimoun
2022-09-13 14:41     ` Ludovic Courtès
2022-09-14  6:37       ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y1uvxge9.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=57581@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    --cc=maxim.cournoyer@gmail.com \
    --cc=pelzflorian@pelzflorian.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).